fanf2 / hg64 Goto Github PK

Hi,
I was porting hg64 from C to Rust. It seems to have gone pretty well except that I noticed that the docs for the pmax outparam for hg64_get doesn't match the behavior (of my port, at least). It seems to return the max value inclusive instead of exclusive as the comments show.

In Rust to meet the comment I had to use

        let max = get_maxval(key).saturating_add(1);

At first I tried +1 but rust panicked when the get_maxval returns u64::MAX.

I'm not sure whether you'd rather update the pmax documentation or add one to it carefully.