Use deterministic helper to execute the test provided in the block successive number of times about faker HOT 9 CLOSED

Hi @ak2-lucky thank you for your contribution! @fernandomenolli already has shared an interest in taking this one, I just didn't have the time to assign the issue to them earlier this week. I hope you understand. Thanks!

from faker.

@stefannibrasil I just opened a PR to this issue. Feel free to let me know if anything needs to be improved.

from faker.

Hello,
I am a junior/mid level ruby on rails dev, I am looking for some open source projects to contribute, because I believe it helps a lot the learning journey.

Would this issue to be something like this?

 # Faker::Lovecraft.word generates random word from wordlist

 def test_word
   deterministically_verify -> { @tester.word }, depth: 5 do |word|
     assert_includes @wordlist, word
   end
 end

# test/test_faker.rb:16

  def test_numerify
    deterministically_verify -> { Faker::Base.numerify('###') }, depth: 5 do |result|
      assert_match(/[1-9]\d{2}/, result)
    end
  end

If so, I think I can take this one.

In the case we have 1000.times loop, like Lovecraft.word generator, should we use depth: 40 or any other number near this?

from faker.

Thanks @stefannibrasil, gonna work on it.

from faker.

Oh, Sorry @fernandomenolli and @stefannibrasil
I've already fixed it, but I'll leave it to @fernandomenolli

@stefannibrasil
Are there any other tasks I can do?

from faker.

I want to do this myself!

from faker.

@stefannibrasil
I modified it and created a PR.
Please check it out!

#2815

from faker.

Hi @fernandomenolli yes, you can follow the existing tests implementation for the new ones.

About the depth, I don't think we need a high number. 4 or 5 looks good. Thank you!

from faker.

no worries, @ak2-lucky thanks for understanding.

I don't have details yet as this current issue but one thing we always need help with is checking the locales files, and seeing if they are working as expected. I guess trying some generators with a specific locale (portuguese, italian, etc.) and seeing if they break with the locales, would be helpful.

from faker.