Comments (5)
Hi, @mriehm. Thanks for reporting this. This looks to be related to a long-standing issue reported as #1345. We didn't take your approach at the time, possibly due ignorance, a gap in the frameworks, or a gap in the version of Castle.Core that we required at the time. I've enabled the CI build on your PR, and it's passed. Very cool.
@thomaslevesque, I'm encouraged, and wonder if this isn't an opportunity to close #1362 as well.
The timing is fortuitous as well, since we're still in the middle of 8.0.0 changes, and the fix for this issue looks like it will change the constructors that end up being used to create a Fake (before, we would've had an exception thrown by the failing constructor, caught it, and moved on to other constructors), in that a preferred constructor containing an in
parameter may now succeed, and the Fake or Dummy might have slightly different properties.
from fakeiteasy.
Thanks for reporting this, @mriehm!
I just checked, and the issue also applies to ref
and out
parameters. Not something you encounter every day, but still, it should be fixed.
from fakeiteasy.
Oh, good thinking. Shall we add a pair of bonus tests?
Never mind. You already asked.
from fakeiteasy.
@thomaslevesque, I'm encouraged, and wonder if this isn't an opportunity to close #1362 as well.
M. Levesque has pointed out in side chat that I am conflating two issues, and this is not such an opportunity.
from fakeiteasy.
This change has been released as part of FakeItEasy 8.0.0.
Look for your name in the release notes, @mriehm! 🏆
from fakeiteasy.
Related Issues (20)
- Match enumerable arguments by comparing contents rather than via `Equals` HOT 8
- Add assertion similar to Moq's `VerifyNoOtherCalls` HOT 8
- Feature request: ReturnsNextFromSequenceLazily() HOT 6
- Feature request: Then().Returns...() HOT 5
- Issue using Result Pattern and trying to fake a response
- Release 8.0.1 HOT 1
- Interface type property not return created object HOT 3
- How to fake a type that have `dynamic` (ExpandoObject) properties? HOT 3
- DoesNothing() and implicit creation options throws ArgumentException HOT 5
- Release 8.1.0 HOT 1
- Include README in NuGet package HOT 1
- Silence security vulnerability complaints over Microsoft.NETCore.App 2.1.0 HOT 2
- Release 8.2.0 HOT 1
- Fake does not work as argument constraint HOT 4
- Test fails on Version 8 but succeeds on Version 7 HOT 4
- Expose caught exception(s) in protected/abstract constructors HOT 10
- Invoke method after calling an Entities public method/behaviour HOT 7
- Release vNext
- Captured argument has empty Values HOT 6
- Document how to use InternalsVisibleTo from project files HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fakeiteasy.