fadion / aria Goto Github PK

Read through the entire Readme and came across a few typos:

1. Under "Aria Language" section:

If features mutable and immutable values

It features...

2. Under "Type Conversion" section:

Converting between types is handle in a few ways

handled in a ...

3. Under "Closures" section:

Some would prefer more explicit way of calling:

... prefer a more explicit ...

That is all I could find, provided that I was more focused on the content than on the grammar :)

First of all, nice work. Love the clean syntax.

I do like the idea of immutable values, but you are creating immutable variables which IMHO is very limiting. Basically that makes each let create a constant. You need immutable values, not immutable variables.

I now cannot change x at all? Not even increment it? How can you make a program to get sum of numbers? You can't create a new variable for each iteration of the summing loop.

In interpreter.go, function runStringInfix:

func (i *Interpreter) runStringInfix(operator string, left, right string) (DataType, error) { 
	switch operator { 
	case "+": // Concat two strings. 
		return &StringType{Value: left + right}, nil 
	case "<": 
		return i.nativeToBoolean(len(left) < len(right)), nil 
	case "<=": 
		return i.nativeToBoolean(len(left) <= len(right)), nil 
	case ">": 
		return i.nativeToBoolean(len(left) > len(right)), nil 
	case ">=": 
		return i.nativeToBoolean(len(left) >= len(right)), nil 
	case "==": 
		return i.nativeToBoolean(left == right), nil 
	case "!=": 
		return i.nativeToBoolean(left != right), nil 
	case "..": // Range between two characters. 
		return i.runRangeStringInfix(left, right) 
	default: 
		return nil, fmt.Errorf("Unsupported String operator '%s'", operator) 
	} 
} 

You used len(str1) and len(str2) to compare two strings, this way is not very correct. In go, we could simply use str1<str2, str1>=str2, etc. that would do the compare.