facn7 / hio-gamesofthrones Goto Github PK

the container should include 2 sections:

1. section of characters cards.
2. section for the trailer

simple issue, the video is too wide :(

the navbar should include:

1. logo/title of game of thrones
2. github logo that links to the project repo
3. Home, Characters and Trailer buttons that navigate to the chosen section.

the header should include :
styled photo

+100 points for that

You have a noticeable square border for the card, try to get rid of that also the actor's name is not showing

As you can see the menu is not showing Characters and Trailers

You should have more issues before you start typing any line of code, then you can divide the work and assign yourselves on the issues you want to work on.

Is missing

Mobile version styling can be manipulated through CSS file, which is easier, more readable, shorter and cleaner (and porpoise made for this goal) check project https://github.com/FACN7/AKN_Project/blob/master/assets/style.css
Line #113

write functions in index.js file to retrieve data from game of thrones apis

fetch and process data.

I like the idea, the high quality images and the flipping cards!
good job

When you click on navbar link, it overlays the block (e.g. part of top the pictures are hidden).
If you solve this please tell us, we also don't know how xD

I would suggest you guys to have a Section/Div for the Menu with display : flex flex-direction : row justify-content : spacebetween ... then make three "Div"s inside the first one have you Game of thrones title, the second Div for the Github icon and the third includes your hrefs instead of the "ul" and "li" you can have them in "a" or "p" not sure which is better but you can try them and check!
for the last Dev you can have a display : flex and flex-direction : row

There is a way to keep them :)