facn3 / domain-finder Goto Github PK
View Code? Open in Web Editor NEWSimple application that queries for a domain and returns IP location information as well as some historical facts.
Home Page: https://facn3.github.io/Domain-Finder/
Simple application that queries for a domain and returns IP location information as well as some historical facts.
Home Page: https://facn3.github.io/Domain-Finder/
Lets get the api xhr requests and api_call object functions pushed up.
Thank you : 0 )
https://github.com/FACN3/Domain-Finder/blob/master/dom.js#L22
what is li
and idx
? the first argument should be the name of the value you are getting and the second argument is index.
and theres gotta be better way to do this but im not sure what would it be
Thank you
i would only add local instructions
please add labels for input tags
you thought this is an issue to compliment your beautiful code didn't you?
you could really shorten these line of code by defining a variable that equals to data.archived_snapshots.closest
We need an index file with the basic divs and sections we will use.
https://github.com/FACN3/Domain-Finder/blob/master/style.css#L15
We will need to slowly eliminate the use of pixels in CSS cause it's really bad for responsiveness/mobile compatibility, it's much more encouraged and favored ( sounded poetic there a bit ) to use rem/em.
We need to work on mobile-first and html5 tags.
Searching for a 'futuristic' date shouldn't give any results
I think you guys should add more tests,
and the existing test code doesn't really text anything in your API π
We should start writing the readme file.
Its not really that clear to how use the search menu
in my opinion instead of clicking the button to go to the domain it should go automatically
or maybe the button text should be different to prevent confuse π€
https://github.com/FACN3/Domain-Finder/blob/master/main.js#L18
why did you need this object ?? why not just define the functions?
kinda empty eh?
Pls fix thanks
push these up thanks!
please check for console errors
Please upload the outline CSS. Thanks
We should insert a small text that explains the purpose of the app
not sure if is_it_there is a good var name π
also here https://github.com/FACN3/Domain-Finder/blob/master/dom.js#L59
https://github.com/FACN3/Domain-Finder/blob/master/dom.js#L70
https://github.com/FACN3/Domain-Finder/blob/master/dom.js#L68
i guess you got it by now π
also loads of console log
callbacks like this should always be error first callbacks, cause currently when an error occurs in your xhr request you are returning,
and then nothing would happen after it, it's just going to hang and the user won't know the heck just happend.
that's why in callbacks they take error first and always check if there's an error so it can handle it depending on how you told it to handle it.
ps: same goes to the archive api request
When the search results didnt find anything it returns 'undefined'
in my opinion there should be a message saying "Info not found" or something instead of
IP address: 80.178.83.138
City: Tel Aviv
State/Region: Tel Aviv
Country: Israel
Zipcode:
Timezone: Asia/Jerusalem
Coordinates: 32.0666, 34.765
A declarative, efficient, and flexible JavaScript library for building user interfaces.
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. πππ
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google β€οΈ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.