Giter Club home page Giter Club logo

uswds-design-patterns's People

Contributors

daveskender avatar dependabot[bot] avatar imgbot[bot] avatar

Watchers

 avatar

Forkers

abbijamal

uswds-design-patterns's Issues

meta descriptions not working

When trying to add HTML meta page descriptions, they do not showup. Found in #5
What we implemented:

  • meta loaded in root module
  • meta created and defined as a service in page constructors

Done when:

  • meta descriptions work
  • sitemap.xml works for all routes
  • add URL in banner mention of GitHub repo
  • more meta icons

bad external link wrapping

the problem

On mid sized iOS browser screen width (iPad Mini), this button text / icon doesn’t wrap well. There’s an unneeded   appended, or happens with zoomed scaling. This does not appear in a normal desktop web browser.

If I recall, this happens when there's a carriage return in the code between the <a>...</a> tags, strangely.

image

card image source not always accessible

When accessing the catalog, images often don't show when behind a VPN or other enterprise firewall. The error shows up as:

Request URL: https://{third-party photo inventory list URL}
Request Method: GET
Status Code: 504 Gateway Timeout (from service worker)
Referrer Policy: strict-origin-when-cross-origin

However, it's more likely that it's blocked.

image

Consider a nicer "images cannot be retrieved" user error or use a more direct / reliable image source for this demo. Possibly, host a set of usable stock images directly, without relying on third-party APIs.

Done when:

  • not using third party API for image source
  • pattern guidance updated to reflect limitations (e.g., See All and possibly Show More not appropriate for massive data.

page doesn't load at top

the problem

When navigating from the homepage design pattern cards, the routerLink uses a fragment for pages that don't need one and the page loads with partial scroll instead of at the top.

add sign not centered on iPadOS

the problem

When viewing the “suggest a pattern” tile on the home page, on an iOS mobile device, this plus sign doesn’t center vertically as it should.

image

site still loads as PWA

After attempting to remove all of the progressive web app components in 71dfd5c. Use of PWA isn't necessarily a problem if it didn't cause style conflicts between site and design pattern pages; however, when removing it, these persist:

  • it shows an "install" option when deployed, likely due to a properly defined manifest.json file

    image

  • notable page load flicker when navigating

Recommend:

  • modify (simplify) manifest.json file, rename to root manifest.json
  • add properly formatted maskable icons, including an SVG option (see manifest link)
  • merge down to one root stylesheet with special class family?

floating bubble tile menu

An alternate to Cards and grids, for an alternate short image-based menu of large touch surface options.

To do:

  • add new bubbles page (baseline)
  • refactor: reuse card catalog data, instead of hardcoded bubbles with attr.background-image
  • fix: honor page margins
  • fix: use margins instead of padding for bubble spacing (to max use of width in container)
  • consider a settings panel
  • add proper focus and hover affect, with correct colors
  • update thumbnails for pattern, social card, and README

404 page not working

the problem

The 404 page isn’t working … or I just forgot to fully implement it. It renders, but is just a blank page.

"return to top" link missing, Chrome browser only

the problem

The pattern page "return to top" link does not display, in Chrome only. It also works in Chrome in developer mode, when hosted on localhost. Maybe this was just a glitch in the build?

in Chrome

image

in Edge (and Safari)

image

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.