facebookarchive / fbnotifications Goto Github PK

current project link is https://developers.facebook.com/docs/analytics/push-campaigns

is the new link https://developers.facebook.com/docs/push-campaigns/overview ?

Right now - the only way to present a card from existing activity in onNewIntent method is to explicitly set the intent on the activity. We should add a convenience method that is able to present the card from that intent without requiring to set the intent on the activity beforehand.

Hello.
Can someone provide a swift example of the obj-c which is inside the folders?
Thanks!

After integrating you library we started getting lots of such crashes

java.lang.RuntimeException: 
at android.app.ActivityThread.performLaunchActivity (ActivityThread.java:2572)
at android.app.ActivityThread.handleLaunchActivity (ActivityThread.java:2654)
at android.app.ActivityThread.access$900 (ActivityThread.java:175)
at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1488)
at android.os.Handler.dispatchMessage (Handler.java:111)
at android.os.Looper.loop (Looper.java:207)
at android.app.ActivityThread.main (ActivityThread.java:5728)
at java.lang.reflect.Method.invoke (Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:789)
at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:679)
Caused by: java.lang.RuntimeException: 
at com.facebook.notifications.internal.asset.handlers.BitmapAssetHandler$BitmapAsset.getBitmap (BitmapAssetHandler.java:116)
at com.facebook.notifications.internal.asset.handlers.BitmapAssetHandler.createView (BitmapAssetHandler.java:193)
at com.facebook.notifications.internal.asset.handlers.BitmapAssetHandler.createView (BitmapAssetHandler.java:51)
at com.facebook.notifications.internal.asset.ParcelableAssetHandler.createView (ParcelableAssetHandler.java:117)
at com.facebook.notifications.internal.asset.AssetManager.inflateView (AssetManager.java:205)
at com.facebook.notifications.internal.view.AssetView.<init> (AssetView.java:43)
at com.facebook.notifications.internal.view.HeroView.<init> (HeroView.java:65)
at com.facebook.notifications.internal.view.CardView.<init> (CardView.java:63)
at com.facebook.notifications.internal.activity.CardActivity.displayConfiguration (CardActivity.java:196)
at com.facebook.notifications.internal.activity.CardActivity.onCreate (CardActivity.java:120)
at android.app.Activity.performCreate (Activity.java:6305)
at android.app.Instrumentation.callActivityOnCreate (Instrumentation.java:1113)
at android.app.ActivityThread.performLaunchActivity (ActivityThread.java:2519)

When creating an In-app notification in Audience > Notification > In-App Notification, when you try to send a test to a device, when tapping the notification the app will open, and as it is processing presentPushCardForRemoteNotificationPayload an exception is thrown. Symbolication isn't working for some reason but I can update as I get more info. This is after validating in the code with canPresentPushCardFromRemoteNotificationPayload

When the campaign is saved and scheduled, the code runs fine and the in-app notification is displayed.

I am using facebook sdk for events and notifications. But Google Play Console rejected my newly updated application. Below is the alert message. I am using the facebook notification SDK in my code. Can you suggest an alternative to resolve the problem

Security alert

Your app contains an Intent Redirection vulnerability. Please see this Google Help Center article for details.

Vulnerable classes:

com.facebook.notifications.NotificationsManager.presentCardFromNotification
Please fix the issue before: 

Affects APK version 7.

Go to Manage releases

Please support iOS 7

• FBNotifications required by Podfile

Specs satisfying the FBNotifications dependency were found, but they required a higher minimum deployment target.

Is Carthage compatibility working ? I keep getting the following error message:

A shell task (/usr/bin/env git checkout --quiet 6e7d0b36f73d960cea81f4f207010dc584bffb3b) failed with exit code 128:
fatal: Cannot switch branch to a non-commit '6e7d0b36f73d960cea81f4f207010dc584bffb3b'

I've read similar issues (related to Carthage & submodules), but couldn't find a solution.

Related issues:

https://github.com/Carthage/Carthage/issues/936#issuecomment-159097500
https://github.com/Carthage/Carthage/issues/135

Steps:

1. Create a file named Cartfile
2. Add github "facebook/FBNotifications" to it
3. Run carthage update

i want to use facebook analytics push campaigns in my app. i have successed integrated the ios part, but android part was failed

https://developers.facebook.com/docs/push-campaigns/android?locale=en_US

i used react-native-push-notification and could receive the notification from GCM in my app.

i have no idea to set up push campaigns for Android in React native ?

thank you !

I tried sending a in-app push but while testing it for a particular device id it throughs an exception
While investigating the issue i found that in the payload dictionary there is no key name campaign
([@"fb_push_payload"][@"campaign"]) in the dictionary.

Response of the userData

{
aps = {
alert = {
body = Test;
title = iOS;
};
"content-available" = 1;
sound = default;
};
"fb_push_card" = {
actions = {
actions = (
{
backgroundColor = "#3A84C5FF";
borderColor = "#ABABABFF";
borderWidth = 0;
content = {
"_type" = StyledText;
align = center;
color = "#FFFFFFFF";
size = 15;
text = "Button One";
};
},
{
backgroundColor = "#89A9C4FF";
borderColor = "#ABABABFF";
borderWidth = 0;
content = {
"_type" = StyledText;
align = center;
color = "#FFFFFFFF";
size = 15;
text = "Button Two";
};
}
);
background = {
"_type" = Color;
rgbaHex = "#FFFFFFFF";
};
contentInset = 10;
cornerRadius = 10;
height = 44;
layoutStyle = vertical;
style = attached;
topInset = 10;
};
backdropColor = "#333333CC";
body = {
background = {
"_type" = Color;
rgbaHex = "#FFFFFFFF";
};
content = {
"_type" = StyledText;
align = center;
color = "#333333FF";
size = 15;
text = "Body text";
};
contentAlign = center;
};
contentInset = 20;
cornerRadius = 12;
dismissColor = "#000000E6";
"fb_dashboard" = {
background = {
"_type" = Color;
rgbaHex = "#FFFFFFFF";
};
"hero_image_handle" = "";
"hero_image_id" = "";
};
hero = {
background = {
"_type" = Color;
rgbaHex = "#768C97FF";
};
contentAlign = center;
height = "";
};
size = medium;
version = "1.0";
};
}

I dug into the code and found that the "NotificationsManager.presentCard" will automatically log events such as dismiss, push opens, button click, etc.

The app successfully shows the Facebook CardActivity but I did not receive any events after dismissing the CardView.

Here is my onMessageReceived

@Override
public void onMessageReceived(RemoteMessage remoteMessage) {
    Bundle dataBundle = new Bundle();
            for (Map.Entry<String, String> entry : remoteMessage.getData().entrySet()) {
                dataBundle.putString(entry.getKey(), entry.getValue());
            }
}

My notification

Intent intent = new Intent(getApplicationContext(), MainActivity.class);
intent.putExtra("Card_Bundle",dataBundle);
PendingIntent pendingIntent = PendingIntent.getActivity(this, identifier, intent, PendingIntent.FLAG_UPDATE_CURRENT);

                //Facebook In-App Notification
                final Notification.Builder mBuilder = new Notification.Builder(this)
                        .setSmallIcon(R.drawable.notification_ic_small)
                        .setContentTitle(title == null ? "" : title)
                        .setContentText(description == null ? "" : description)
                        .setAutoCancel(true)
                        .setContentIntent(pendingIntent);

                NotificationsManager.presentNotification(
                        this,
                        dataBundle,
                        new Intent(getApplicationContext(), MainActivity.class),
                        new NotificationsManager.NotificationExtender() {
                            @Override
                            public Notification.Builder extendNotification(@NonNull Notification.Builder notification) {
                                return mBuilder;
                            }
                        }
                );

My MainActivity

NotificationsManager.presentCard(MainActivity.this, getIntent().getBundleExtra("Card_Bundle"));

Results

After adding compile 'com.facebook.android:notifications:1.+';
app is crashing
java.lang.NoClassDefFoundError: android.support.v7.widget.TintManager at android.support.design.widget.TabLayout$TabView.<init>(TabLayout.java:1185) android.support.design.widget.TabLayout.createTabView(TabLayout.java:656) android.support.design.widget.TabLayout.addTabView(TabLayout.java:695) android.support.design.widget.TabLayout.addTab(TabLayout.java:386) android.support.design.widget.TabLayout.addTab(TabLayout.java:361)

dependencies as follows
compile 'com.android.support:design:23.1.1'
compile 'com.android.support:appcompat-v7:23.1.1'

Currently, users see an alert icon which is most of the time the wrong icon to show

You should really add an option to change the small notification icon

Hi there, just noticed something while I was setting up the code in Swift.

I think the snippet should be rewritten like this in order to compile:

FBNotificationsManager.shared().presentPushCard(forRemoteNotificationPayload: userInfo, from: nil) { viewController, error in
        if let _ = error {
            completionHandler(.failed)
        } else {
            completionHandler(.newData)
        }
}

Thanks!

Recently tested out the library where the push notifications work properly (Adding notification channels) with Android Oreo but in-app notifications do not work. Please give an option to provide notification channels for in-app notifications.

App is crashing at this point for finding Null here. See the attached image

2018-01-16 12:56:58.790898+0500 APP[17245:1225043] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[NSNull doubleValue]: unrecognized selector sent to instance 0x1b215f650'

I tuned In-App Notifications. It works well. But when I set an image, I receive a wrong Bundle on Android:

... "hero":{"background":{"$GEPushCardHeroSection3":"Image","url":"my url"},..

as you can see I got strange $GEPushCardHeroSection3 key instead of _type. Because of that I can't get BitmapAssertHandler in Android notifications sdk. For another campaign with color bg I receive right data:

..."hero":{"background":{"_type":"Color","rgbaHex":"#768C97FF"},"contentAlign":"center"},...

That leads that I don't see an image at all.

I want to change Notification icon of my notification which is .setSmallIcon(android.R.drawable.ic_dialog_alert) in NotificationManager class. How can i change it to ic_launcher?

The latest release of this library available on Maven Central is 1.0.2 from 2016-06-02 (#19).

Since that release over a year ago there have been a few Android specific fixes made to this library.

• c343fb2 on 2016-06-15
• 33d6ac7 on 2017-02-11
• 672f61c on 2017-05-12

Is there a plan for releasing these in a 1.0.3 version of the library anytime soon? This library is directly linked to from the official Facebook documentation (https://developers.facebook.com/docs/push-notifications/android#android-in-app-notifications-integration) but does not seem to be consistently maintained, which is worrying as I consider using this feature in a production app.

I'm struggling to use the example payload as such.

1. It isn't valid JSON -- I can't copy-paste and send it because there are several missing commas.
2. It's missing (?) a "version" field which makes the FBNotifications framework crash on initial tests when it tries to extract version information.

At least the framework seems to think that the version field is required. I don't know.

iOS counterpart has a method for checking whether the payload has a card payload in it.
We should add this on Android, as it's generally useful to check whether we can present a card or we should go do something else.

Google introduced FCM this year, can you update the sample code with the FCM library?

btw, do you guy had tested with the FCM integration? because I can't get any notifications through creating the new campaign from Dashboard.