fac22 / fritter Goto Github PK

View Code? Open in Web Editor NEW

0.0 0.0 1.0 1.19 MB

100 Character semi-anonymous ephemeral Twitter clone.

Home Page: https://morning-brushlands-70802.herokuapp.com/

JavaScript 69.07% CSS 30.93%

fritter's People

Contributors

Forkers

moggach

fritter's Issues

Code Review 🍉

Well done on a complete application with tests and complete functionality, and for getting it deployed to Heroku! You've managed to get so much done in a short space of time, working in a team for the first time! Fantastic job.🌟

🧇 Love the name, icons and imagery on your site.

🏮Great readme, and love the inclusion of cypress tests and lighthouse.

➕➖ Uneven commits - it’s good to make sure to think about having an even amount of commits between you.

🧐 Meta description can be included too!

🚂 You know this already but you could modularise your code a bit more! Generally speaking, it’s a good habit to get into now while your file structures are small, to separate your concerns as much as possible. You can have the initial server setup in server.js, and another file can contain your routes (server.get and server.post) etc.

 Really well done!

Lines 61 to 70 in fb80839

 server.post('/', bodyParser, (request, response) => { 

 // Collects new frit message 

 const newFritMessage = request.body.message; 

 const newFritName = request.body.name; 

 const newFrit = { 

 user: newFritName || 'annonymouse 🐭', 

 message: newFritMessage, 

 time: new Date(), 

 };

The request/response part of the code above could be a separate function in a dedicated routes folder. 🧐💝

	server.post('/', bodyParser, (request, response) => {
	// Collects new frit message
	const newFritMessage = request.body.message;
	const newFritName = request.body.name;

	const newFrit = {
	user: newFritName \|\| 'annonymouse 🐭',
	message: newFritMessage,
	time: new Date(),
	};

fac22 / fritter Goto Github PK

fritter's People

Contributors

Forkers

fritter's Issues

Recommend Projects

Recommend Topics

Recommend Org