fac-17 / tony-andy Goto Github PK

setSeconds should be in the dependency array as it's used in the useEffect

it's overlapping!

game looks great. the buttons are cool and it's really intuitive.

github profiles have a name option (which isn't always filled in). If possible it would be better to use the name if it is there rather than just gues peoples github name

Your clock gets smaller when there's only a one digit number in it, and it's obviously bigger when there's two digits. Maybe you can stop it changing in size by adding a div for the number and keeping a separate div for the circle?

sometimes when i have four options to click two of them are the right option.

The code needs to check that the potential other options being presented are not the same name as the correct option

We used a function to do the same thing which is only a couple of lines .... you could re-factor to use the following:

function shuffle(array) { array.sort(() => Math.random() - 0.5); }

It's looking and working really well for a project built by a pair in a completely new language! Well done. I can play the game, feel the time pressure, see my score and see a final page when the game is over. Great work!! I'll now finish code reviewing... would you like that?

Nice that you worked out how to set the timer and it looks great!

It would be nice to know what the purpose of the game is and how I play it? A lil readme and maybe a line of text above the game would be cool. Otherwise slightly weird to see members of my cohort cropping up...

I can't tell you what triggered it but at some point while I was playing there was suddenly 4 answers instead of 3.

When I first played the game I found that halfway through it switched to 'Loading...'. I haven't been able to replicate it so I'm not sure I can offer a solution, but it might be good for you to know there's a bug there somewhere (not helpful I know sorry 🤷🏼‍♀️)

You've organised your code really nicely with your pure functions in the utils - will take a leaf out of your book!

Small thing but might be nice to have a re-start or back button when the game is finished instead of "refresh to play again"

it might be okay if you only use it once and you just want it shuffled but it's better practice to use pure functions.

Also for us, we shuffled a few different arrays and making the shuffle return a new array solved a lot of bugs

you've written 100% more tests than we have... but it's still not enough!

if you have time, it might be nice to test that when a user presses on a correct button, it takes them to the next page. and that when they press on the wrong one, it doesn't. and that after 30 seconds, the game automatically ends.