kash_todo's People
kash_todo's Issues
Congrats on testing and trying out Jest!
๐ฅ
Good coverage, too
I think we're gonna share some issues.... Max-limit on input field
As the title says, pretty much all the issues that our group are going to flag up for you guys will be the same for us!....
Functionality is great, and thanks for your pointers at the end of yesterday guys
Maybe put a max-limit for characters on your input field, and then run a test that expects an error message or similar when the user exceeds the limit. I copy and pasted a whole wikipedia page into your todo, for example
Woo! All your tests pass! And your site works!
โญ good job ๐
Empty inputs appear!
Good job guys!
I tried to just hit enter and a list of empty entries appeared, which I think is a misbehaviour ๐
Good: input text clears
Try to aim for more even commits
Low accessiblity rating
Your toDo app is tabbable throughout - amazing! Especially appreciated because my trackpad is crap.
However, running Audits revealed a fairly low accessibility rate - maybe sizing the font up and labels would make it more accessible for visually impaired/deaf users?
well done for responsiveness ๐
Are you lot feeling ok?
Styling & Semantic HTML
I get that you likely didn't have enough time to get to the styling done (which is absolutely fine - I think it's more important to get the testing and logic down!), but you may want to add some very minimal styling in the time you have to respond to issues this morning.
Some nice quick wins for CSS/HTML:
- Background colour
- Increased font size
- Increased button size/height in the
UL
- Make it clear what the buttons are for (marking a todo as "done")
- An
h1
- A more personalised page title
- Perhaps wrap the whole todo area in a
<section>
Nice testing
Well done for testing todoFunctions.cloneArrayOfObjects().... something we took for granted!
Long words overflow from their container
Remove console.logs
Code is great.. but don't think the final version should have console.logs :)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.