fac-15 / kash_todo Goto Github PK

🥇

Good coverage, too

As the title says, pretty much all the issues that our group are going to flag up for you guys will be the same for us!....

Functionality is great, and thanks for your pointers at the end of yesterday guys

Maybe put a max-limit for characters on your input field, and then run a test that expects an error message or similar when the user exceeds the limit. I copy and pasted a whole wikipedia page into your todo, for example

⭐ good job 👍

Good job guys!
I tried to just hit enter and a list of empty entries appeared, which I think is a misbehaviour 😄

Quite a large disparity in commit numbers between individuals. Try to make sure you switch up who's typing, switch pairs, etc. relatively often!

Your toDo app is tabbable throughout - amazing! Especially appreciated because my trackpad is crap.

However, running Audits revealed a fairly low accessibility rate - maybe sizing the font up and labels would make it more accessible for visually impaired/deaf users?

well done for responsiveness 👍

https://github.com/fac-15/KASH_todo/blob/master/KASH-README.md
😿

I get that you likely didn't have enough time to get to the styling done (which is absolutely fine - I think it's more important to get the testing and logic down!), but you may want to add some very minimal styling in the time you have to respond to issues this morning.

Some nice quick wins for CSS/HTML:

• Background colour
• Increased font size
• Increased button size/height in the UL
• Make it clear what the buttons are for (marking a todo as "done")
• An h1
• A more personalised page title
• Perhaps wrap the whole todo area in a <section>

Well done for testing todoFunctions.cloneArrayOfObjects().... something we took for granted!

Hi guys, here we go! Long todos will exceeeeeeeeed the container box! ❗

Code is great.. but don't think the final version should have console.logs :)