Giter Club home page Giter Club logo

ccsm's Introduction

CCSM

Charlie, Cynthia, Susan, Mike's portfolio website https://fac-15.github.io/CCSM/

Welcome to Team CCSM's Onepage Portfolio

(Cynthia Charlie Susan Michele)

Aim:

Our aim for the project was to make a portfolio to showcase all our talents in using github, HTML, CSS, JavaScript and Team work!

Layout & Sitemap

  • Home screen
  • Intro to the team
  • Team Profiles
  • Contact Us

Colour Scheme

CCSM

Lessons Learnt:

  • Whilst pair programming you can be in the drivers seat, and still pick up on a lot and learn new skills.
  • Pair programming can also be challenging, trying to make sure everyone has a fair chance to implement their vision.
  • GIT! We made a staging and master branches, as well as feature branches to try and avoid merge conflicts.
  • Time is precious!
  • Screens can be small... Always Mobile First .
  • Learn Grid

DON'T BE SO HARD ON YOURSELF!

Issues:

  • Mobile Optimization could have been addressed from the beginning instead of retrospectively.
  • Accessibility could have been highlighted throughout the project.
  • Avoiding Patch-work code - try to find and fix the problem instead of coding a hotfix.

Stretch goals:

  • Specific error messages for form inputs.
  • Mobile Optimization.
  • Add links to personal social media (github profiles).
  • Make profile modal when user clicks on 'View Profile'.

Remember... Theres ALWAYS more to Learn!

learning

ccsm's People

Contributors

charlielafosse avatar boi87 avatar susanx avatar onwordi avatar

Watchers

D Sofer avatar James Cloos avatar  avatar  avatar

ccsm's Issues

Mobile

  • Lots of white space on right of screen
  • Menu squashed for seemingly no reason, you guys should be able to sort this with some tweaking
  • otherwise looks good
  • see screen shots...

CSS regarding to the navbar

I like how your team design the navbar using little animation as well.
It would be nice the cursor changes when hamburger hovers. Same as the close button.
Also, media query used twice, would be nice to double check - line 349 362 in CSS file. ๐Ÿ‘

Form Validation

Hi guys, don't mean to be scathing, but here is a rundown. I like the way you provided a success message, something I didn't get around to!:

  • It would be a nicer experience to provide error messages underneath the fields, rather than as alerts.
  • A more stringent check for user names and message would be good. Currently, you only check for one character. You could filter out digits [0-9] for names, for example. You could also set a minimum length or maximum length as a property on the html elements e.g. min-length="10" on the name field. As an example, you can enter 476v2u6db as your name in to the form.
  • The checking for each field should be independent. For example, no text entered in 'name' or 'message' only gets flagged up if the email address passes the test. Check your if(){} else if(){} else{} statements on the form.
  • It would be nice to have validation before the user submits the form. To do this, you could try using an input event listener on the form fields. This detects when the fields receive input.
  • A small aside: try using constrather than letas your first port of call when defining variables. Think about whether the variable needs to get changed or not. A good candidate for a constvariable is probably an html element in this context.

README!

  • You guys can do a better read me, you're awesome! ๐Ÿฅ‡

Suggestion: even commits

Don't worry too much about this - just a suggestion!

Since the projects are about getting everyone to work an even amount on the code and understand everything, it's good to try and get everyone to contributing the same amount to the codebase. This can be a difficult thing to measure, but Github tries in showing the amount of commits people contribute to a project. It's definitely not a perfect measure, but can be a good guideline to keep your eye on.

What can make it more difficult is that people often have different 'commit' styles. Some people work on very large chunks of code and then make a commit; some people will change one or two lines of code and then make a commit, resulting in a long string of commits. So of course this can cause a disparity in the metrics on Github.

It's good to discuss this as a group before starting, what your 'commit' style might be, since it will bring more consistency to how you work as a team, and that's always a good thing!

Just something to keep in mind for future projects ๐Ÿ˜Š

Nav bar isn't tabbable

I probably really butchered 'tabbable' but it's a word now so...

If you load the site and try to click 'tab' to navigate through with your keyboard, to simulate what a user without a mouse might do, then the first link it jumps to is 'scroll to see more' in the second section.

I think it might make more sense to have it tab to the navigation bar - see if you can make that happen using tab index to have the nav appear when the user hits 'tab'.

https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex

Form validation

It's great that you've implemented that to prevent bad inputs and empty inputs. I also like that it lets you know that the message has been sent - a good example of Neilsen's 'visibility of system status' heuristic ๐Ÿ˜‰

I like that you've used regex but one thing to keep in mind is that some users may have Javascript turned off. You can also use HTML5 validation on your form in place of or in addition to your JS validation!

https://developer.mozilla.org/en-US/docs/Learn/HTML/Forms/Form_validation

javascript

  • Burger menu not working at all without javascript
  • submit button doesn't work at all without javascript

CSS IDs vs classes

<a class='navbar' id='hamburger'>

IDs should be individual for each element in the code and not reused, so that you can specifically target an element using the ID.

Classes are for things that are used over and over - for example, your 'name-fancy' class, where you apply the same style to each person's name.

Try and refactor your CSS a bit to reflect this! ๐Ÿ˜Š

Accessibility

  • Tab through works well, maybe think about adding access to the burger menu?
  • When tabbing through it reads out your profile link buttons but doesn't tell us who's profile.
  • "Scroll to see more" click takes you to top of page rather than further down as it suggests.
  • Vox works well generally but only reads text when clicked on apart from buttons & form.
  • Vox reading of form.... EXCELLENT! ๐Ÿ‘
  • Burger menu difficult to see for some colourblindness. Not found in naturally expected position (top right or left corner)
  • No ARIA landmarking roles (banner, main, contentinfo) or labeledby for more specific content
  • You could try to use less
    's and instead use
    or for content.

Love the splash page!

"We will solve your problems and you will pay us" ๐Ÿ˜‚

Great colo(u)rs as well - feels like a professional design!

Improvement: color contrast in profile section

The Lighthouse audit suggests that you can improve the color contrast of some of the sections - I think the one where it lists your profiles can be low contrast for some users with sight difficulties. Have a look with the Colorblinding extension in Chrome.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.