faburaya / 3fd Goto Github PK

This file cannot be read by the VideoTranscoder example.

https://www.dropbox.com/s/yl4x0078unev9ls/LetMeThinkAboutIt.avi?dl=0

Hello.

I believe you should free the garbage collector into its own project.

This can help get support from other developers who wish to work on the garbage collector, but have no context or relation towards all the other stuff in this project.

Currently the GC is just some mixed header files mixed in with a project for supporting stuff like Service broker of Microsoft SQL Server.

I think you did a good job on the GC, and there's few good modern C++ GC's out there, so it deserves attention. But it cannot get the proper attention if it's mixed in here as some obscure component for supporting odd Platform-specific stuff.

This GC should have its own Issues section, and its own front-page documentation that appears on its own primary github page.

And it should have its own name.

In 3fd/code/exceptions.cpp, std::wstring_convert is used, but that function is deprecated in c++17.

When building 3fd with MSVC2017.
Compiling fails with the following error:

C:\projects\3fd\core\exceptions.cpp(84): error C2664: 'std::basic_string<char,std::char_traits<char>,std::allocator<char>> std::wstring_convert<std::codecvt_utf8<wchar_t,1114111,0>,wchar_t,std::allocator<wchar_t>,std::allocator<char>>::to_bytes(const _Elem *,const _Elem *)': cannot convert argument 1 from 'const TCHAR *' to '_Elem' [C:\projects\3fd\build_subfolder\core\3fd-core.vcxproj]
C:\projects\3fd\core\exceptions.cpp(84): note: There is no context in which this conversion is possible
C:\projects\3fd\core\exceptions.cpp(86): error C3536: 'text': cannot be used before it is initialized [C:\projects\3fd\build_subfolder\3fd\core\3fd-core.vcxproj]
C:\projects\3fd\core\exceptions.cpp(89): error C2440: 'return': cannot convert from 'int' to 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>' [C:\projects\3fd\build_subfolder\core\3fd-core.vcxproj]