fabon-f / fetch-site-metadata Goto Github PK

Bug

When using this library to fetch metadata on https://nextjs.org/docs/app/building-your-application/routing/router-handlers, which normally is redirected to https://nextjs.org/docs/app/building-your-application/routing/route-handlers, an error occurs and process fails. This doesn't happen with v0.1.3 or below.

Environment

Linux / Node.js v21.4.0 / fetch-site-metadata v0.2.0

Minimal reproduction code:

import fetchSiteMetadata from "fetch-site-metadata";

const url =
  "https://nextjs.org/docs/app/building-your-application/routing/router-handlers";
const result = await fetchSiteMetadata(url);

console.log(result);

Output

node:internal/webstreams/readablestream:1078
      throw new ERR_INVALID_STATE.TypeError('Controller is already closed');
            ^

TypeError [ERR_INVALID_STATE]: Invalid state: Controller is already closed
    at ReadableStreamDefaultController.enqueue (node:internal/webstreams/readablestream:1078:13)
    at fetchParams.controller.resume (node:internal/deps/undici/undici:10994:45)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  code: 'ERR_INVALID_STATE'
}

Node.js v21.4.0

when fresh installing and using the package it is missing dependency utils or smth

consider NextJS fetch

const site_data = await fetchSiteMetadata(
  url,
  { next: { revalidate: 30} }
);

we need to pass caching parameter

could you adjust so that in

const response = await fetch(urlString, {
  signal: controller.signal
  ...options
})

we spread options, and in any sub-fetches also