fabiokleis / emacs-kanagawa-theme Goto Github PK

Hello,

(defvar kanagawa-theme-true-color-p
  "When non-nil use true color values in color palette."
  (or (display-graphic-p) (= (tty-display-color-cells) 16777216)))

The docstring and initial-value are inverted. Causing issue to marginalia and describe-variable.

For exemple:

(describe-variable 'kanagawa-theme-true-color-p)

Cause this issue:

Debugger entered--Lisp error: (wrong-type-argument char-or-string-p t)
  #f(compiled-function () #<bytecode 0x180a283d02390272>)()
  help--window-setup("*Help*" #f(compiled-function () #<bytecode 0x180a283d02390272>))
  describe-variable(kanagawa-theme-true-color-p)
  eval((describe-variable 'kanagawa-theme-true-color-p) nil)

Hello!

Thank you for porting Kanagawa to Emacs, I missed it from Neovim :)

I am having trouble overriding the default sumi-ink-1b color. I might be doing something wrong, could you please help me?

This is my setup (I'm using elpaca, it allows specifying recipe within :ensure):

(use-package kanagawa-theme
  :ensure (:host github :repo "Fabiokleis/emacs-kanagawa-theme")
  :demand t
  :custom
  (kanagawa-theme-comment-italic)
  (kanagawa-theme-custom-colors '((sumi-ink-1b . "#0A0E14")))
  :config
  (load-theme 'kanagawa t)

From what I was able to understand by reading the source code, the kanagawa-theme-custom-colors accepts an alist, and I believe that I have the syntax correct since Emacs isn't complaining.

Thank you

When loading kangawa-theme, the terminal color palette is used despite being loaded in a graphical environment. This is due to the eval-when-compile form here:

Newer package managers compile packages in a separate Emacs subprocess, which is not graphical.

Is there a reason the palette needs to be determined at compilation time, or can this be changed to be set at runtime?