fabiocarballo / android-resources-checker Goto Github PK

Hi, I'm trying to run this script on my project (muli-module setup) and I am having this problem:

Processing:
[14:52:52] rappi - packaged resources processed!                       app.py:31
ERROR:root:Could not complete analysis.
Traceback (most recent call last):
  File "/Users/usuario/.pyenv/versions/3.9.7/lib/python3.9/site-packages/android_resources_checker/entrypoint.py", line 81, in launch
    application.execute(app, client, check, delete)
  File "/Users/usuario/.pyenv/versions/3.9.7/lib/python3.9/site-packages/android_resources_checker/app.py", line 33, in execute
    usage_references = self.resources_fetcher.fetch_used_resources(app_path)
  File "/Users/usuario/.pyenv/versions/3.9.7/lib/python3.9/site-packages/android_resources_checker/resources.py", line 73, in fetch_used_resources
    styles_references = self._style_usages_in_xml(filepath)
  File "/Users/usuario/.pyenv/versions/3.9.7/lib/python3.9/site-packages/android_resources_checker/resources.py", line 113, in _style_usages_in_xml
    for line in self.files_handler.file_content(filepath):
  File "/Users/usuario/.pyenv/versions/3.9.7/lib/python3.9/site-packages/android_resources_checker/files.py", line 33, in file_content
    return open(filepath).readlines()
  File "/Users/usuario/.pyenv/versions/3.9.7/lib/python3.9/codecs.py", line 322, in decode
    (result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe1 in position 1: invalid continuation byte

Python version: 3.9.7
OS: macOS Monterrey 12.0.1

First of all, congrats for the good job on this tool. Looks quite great!

It's quite hard to say that, but it seems that your project is not compliant with MIT license at all.

The reason for that is simple : your project takes A LOT of inspiration from the open-source work I've been doing at @dotanuki-labs. Particularly it is easy to realise that when comparing this project with bitrise-reports

I can list a few of them:

• Same project structure driven by Poetry + Makefile (including some targets using the same names)
• Same Github Actions Workflows (main.yml and publish.yml), incluing Job's names, Python versions, pipeline steps
• Very similar file structure (entrypoint.py, reporting.py, app.py, etc)
• Very similar file contents, as per entrypoint.py (from bitrise-reports) and entrypoint.py (from this project)

Hell, even some lines of README look the same ... and this init kinda makes crystal clear that inspiration maybe went too far ...

Open-source is meant to be collaborative and inspirational, yes. For sure I have no issues with people forking, modifying and/or re-distributing my code. Most likely that proves I'm in a good track at all.

However, licensing is important. Attribution is important. This article does a terrific job elaborating on that

I love inspiring other people to do awesome stuff based on some of my concepts and thoughts and 
I’m happy when I could help you with my code. So everybody is free to use my code, but now the 
important part, under the given license terms. You could also say “credit where credits needed”. 

Open source in the context of software does not mean you can copy the nice stuff and paste 
it into your project and tell everybody you did a nice job.

I can't recommend enough also checking these two extra resources to understand how MIT license works :

• Choose a license on MIT
• Wikipedia on MIT

It's also worth to highlight that deploys on Pypi ship the source code exactly as it was written, which means that you've shipped snippets and/or entire pieces of code written by me without proper attribution while re-distributing.

All of that being said : I'd like to ask you to change your LICENSE.md and README.md files with the following notice

Copyright (c) 2021 Dotanuki Labs, Fabio Carballo

[rest of the license terms]

so your project becomes compliant with MIT and plays well with open-source. I won't bother about previous releases wrongly copyrighted if you gently commit with this suggestion and deploy a new version of this project, so users can get the proper copyrighted code when installing / updating this tool.

I'm assuming here this issue eventually comes from some lacking of experience with open-source from your end, and* that is totally fine. Knowing you from our days working together at N26 I'm 100% sure you don't need such copy+pasta over other Engineer's work.

Thanks in advance