fabbe50 / fogoverrides Goto Github PK

The implementation is gonna be per effect blending based.

• Add official settings page similar to Biome Overrides
• Default Entries

• Blindness
• Darkness

• [ ]

Set a fog override for an entire dimension that is in turn overriden by biome specific overrides.

• Update configuration screen to allow for this
• Default Values

• Overworld (includes void fog)
• Nether
• The End

Rubidium breaks the fog render when the near and far value is the same. This breaks the off state for the render.

• Control cloud height.
• Control cloud color.

Not sure if you ever played with Dynamic Surroundings, but it used to have a feature that gave a percentage chance of "morning fog." It was really lovely.

Also, I did see you were looking into custom fog for custom dimensions, which would also be awesome. Are you planning on doing custom fog for the End, too?

Thanks! This mod is awesome!

Custom fog based on Y-level.

Suggested by The13th_Empire on CurseForge

Some smooth transitions between the void fog and the overworld fog so it doesn't just "pop" between them.

Suggested by jukittita on CurseForge

When used on the client side, the server requires it to be installed on itself. That's why I can't get rid of the red cross next to the server, although I can play on the server.

[12Jan2024 00:28:12.784] [Netty Client IO #1/DEBUG] [net.minecraftforge.client.ForgeHooksClient/CLIENTHOOKS]: Received FML ping data from server at sergo467.ddns.net: FMLNETVER=3, mod list is compatible : false, channel list is compatible: true, extra server mods: {}
[12Jan2024 00:28:12.784] [Netty Client IO #1/INFO] [net.minecraftforge.client.ForgeHooksClient/CLIENTHOOKS]: Client has mods that are missing on server: [fogoverrides]

This is gonna be a per liquid based color blend.

• Update configuration to be similar to Biome Overrides
• Default Values

• Water
• Lava

• Easy system to add mod liquids to this screen
• [ ]

Add the ability to control where blindness and darkness fog starts.

• Blindness
• Darkness

Suggested by The13th_Empire on CurseForge

The game will crash upon enabling the fog color override due to an UnsupportedOperationException from attempting to cancel a non-cancelable event (ViewportEvent.ComputeFogColor)

java.lang.UnsupportedOperationException: Attempted to call Event#setCanceled() on a non-cancelable event of type: net.minecraftforge.client.event.ViewportEvent.ComputeFogColor
at net.minecraftforge.eventbus.api.Event.setCanceled(Event.java:92) ~[eventbus-6.0.5.jar%2387!/:?] {}
at com.fabbe50.fogoverrides.handlers.FogHandler.colorAdjust(FogHandler.java:229) ~[fogoverrides-1.20.1-1.3.jar%23159!/:1.20.1-1.3] {re:classloading}
at com.fabbe50.fogoverrides.handlers.FogHandler_colorAdjust_ComputeFogColor.invoke(.dynamic) ~[fogoverrides-1.20.1-1.3.jar%23159!/:1.20.1-1.3] {re:classloading,pl:eventbus:B}
at net.minecraftforge.eventbus.ASMEventHandler.invoke(ASMEventHandler.java:73) ~[eventbus-6.0.5.jar%2387!/:?] {}
at net.minecraftforge.eventbus.EventBus.post(EventBus.java:315) ~[eventbus-6.0.5.jar%2387!/:?] {}
at net.minecraftforge.eventbus.EventBus.post(EventBus.java:296) ~[eventbus-6.0.5.jar%2387!/:?] {}
at net.minecraftforge.client.ForgeHooksClient.getFogColor(ForgeHooksClient.java:440) ~[forge-1.20.1-47.2.0-universal.jar%23165!/:?] {re:classloading}
at net.minecraft.client.renderer.FogRenderer.m_109018(FogRenderer.java:193) ~[client-1.20.1-20230612.114412-srg.jar%23160!/:?] {re:classloading,pl:runtimedistcleaner:A}
at net.minecraft.client.renderer.LevelRenderer.m_109599(LevelRenderer.java:1147) ~[client-1.20.1-20230612.114412-srg.jar%23160!/:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
at net.minecraft.client.renderer.GameRenderer.m_109089_(GameRenderer.java:1126) ~[client-1.20.1-20230612.114412-srg.jar%23160!/:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
at net.minecraft.client.renderer.GameRenderer.m_109093_(GameRenderer.java:909) ~[client-1.20.1-20230612.114412-srg.jar%23160!/:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
at net.minecraft.client.Minecraft.m_91383_(Minecraft.java:1146) ~[client-1.20.1-20230612.114412-srg.jar%23160!/:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
at net.minecraft.client.Minecraft.m_91374_(Minecraft.java:718) ~[client-1.20.1-20230612.114412-srg.jar%23160!/:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
at net.minecraft.client.main.Main.main(Main.java:218) ~[1.20.1-forge-47.2.0.jar:?] {re:classloading,pl:runtimedistcleaner:A}
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?] {}
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?] {}
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] {}
at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?] {}
at net.minecraftforge.fml.loading.targets.CommonLaunchHandler.runTarget(CommonLaunchHandler.java:111) ~[fmlloader-1.20.1-47.2.0.jar:?] {}
at net.minecraftforge.fml.loading.targets.CommonLaunchHandler.clientService(CommonLaunchHandler.java:99) ~[fmlloader-1.20.1-47.2.0.jar:?] {}
at net.minecraftforge.fml.loading.targets.CommonClientLaunchHandler.lambda$makeService$0(CommonClientLaunchHandler.java:25) ~[fmlloader-1.20.1-47.2.0.jar:?] {}
at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:30) ~[modlauncher-10.0.9.jar:?] {}
at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) ~[modlauncher-10.0.9.jar:?] {}
at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) ~[modlauncher-10.0.9.jar:?] {}
at cpw.mods.modlauncher.Launcher.run(Launcher.java:108) ~[modlauncher-10.0.9.jar:?] {}
at cpw.mods.modlauncher.Launcher.main(Launcher.java:78) ~[modlauncher-10.0.9.jar:?] {}
at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) ~[modlauncher-10.0.9.jar:?] {}
at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) ~[modlauncher-10.0.9.jar:?] {}
at cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:141) ~[bootstraplauncher-1.1.2.jar:?] {}

• Custom Fog for weather events.

• Sun/Default
• Light rain/Drizzle
• Rain
• Storm

• Integration with mod weather
• Some kind of API for mod devs to add their weather events to Fog Overrides