Giter Club home page Giter Club logo

Comments (9)

EZForever avatar EZForever commented on September 24, 2024 1

OK I've managed to reproduce the bug, but in a different procedure:

  1. Open ThatOrThis menu;
  2. Select an option by pressing TAB on keyboard, the tooltip will appear around mouse cursor;
  3. Move cursor away or to another option, erratic behavior begins.

My guess is that, by using a touchpad (or maybe some touchpads, as mine works fine) some kind of implied keyboard focus is applied onto the option button. Then the cause of problems surfaced: Minecraft treats keyboard focus the same as mouse hovering (net.minecraft.client.gui.widget.ClickableWidget#isHovered), so there can be at most two buttons in a "hovered" state, causing chaos. I'm working on a fix.

from thatorthis.

EZForever avatar EZForever commented on September 24, 2024 1

Okay, maybe by checking mouse poisition against list entries instead of desynchronized button coordinates, we can "force" the tooltip to show only when wanted. Try this snapshot: [email protected] (unzip before installing).

from thatorthis.

EZForever avatar EZForever commented on September 24, 2024 1

v0.2.5+1.17 is out, containing the fix. Closing this issue.

from thatorthis.

EZForever avatar EZForever commented on September 24, 2024

This bug is funny indeed, however I can't reproduce it with your rules.json, whether with a touchpad or a mouse.

From your video it seems that, if a tooltip is displaying, and the button providing it just scroll out of view, the tooltip will refuse to disappear. Is this understanding correct?

Also, please try to reproduce the bug without any mods other than those ThatOrThis depends on.

from thatorthis.

Felix14-v2 avatar Felix14-v2 commented on September 24, 2024

Absolutely right.

button providing it just scroll out of view, the tooltip will refuse to disappear

I disabled all mods (deleted the files and disabled them), but the situation remained the same:
https://youtu.be/TZeGjirvktM
https://youtu.be/ZVQhFWa7j7c

from thatorthis.

EZForever avatar EZForever commented on September 24, 2024

Try this snapshot: [email protected] (unzip before installing). Tooltips for keyboard focused buttons are now not shown. Mouse hovering works as normal.

from thatorthis.

Felix14-v2 avatar Felix14-v2 commented on September 24, 2024

The result remained the same. However, I do not think that such a small feature is worth so much attention if it is so difficult to detect. If you want, you can close this issue.

By the way, I think this is a simple solution to add small delay after hovering over the button to display the tooltip.

from thatorthis.

EZForever avatar EZForever commented on September 24, 2024

Frankly I don't know what else could go wrong with these tooltips... can't even confirm whether the problem is on my side or not. I'll keep this issue open, but further investgation can't be done without some help.

from thatorthis.

Felix14-v2 avatar Felix14-v2 commented on September 24, 2024

Now tooltip works as it should ๐Ÿ‘

from thatorthis.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.