exys228 / osu-stuff Goto Github PK

Background colors are wrong.

As the title states, no examples implementing IOsuPatchPlugin interface are present. People can't do plugins if they don't know how to. Examples should cover all aspects of all Explorers, especially MethodEditor.

IsSystemType checks if namespace is "System" osu!.exe has System-namespaced types (#10). There should be a check on assembly itself (path, name idk), not on namespace.

To be honest, I just quickly tossed up all of my code from all the libs to osu!patch project and converted it from conapp to library. A lot of projects = bad, but what also is bad, that I didn't really care about the code and osu!patch is still a conapp deep down inside (Main(args) in a lib, seriously?)

Congrats! Now I have a full-time job and I don't think I will be able to do anything for this project in near future, even if I have the will. Tbh, thanks to ADHD I didn't do anything anyways. I hope my code is not that terrible for you guys and someone will eventually fork this and make something good out of it. The best thing I could do is to add documentation and README.md. Again, in near future. I'm sorry I am such a failure.

P.S. @xxCherry, my hopes on you!
P.P.S. I may suddenly come back, who knows me

I used de4dot to deobfuscate osu! (v3097)
It shows:

Cleaning osu!v3097.exe
ERROR:
ERROR:
ERROR:
ERROR: Hmmmm... something didn't work. Try the latest version.

It is the latest version.

Thanks for the help, if any.

It shouldn't do that. OsuHooks-xxxxxxxx should be independent (except OpenTK etc.) Also, HookManager.CLI name is wrong, should be HookGenerator.CLI

Can't really make anything for my project because of exams. Don't blame me, please, I truly want to write code for it but I can't. Will try to do smth after New Year.

Using dnlib's MethodBodyReader will be better, since that's more accurate, than current osu!patch's implementation.

Honestly, I did never create any unit-test nor do I know how to make them. h e l p
i don't even know how they look like buuut ima lazy ass so f it for now

It's can be useful for delegates.

As the title says, the osu!patch.CLI Failed when trying to do "Patch on update" patch.

C:\Users\user>osu-stuff-master\osu-stuff-master\osu!patch.CLI\bin\Release\osu!patch.CLI.exe osu-stuff-master\osu-stuff-master\osu!patch\bin\Release\osu!patch\clean.exe C:\Users\user\AppData\Local\osu!\osu!.exe
[I] Loaded assemblies: osu!, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null (clean); osu!, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null (obfuscated).
[I] MD5 hash of obfuscated assembly: 8877e262e337b4128679b67f67a856d6
[I] Now loading all custom add-ons from plugins/ folder.
[I] Cleaning control flow of obfuscated assembly
[I] Fixing strings in obfuscated assembly.
[I] Found cached name dictionary file for this assembly! Loading names...
[I] Done! Now patching.
[I] "Unsigned executable" fix: DONE
[I] Bancho MD5 hash of osu!.exe fix: DONE
[I] "Patch on update" patch: FAIL
[I] Done processing all local patches! Now processing patches from loaded add-ons...
[I] Done processing all plugins.
[I] There's some details about failed patches.
Patch name: "Patch on update" patch
Execution result: Exception
Exception details:
osu_patch.Exceptions.NameProviderException: Unable to find method specified!
   at osu_patch.Explorers.TypeExplorer.FindMethod(String name, MethodSig sig)
   at osu_patch.LocalPatches.<>c.<.cctor>b__1_2(Patch patch, ModuleExplorer exp)
   at osu_patch.Patch.Execute(ModuleExplorer exp)

[I] There are some failed patches. Do you want to continue?
[W] In case of self-update pressing 'N' will leave stock version of osu! without patching it!
    Continue? (y/n)
[E] [I] Aborted by user.

Maybe make local server patch, so you can play with your friends easily. Not sure about it, though.

Most likely outdated

Instead of disabling patches in code, better way is will adding configuration file for patches.

Add already baked clean.exe for the sake of simplicity

Would you be able to walk me through getting supporter using anything? And before you say something like "go to the osu websaite and click buy supporter" i dont have a job and would love to support the game if i was old enough to support myself.

Maybe useful for some people

That's really bad and I don't really like it. Do something about it, maybe?..

Absurdly bad documentation, and absolutely no documentation for explorers.