Giter Club home page Giter Club logo

expo-react-native-adapter's Introduction

expo-react-native-adapter's People

Contributors

aasfga avatar bbarthec avatar esamelson avatar expbot avatar ide avatar m4tx avatar sjchmiela avatar szymon20000 avatar terribleben avatar tsapeta avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Forkers

jmatsushita

expo-react-native-adapter's Issues

Short videos are not captured

Snack for reference https://snack.expo.io/@defor/cameraqualityissue

If you comment lines from #217 to #220

if (captureFinished - captureStarted < 2500) {
      console.warn('Video is too short. Nothing is captured')
      return;
    }

And then tap on capture button and release it faster then 2.5 seconds - nothing will be captured. Under preview we will see just a black screen (but there should be 2.5 seconds of video). I believe it is related to some kind of delay between call recordAsync and actual recording.
Is there any workaround on this issue?

Impossible to set “quality” for cameraRef.recordAsync method

recordAsync method have quality parameter. Likely if we can set it to minimal value resulting video must be smaller compared to default one (size is crucial, as we need to save fragments to the server, but sending about 500Mb for 1 minute of video has no sense). But when I try to set quality by either Camera.Constants.VideoQuality[‘720p’] or 2 - warning appears and record is not starting. Am I doing anything wrong?

https://imgur.com/dS7wdmH

Here is a Stack: https://snack.expo.io/@defor/cameraqualityissue

It is in working state now.
If you uncomment line #210 quality: Camera.Constants.VideoQuality['480p'] - video will not be captured at all. Since warnings are disabled in “stack” mode (as I understand environment is set to production) - warning mentioned in my original post is not shown, but it is there

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.