exosim / exosimpublic Goto Github PK

I had several minor issues when trying to run the code, which I solved as follows (seems as if they are partly linked to me running the code on Windows):

In the ExoData package:

• Specifyied the encoding when opening the xml database file before initiating the parser, i.e. I replaced "open(filename, 'r')" in line 126 of database.py with "open(filename, 'r', encoding="utf8") (this was in reaction to a UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position 215: character maps to )
• There seems to be a python3 incompatibility in database.py (line 54), as dict.iteritems() was removed in Python3. I replaced it with dict.items() (this was in reaction to an AttributeError: 'dict' object has no attribute 'iteritems')
• Another seemingly Python3 incompatibility (line 60 of database.py): in Python 3, dict.values() returns a view, not a list. Got rid of the error by adding a wraper ("list()") around returnDict.values() in line 60. (this was in reaction to a TypeError: 'dict_values' object does not support indexing)

In the exosim package itself:

• I stumbled over a seeming issue with the unit handling in instrument.py. Changed "x_wav_osr = ld(x_pix_osr.rescale(pq.um))*pq.um" to x_wav_osr = ld(x_pix_osr.rescale(pq.um)/pq.um)*pq.um" in line 126 to get rid of the error (this was in reaction to a ValueError: Unable to convert between units of "dimensionless" and "um**2")
• scipy.special.j1() also did not seem to be able to cope with units. Changed scipy.special.j1(arg) to scipy.special.j1(arg.magnitude) in line 275 of exolib.py (arg is dimensionless)