Comments (4)
excid3
commented on June 16, 2024
PRs welcome!
from tailwindcss-stimulus-components.
rockwellll
commented on June 16, 2024
@excid3 @cmer check out my PR that addresses this.!
from tailwindcss-stimulus-components.
hms
commented on June 16, 2024
@A7madXatab at the risk of exposing myself as even more of a rank amateur with JS, could the tests be failing in your PR because you're importing 'stimulus' instead of '@hotwire/stimulus'?
from tailwindcss-stimulus-components.
rockwellll
commented on June 16, 2024
@hms thanks for the heads up. I've fetched upstream and updated deps in my fork. Now the tests seem to be failing because it says
> [email protected] test /home/runner/work/tailwindcss-stimulus-components/tailwindcss-stimulus-components
> NODE_ENV=test jest
● Cannot log after tests are done. Did you forget to wait for something async in your test?
Attempted to log "Error disconnecting controller
TypeError: Cannot read property 'removeEventListener' of null
at extended.disconnect (/home/runner/work/tailwindcss-stimulus-components/tailwindcss-stimulus-components/src/dropdown.js:93:16)
and it's scary because look at the line
To my surprise it is in fact this line that is causing the errors
document.removeEventListener('keydown', this.keyboardListener);I've changed it to
document?.removeEventListener('keydown', this.keyboardListener);And now they are passing. @excid3 anything on this?. Thanks @hms
from tailwindcss-stimulus-components.
Related Issues (20)
- New release? HOT 4
- Active tabs styling is broken in version 4 HOT 2
- Modal forced to the hidden state when added to the DOM HOT 4
- Specify prefix for tailwind classes HOT 2
- Issue when using `data-tabs-update-anchor-value="true"` and linking to a specific anchor from another page HOT 1
- Dropdown improvements HOT 4
- Google Chrome Autofill Result Select Causes Modal Close HOT 3
- Multiple modals on a page -- components not properly behind background HOT 1
- Uncaught (in promise) DOMException: The user aborted a request. HOT 1
- CDN Minified version does not appear to respect `data-toggle-class` for toggle HOT 2
- Toggle feature cannot have multiple divs to have different status
- new release
- Dropdown transition are not working
- Dropdown menu opens when navigating back.
- Dropdown Triggers Actions Twice Since 4.1.0 HOT 1
- Misspelled Tailwind class name in Dropdown documentation HOT 1
- Popover doesn't support `translate-x` and `translate-y` values like mentioned in the doc HOT 3
- Slideover doesnt work: `Uncaught (in promise) Error: Missing target element "overlay" for "slideover" controller`
- Issue when the tab panel moves the page down when larger than the viewable area. HOT 3
- Modals: error messages not showing on small screens, but showing on large screens HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tailwindcss-stimulus-components.