excalidraw / excalidraw-room Goto Github PK

Expected Behavior

Running pm2 start pm2.production.json starts excalidraw-room.

Observed Behavior

excalidraw-room fails to start.

[PM2][WARN] Applications excalidraw-collab not running, starting...
[PM2][ERROR] Error: Script not found: /home/user/Desktop/excalidraw-room/dist/index.js

Steps to reproduce

1. Download and build excalidraw-room per README.md

> git clone https://github.com/excalidraw/excalidraw-room.git
> cd excalidraw-room 
> yarn 

2. Run pm2 start pm2.production.json

System Information

OS: Linux Mint 21.1 x86_64
Typescript version: 4.2.3
Yarn version: 3.6.1
NPM version: 10.1.0

https://socket.io/docs/using-multiple-nodes/

Right now, the websocket server only uses one node. As the app grows in users we will reach a point where this is no longer sustainable, so we'll need to be able to handle hosting multiple nodes and broadcasting events between them.

While messing around with a simple Real-Time app, I encountered the following issue:

Issue Summary:

When the socket receives the disconnecting event, it fails to properly notify the associated rooms about the disconnection due to the usage of the incompatible for..in loop (no iteration is performed).

Currently, within the codebase, there exists a situation where the socket.rooms object, defined as a Set<string>, is being iterated using a for..in loop. However, for..in loops aren't compatible with Sets, potentially causing unexpected behavior or errors.

Due to this problem, the server fails to emit the expected room-user-change event.

Proposed Solution:

Refactor the iteration of socket.rooms to use for..of, forEach, or any loop mechanism compatible with Set<string> to ensure proper iteration and avoid potential issues related to incompatible iteration methods.

Additional Information:

$ npm -v
9.8.1

$ node -v
v18.18.2

$ lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 22.04.3 LTS
Release:	22.04
Codename:	jammy

Links

MDN For..in
MDN For..of
Socket.io | socket.rooms
Codebase

Looks like this project is no longer used at portal.excalidraw.com, so that information is now misleading. It is no longer compatible with the current version of excalidraw/excalidraw. Please mark this project as archived, it will save some time to a lot of people.

Hi!

I tried to setup excalidraw (Docker) to use this colab server (Docker) via overlay network, but it seems as if it is totally ignoring it. I set the necessary env variables in the .env file for excalidraw, but does not seem to use them at all.

It would be nice to get a hint how to use this.

Many thanks!
Regards
Holger

Play by Play

Today at 7:12 AM (9 hours ago) #109 was merged which fixed the build which triggered a new release to be deployed and broke live collaboration.

I tried reverting it but the previous commit actually didn't build. I tried to reverting another pull request ( #112 ) but that didn't build either.

Instead of blindly reverting things, I looked at the commit that last built from heroku (August 21) and reverted the code to that commit ( #113 )

This brought the old version alive and live collaboration is now working again.

Next steps

Right now we should be good with that old version, the problem is mitigated. Some thoughts about what to do next:

• We should figure out how to restore the changes that were done since then.
• We should add a test that makes sure that the build actually works somehow.
• We should have some alarms so we are notified by automation rather than confused customer.

This might be a good start.. https://github.com/GoogleCloudPlatform/github-actions/tree/master/setup-gcloud

Hello,

I tried building this project using

docker build -t excalidraw-room .

This works for commit 3531472, but not for the latest master.

I looked at the codebase, two repo uses two different server, excalidraw talks to 3000 and this opens socket at 3002. How to make the excalidraw from 3000 to talk to 3002?

• https://status.excalidraw.com
• https://github.com/excalidraw/upptime/issues/2

Hello,

I want to setup a self hosted environnement using the 2 containers: excalidraw and excalidraw-room
There is no documentation on how to connect / link the client to the server..

I tried to set the variable REACT_APP_WS_SERVER_URL, but nothing.
Could you guys help me please?
How to make this work?

docker pull docker.io/excalidraw/excalidraw
docker pull docker.io/excalidraw/excalidraw-room

docker run -d -p 8081:80 excalidraw/excalidraw-room:latest
docker run -d -p 8080:80 -e REACT_APP_WS_SERVER_URL=http://127.0.0.1:8081 excalidraw/excalidraw:latest

Thx