ewildgoose / active_scaffold_export Goto Github PK

I'm using the latest ActiveScaffold (from GitHub) and Rails 2.3.3. I've noticed a bug in the way that export determines which rows to export after a search. Here are the steps to reproduce:

1. In an ActiveScaffold controller, perform a search and note the results are filtered.
2. Now, call on the index. The list of items shown are not filtered.
3. Export.

Expected result: Downloaded CSV file contains all rows that are shown in the list.
Actual result: Downloaded CSV file contains only the rows that match the search from step #1.

It seems that the search parameters are being stored in the session and are not cleared even though the list view is no longer being filtered. Below is a link to a small patch that I've used to resolve the issue but I'm wondering if there's a more robust way of fixing this.

http://gist.github.com/179265