ewfian / faiss-node Goto Github PK

Node.js bindings for faiss

Home Page: https://www.npmjs.com/package/faiss-node

License: MIT License

JavaScript 30.46% C++ 44.92% CMake 23.81% Dockerfile 0.81%

faiss approximate-nearest-neighbor-search javascript machine-learning nodejs npm similarity-search typescript underdevelopment

faiss-node's Introduction

Hi there 👋

faiss-node's People

Contributors

Stargazers

Watchers

Forkers

spuuntries kyr0 dlxj ansible2 neebdev asilvas alexfilothodoros jinjunzh

faiss-node's Issues

CI: test install and import on each arch

Using Faiss-node in aws having problem working fine locally

Describe the bug
A clear and concise description of what the bug is.

Environment:

Operating system: [e.g. Windows x64]
Nodejs Version: [e.g. v18.15.0]
Package Version: [e.g. v0.1.0]

To Reproduce
Steps to reproduce the behavior:
1.
2.

Expected behavior
should be run succesfully and store text in form of vector store

Screenshots
"errorType": "Error",
"errorMessage": "Could not import faiss-node. Please install faiss-node as a dependency with, e.g. npm install -S faiss-node and make sure you have libomp installed in your path.\n\nError: /opt/nodejs/node18/node_modules/faiss-node/build/Release/faiss-node.node: cannot open shared object file: No such file or directory",
"trace": [
"Error: Could not import faiss-node. Please install faiss-node as a dependency with, e.g. npm install -S faiss-node and make sure you have libomp installed in your path.",
"",
"Error: /opt/nodejs/node18/node_modules/faiss-node/build/Release/faiss-node.node: cannot open shared object file: No such file or directory",
" at FaissStore.importFaiss (file:///opt/nodejs/node18/node_modules/langchain/dist/vectorstores/faiss.js:207:19)",
" at process.processTicksAndRejections (node:internal/process/task_queues:95:5)",
" at async FaissStore.addVectors (file:///opt/nodejs/node18/node_modules/langchain/dist/vectorstores/faiss.js:60:37)",
" at async FaissStore.fromDocuments (file:///opt/nodejs/node18/node_modules/langchain/dist/vectorstores/faiss.js:197:9)",
" at async Runtime.handler (file:///var/task/index.mjs:57:19)"
]
}

Docs: Add a Contributing doc for setup dev env

Docker Installation Failed

Describe the bug
When installing on Docker, following issue exists:

404 https://github.com/ewfian/faiss-node/releases/download/v0.2.0/faiss-node-v0.2.0-napi-v8-linuxmusl-x64.tar.gz

Seems like the library doesn't support linuxmusl? As I couldnt find the tar.gz file in releases

Environment:

Operating system: Docker node:18-alpine
Package Version: [e.g. v0.2.0]

To Reproduce
Steps to reproduce the behavior:

Init a project with faiss-node installed
Build a docker image on the project

Expected behavior
Works fine

Screenshots

Install failed

.pnpm/[email protected]/node_modules/faiss-node: Running install script, failed in 7s
.../node_modules/faiss-node install$ prebuild-install --runtime napi --verbose || (npm i cmake-js && npm run build)
│ prebuild-install info begin Prebuild-install version 7.1.1
│ prebuild-install info looking for local prebuild @ prebuilds\faiss-node-v0.2.2-napi-v8-win32-x64.tar.gz
│ prebuild-install info looking for cached prebuild @ C:\Users\Administrator\AppData\Roaming\npm-cache\_prebuilds\177…
│ prebuild-install http request GET https://github.com/ewfian/faiss-node/releases/download/v0.2.2/faiss-node-v0.2.2-n…
│ prebuild-install warn install unable to verify the first certificate
│ changed 70 packages in 1s
│ > [email protected] build
│ > cmake-js compile
│ info find VS using VS2022 (17.6.33815.320) found at:
│ info find VS "C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools"
│ info find VS run with --verbose for detailed information
│ info TOOL Using Visual Studio 17 2022 generator.
│ info CMD BUILD
│ info RUN [
│ info RUN   'cmake',
│ info RUN   '--build',
│ info RUN   'D:\\pnpm_repo\\global\\5\\.pnpm\\[email protected]\\node_modules\\faiss-node\\build',
│ info RUN   '--config',
│ info RUN   'Release'
│ info RUN ]
│ MSBuild version 17.6.3+07e294721 for .NET Framework
│ MSBUILD : error MSB1009: ��Ŀ�ļ������ڡ�
│ ����:ALL_BUILD.vcxproj
│ info REP Build has been failed, trying to do a full rebuild.
│ info CMD CLEAN
│ info RUN [
│ info RUN   'cmake',
│ info RUN   '-E',
│ info RUN   'remove_directory',
│ info RUN   'D:\\pnpm_repo\\global\\5\\.pnpm\\[email protected]\\node_modules\\faiss-node\\build'
│ info RUN ]
│ info CMD CONFIGURE
│ info find VS using VS2022 (17.6.33815.320) found at:
│ info find VS "C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools"
│ info find VS run with --verbose for detailed information
│ info RUN [
│ info RUN   'cmake',
│ info RUN   'D:\\pnpm_repo\\global\\5\\.pnpm\\[email protected]\\node_modules\\faiss-node',
│ info RUN   '--no-warn-unused-cli',
│ info RUN   '-G',
│ info RUN   'Visual Studio 17 2022',
│ info RUN   '-A',
│ info RUN   'x64',
│ info RUN   '-DCMAKE_JS_VERSION=7.2.1',
│ info RUN   '-DCMAKE_BUILD_TYPE=Release',
│ info RUN   '-DCMAKE_RUNTIME_OUTPUT_DIRECTORY=D:\\pnpm_repo\\global\\5\\.pnpm\\[email protected]\\node_modules\\faiss…
│ info RUN   '-DCMAKE_MSVC_RUNTIME_LIBRARY=MultiThreaded$<$<CONFIG:Debug>:Debug>',
│ info RUN   '-DCMAKE_JS_INC=C:\\Users\\Administrator\\AppData\\Roaming\\npm\\node_modules\\cmake-js\\node_modules\\n…
│ info RUN   '-DCMAKE_JS_SRC=C:/Users/Administrator/AppData/Roaming/npm/node_modules/cmake-js/lib/cpp/win_delay_load_…
│ info RUN   '-DNODE_RUNTIME=node',
│ info RUN   '-DNODE_RUNTIMEVERSION=18.16.1',
│ info RUN   '-DNODE_ARCH=x64',
│ info RUN   '-DCMAKE_JS_LIB=D:\\pnpm_repo\\global\\5\\.pnpm\\[email protected]\\node_modules\\faiss-node\\build\\node…
│ info RUN   '-DCMAKE_JS_NODELIB_DEF=D:\\pnpm_repo\\global\\5\\.pnpm\\[email protected]\\node_modules\\faiss-node\\bui…
│ info RUN   '-DCMAKE_JS_NODELIB_TARGET=D:\\pnpm_repo\\global\\5\\.pnpm\\[email protected]\\node_modules\\faiss-node\\…
│ info RUN   '-DCMAKE_SHARED_LINKER_FLAGS=/DELAYLOAD:NODE.EXE'
│ info RUN ]
│ Not searching for unused variables given on the command line.
│ -- Selecting Windows SDK version 10.0.22000.0 to target Windows 10.0.22621.
│ -- The CXX compiler identification is MSVC 19.36.32535.0
│ -- Detecting CXX compiler ABI info
│ -- Detecting CXX compiler ABI info - done
│ -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2022/BuildTools/VC/Tools/MSVC/14.…
│ -- Detecting CXX compile features
│ -- Detecting CXX compile features - done
│ CMake Error at CMakeLists.txt:51 (add_subdirectory):
│   add_subdirectory given source "deps/faiss" which is not an existing
│   directory.
│ CMake Error at CMakeLists.txt:52 (set_target_properties):
│   set_target_properties Can not find target to add properties to: faiss
│ Microsoft (R) Library Manager Version 14.36.32535.0
│ Copyright (C) Microsoft Corporation.  All rights reserved.
│   正在创建库 D:\pnpm_repo\global\5\.pnpm\[email protected]\node_modules\faiss-node\build\node.lib 和对象 D:\pnpm_rep…
│ -- Configuring incomplete, errors occurred!
│ ERR! OMG Process terminated: 1
└─ Failed in 7s at D:\pnpm_repo\global\5\.pnpm\[email protected]\node_modules\faiss-node
 ELIFECYCLE  Command failed with exit code 1.

CUDA/GPU Support?

Curious why GPU support was disabled, and if you intend to eventually create a CUDA/GPU build?

Docker Build Fails on ARM v7

Environment:

Operating System: Linux/arm/v7
Node.js Version: 18.7.1
Package Version: 0.5.0

I'm using the node:18.17.1-bullseye image to create an image for different types of computers, including armv7, amd64, and arm64. To get the necessary stuff, I'm running apt update && apt install -y cmake libopenblas-dev patchelf.

This setup works well for arm64 and amd64 computers, but it's not working right for the armv7 computer. You can see the full error message here: GitHub Action Run.

Here's the error message for the armv7 computer:

#29 70.21 npm ERR! CMake Error at CMakeLists.txt:51 (add_subdirectory):
#29 70.21 npm ERR!   add_subdirectory given source "deps/faiss" which is not an existing
#29 70.21 npm ERR!   directory.
#29 70.21 npm ERR! 
#29 70.21 npm ERR! 
#29 70.21 npm ERR! CMake Error at CMakeLists.txt:52 (set_target_properties):
#29 70.21 npm ERR!   set_target_properties Can not find target to add properties to: faiss
#29 70.21 npm ERR! 
#29 70.21 npm ERR! 
#29 70.21 npm ERR! Debian:aarch64
#29 70.21 npm ERR! Copy DEPENDANCES: /lib/aarch64-linux-gnu/libgomp.so.1
#29 70.21 npm ERR! Copy DEPENDANCES: /lib/aarch64-linux-gnu/libopenblas.so.0
#29 70.21 npm ERR! Copy DEPENDANCES: /lib/aarch64-linux-gnu/libgfortran.so.5
#29 70.21 npm ERR! ERR! OMG Process terminated: 1

I'm looking for ideas on how to make it work properly on the ARM/v7, Can you guide me where i should be looking at?

dlopen Symbol not found error on macOS 10.15.7 and Netlify

Describe the bug
Trying to run the following code...

import { FaissStore } from "langchain/vectorstores/faiss";
import { OpenAIEmbeddings } from "langchain/embeddings/openai";
const vectorStore = await FaissStore.loadFromPython('./data/saved_index/', new OpenAIEmbeddings());
const results = await vectorStore.similaritySearch(query, 5);

Fails with the following Error on macOS 10.15.7

Uncaught (in promise) TRPCClientError: Could not import faiss-node. Please install faiss-node as a dependency with, e.g. `npm install -S faiss-node` and make sure you have `libomp` installed in your path.

Error: dlopen(/Users/michael/Workspace/potteryhelper.com/node_modules/faiss-node/build/Release/faiss-node.node, 1): Symbol not found: __ZNKSt3__115basic_stringbufIcNS_11char_traitsIcEENS_9allocatorIcEEE3strEv
  Referenced from: /Users/michael/Workspace/potteryhelper.com/node_modules/faiss-node/build/Release/faiss-node.node (which was built for Mac OS X 12.6)
  Expected in: /usr/lib/libc++.1.dylib

    at TRPCClientError.from (transformResult-6fb67924.mjs?v=5f4c615b:4:20)
    at httpBatchLink.mjs?v=5f4c615b:190:56
from @ transformResult-6fb67924.mjs?v=5f4c615b:4
(anonymous) @ httpBatchLink.mjs?v=5f4c615b:190
Promise.catch (async)
callWithAsyncErrorHandling @ runtime-core.esm-bundler.js:168
invoker @ runtime-dom.esm-bundler.js:345

and this error on Netlify...

May 29, 12:37:31 AM: 36d0dca3 INFO   Could not import faiss-node. Please install faiss-node as a dependency with, e.g. `npm install -S faiss-node` and make sure you have `libomp` installed in your path.

Error: libgomp.so.1: cannot open shared object file: No such file or directory

Environment:

Operating system: macOS 10.15.7
Nodejs Version: v18.12.1
Package Version: [e.g. v0.2.0]

To Reproduce
Steps to reproduce the behavior:

npm install faiss-node and "langchain": "^0.0.84"
run the above code

Expected behavior
index is rebuilt from python files and returns data

Screenshots

Additional context
I was able to get my local environment running by

git checkout faiss-node & npm install
Upgrade my CMake
npm run build
npm link
then back in my project... npm link faiss-node... effectively swapping out the locally built module for my project and it's dependencies

So I guess it's just an issue with compiling the library for older versions of macOS?

Here are my package.json dependencies

  "dependencies": {
    "@pinia/nuxt": "^0.4.6",
    "@trpc/client": "^10.9.0",
    "@trpc/server": "^10.9.0",
    "daisyui": "^2.51.5",
    "faiss-node": "^0.2.0",
    "generate-password-ts": "^1.6.3",
    "langchain": "^0.0.84",
    "openai": "^3.2.1",
    "pickleparser": "^0.1.0",
    "pinia": "^2.0.30",
    "stripe": "^11.12.0",
    "superjson": "^1.12.2",
    "trpc-nuxt": "^0.8.0",
    "zod": "^3.20.2"
  },

and faiss-node in my package-lock.json...

    "node_modules/faiss-node": {
      "version": "0.2.0",
      "resolved": "https://registry.npmjs.org/faiss-node/-/faiss-node-0.2.0.tgz",
      "integrity": "sha512-4HNyK0WX26OTb4UbaJh810wY6gCYag53NssjMKCA9GT37bP0reGXz6YGOBjpbC/EzqJlYvsqKcDIzbJSfkTieg==",
      "hasInstallScript": true,
      "dependencies": {
        "bindings": "^1.5.0",
        "node-addon-api": "^6.0.0",
        "prebuild-install": "^7.1.1"
      },
      "engines": {
        "node": ">= 14.0.0"
      }
    },

Support for arm64

An extenstion to this #12

when I try to build docker image for arm64 the errors are shown as below:

#0 360.7 npm ERR! prebuild-install http request GET https://github.com/ewfian/faiss-node/releases/download/v0.2.1/faiss-node-v0.2.1-napi-v8-linuxmusl-arm64.tar.gz
#0 360.7 npm ERR! prebuild-install http request GET https://github.com/ewfian/faiss-node/releases/download/v0.2.1/faiss-#0 360.7 npm ERR! prebuild-install http request GET https://github.com/ewfian/faiss-node/releases/#0 360.7 npm ERR! prebuild-install http request GET https://github.com/ewfian/faiss-node/releases/download/v0.2.1/faiss-node-v0.2.1-napi-v8-linuxmusl-arm64.tar.gz
#0 360.7 npm ERR! prebuild-install http 404 https://github.com/ewfian/faiss-node/releases/download/v0.2.1/faiss-node-v0.2.1-napi-v8-linuxmusl-arm64.tar.gz
#0 360.7 npm ERR! prebuild-install warn install No prebuilt binaries found (target=8 runtime=napi arch=arm64 libc=musl platform=linux)
#0 360.7 npm ERR! sh: cmake-js: not found

Here's the command I use inside docker folder of Flowise:

docker buildx use mybuilder
docker buildx build --platform linux/amd64,linux/arm64 --no-cache -t flowiseai/flowise:latest --push .

Vscode Extension failed because it can not locate bindings file when importing faiss-node

Describe the bug
I am just trying to use the code provided in documentation inside the VSCODE extrension but I get the error below:

Code:

const { IndexFlatL2 } = require('faiss-node');

const dimension = 2;
const Faissindex = new IndexFlatL2(dimension);

console.log(Faissindex.getDimension()); // 2
console.log(Faissindex.isTrained()); // true
console.log(Faissindex.ntotal()); // 0

// inserting data into index.
Faissindex.add([1, 0]);
Faissindex.add([1, 2]);
Faissindex.add([1, 3]);
Faissindex.add([1, 1]);

console.log(Faissindex.ntotal()); // 4

const k = 4;
const results = Faissindex.search([1, 0], k);
console.log(results.labels); // [ 0, 3, 1, 2 ]
console.log(results.distances); // [ 0, 1, 4, 9 ]

Error:

Activating extension 'Extension.extension' failed: Could not locate the bindings file. Tried:
 → /home/matheus/Projects/Extension/build/faiss-node.node
 → /home/matheus/Projects/Extension/build/Debug/faiss-node.node
 → /home/matheus/Projects/Extension/build/Release/faiss-node.node
 → /home/matheus/Projects/Extension/out/Debug/faiss-node.node
 → /home/matheus/Projects/Extension/Debug/faiss-node.node
 → /home/matheus/Projects/Extension/out/Release/faiss-node.node
 → /home/matheus/Projects/Extension/Release/faiss-node.node
 → /home/matheus/Projects/Extension/build/default/faiss-node.node
 → /home/matheus/Projects/Extension/compiled/16.14.2/linux/x64/faiss-node.node
 → /home/matheus/Projects/Extension/addon-build/release/install-root/faiss-node.node
 → /home/matheus/Projects/Extension/addon-build/debug/install-root/faiss-node.node
 → /home/matheus/Projects/Extension/addon-build/default/install-root/faiss-node.node
 → /home/matheus/Projects/Extension/lib/binding/node-v106-linux-x64/faiss-node.node.

Environment:

Operating system: [e.g. Linux]
Nodejs Version: [e.g. v18.15.0]
Package Version: [e.g. v0.1.0]
Using inside VSCODE Extenson

To Reproduce
Steps to reproduce the behavior:

Put the code i suggested in the simplest possible vscode extension app (https://code.visualstudio.com/api/get-started/your-first-extension) and this error will appear when you hit F5 to test it.

Expected behavior
Faiss node should be imported

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

Replace prebuild with github cli for upload assets

https://cli.github.com/manual/gh_release_upload
https://github.com/softprops/action-gh-release/blob/master/src/github.ts
https://github.com/svenstaro/upload-release-action

Contribution for possible langchainjs integration

Hi,

great project! I'm looking for implementing the FAISS support for langchainjs. I've a bit of a background in writing node native binding modules for Node too and I believe it could be fun focusing on the following subset of features for bridging a currently existing gap and enable langchainjs to support FAISS as well.

Reading the original langchain python code and how FAISS is used there:
https://github.com/hwchase17/langchain/blob/master/langchain/vectorstores/faiss.py

... I identified the following APIs need to be supported by the binding:

faiss.IndexFlatL2(length: number): IndexFlatL2
faiss.read_index(name: string): IndexFlatL2
faiss.write_index(index: IndexFlatL2, path: string): void

// on IndexFlatL2:
index.add(embeddings: Float32Array): void
index.search(embedding: Float32Array, k: number): { scores: Float32Array, indices: Int32Array }
index.reconstruct(i: number): Float32Array
index.merge_from(targetIndex: IndexFlatL2): void

A quick read of the code shows that reconstruct and merge_from might be missing in the current implementation:
https://github.com/ewfian/faiss-node/blob/main/src/faiss.cc#L51

Is it fine for you if I "mess with the code" and PR? :)
Is there anything I should know regarding missing/broken/"I want to refactor this" things that I shouldn't touch? :)

Once I got it working, I can implement and contribute FAISS support for langchainjs here:
https://github.com/hwchase17/langchainjs/tree/main/langchain/src/vectorstores

...which I find is a pretty cool goal :)

Thanks and best,
Aron

(and sorry, I couldn't change the label to "enhancement" :))

Add the option to get the cosine similarity value (score) for each returned label in the search function

Hi,
it will be awesome if we get the value of the cosine similarity score to compare the returned values in the search function.

For example, if the search function got called with vector = x and k = 4 and returned [5, 2, 0, 3], currently we can't tell how similar vector 5 is to the query vector x compared to how similar vector 2 is to the query vector x.

Ability to encode/decode buffers when FS not available?

Happy to contribute, just wanted to know if there was a logical way to accomplish this? add is very expensive as it performs an encode, which adds up fast. Basically looking for similar efficiency to that of read/write from disk but from memory/buffers.

CI: Add import test for docker

[AWS]Any chance of an arm64 build of the Node.js layer

Hi,

Just wondering if an arm64 build could be available as well as the x86_64 one?

I'd like to keep the runtime costs down, and arm64 is cheap :)

Thanks,

David

Vector store initial

Describe the bug
with langchain

const vectorStore = new FaissStore(new OpenAIEmbeddings());
const autogpt = AutoGPT.fromLLMAndTools(...);

autogpt.run(['goals']);

           throw new Error("Vector store not initialised yet. Try calling `fromTexts`, `fromDocuments` or `fromIndex` first.");
                  ^

Error: Vector store not initialised yet. Try calling `fromTexts`, `fromDocuments` or `fromIndex` first.

Environment:

mac os arm
Nodejs Version: 20.10.0
Package Version: "faiss-node": "^0.5.1",

To Reproduce
FYI

Expected behavior
should run

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

No way to get the original vector value from the index

Could you add a method to get the original vector value from the index file by label? Sth like:

Thanks!

Unavailable non-musl ARM64 build

Describe the bug
It seems like the available ARM64 prebuilt is currently musl-based only?

prebuild-install http 404 https://github.com/ewfian/faiss-node/releases/download/v0.2.2/faiss-node-v0.2.2-napi-v8-linux-arm64.tar.gz

Environment:

Operating system: Ubuntu 20.04.6 LTS
Nodejs Version: v18.15.0
Package Version: v0.2.2

To Reproduce
Steps to reproduce the behavior:

Install the package
Watch it fail to install and attempt a rebuild

Expected behavior
It installs fine using prebuilt binaries.

Logs

$ pnpm install
Lockfile is up to date, resolution step is skipped
Packages: +2
++
node_modules/.pnpm/[email protected]/node_modules/faiss-node: Running install script, failed in 3.2s
.../node_modules/faiss-node install$ prebuild-install --runtime napi --verbose || (npm i cmake-js && npm run build)
│ prebuild-install info begin Prebuild-install version 7.1.1
│ prebuild-install info looking for local prebuild @ prebuilds/faiss-node-v0.2.2-napi-v8-linux-arm64.tar.gz
│ prebuild-install info looking for cached prebuild @ /home/ubuntu/.npm/_prebuilds/1c7143-faiss-node-v0.2.2-napi-v8-linux-arm64.tar.gz
│ prebuild-install http request GET https://github.com/ewfian/faiss-node/releases/download/v0.2.2/faiss-node-v0.2.2-napi-v8-linux-arm64.tar.gz
│ prebuild-install http 404 https://github.com/ewfian/faiss-node/releases/download/v0.2.2/faiss-node-v0.2.2-napi-v8-linux-arm64.tar.gz
│ prebuild-install warn install No prebuilt binaries found (target=8 runtime=napi arch=arm64 libc= platform=linux)
...

Possible to reduce node package size?

Describe the bug
AWS Lambda functions are restricted to 250Mb including layers. Packaging the aws-sdk, faiss-node, fs, langchain, openai and adm-zip blows the limit.

I've pulled out only the aws sub-packages I need (s3 and secrets-manager) and the fs and adm-zip packages are tiny, but faiss-node is pretty big. I see it has Readme files and stuff, so I guess it's not 'minimal' - any chance of a slimmed down npm package?

Environment:

Operating system: AWS Lambda
Nodejs Version: v18.x
Package Version: latest

To Reproduce
Steps to reproduce the behavior:

Zip the nodejs/node_modules hierarchy
Attempt to create a Lambda layer
Error is "Layer max. size is 250Mb" (paraphrased)

Expected behavior
The layer is correctly created.

Error: faiss-node package.json is not node-pre-gyp ready

Describe the bug
I cannot install faiss-node using node-pre-gyp.

I am receiving the following error:

stdout: '',
  stderr: 'node-pre-gyp ERR! UNCAUGHT EXCEPTION \n' +
    'node-pre-gyp ERR! stack Error: faiss-node package.json is not node-pre-gyp ready:\n' +
    'node-pre-gyp ERR! stack package.json must declare these properties: \n' +
    'node-pre-gyp ERR! stack binary.module_name\n' +
    'node-pre-gyp ERR! stack binary.module_path\n' +
    'node-pre-gyp ERR! stack binary.host\n' +
    'node-pre-gyp ERR! stack     at validate_config (/tmp/genezio-25053/3577lj/node_modules/@mapbox/node-pre-gyp/lib/util/versioning.js:220:11)\n' +
    'node-pre-gyp ERR! stack     at module.exports.evaluate (/tmp/genezio-25053/3577lj/node_modules/@mapbox/node-pre-gyp/lib/util/versioning.js:279:3)\n' +
    'node-pre-gyp ERR! stack     at clean (/tmp/genezio-25053/3577lj/node_modules/@mapbox/node-pre-gyp/lib/clean.js:16:27)\n' +
    'node-pre-gyp ERR! stack     at self.commands.<computed> [as clean] (/tmp/genezio-25053/3577lj/node_modules/@mapbox/node-pre-gyp/lib/node-pre-gyp.js:86:37)\n' +
    'node-pre-gyp ERR! stack     at run (/tmp/genezio-25053/3577lj/node_modules/@mapbox/node-pre-gyp/lib/main.js:81:30)\n' +
    'node-pre-gyp ERR! stack     at Object.<anonymous> (/tmp/genezio-25053/3577lj/node_modules/@mapbox/node-pre-gyp/lib/main.js:125:1)\n' +
    'node-pre-gyp ERR! stack     at Module._compile (node:internal/modules/cjs/loader:1256:14)\n' +
    'node-pre-gyp ERR! stack     at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)\n' +
    'node-pre-gyp ERR! stack     at Module.load (node:internal/modules/cjs/loader:1119:32)\n' +
    'node-pre-gyp ERR! stack     at Module._load (node:internal/modules/cjs/loader:960:12)\n' +
    'node-pre-gyp ERR! System Linux 5.15.0-82-generic\n'

Environment:

Operating system: [Ubuntu x64]
Nodejs Version: [v18.17.1]
Package Version: [0.3.0]

To Reproduce
Steps to reproduce the behavior:

Install faiss-node and go to node_modules/faiss-node.
Run the following command in node_modules/faiss-node

npx node-pre-gyp --update-binary --fallback-to-build --target_arch=arm64 --target_platform=linux --target_libc=glibc clean install faiss--node

You should receive the same error as I did.

Expected behavior

The following command should be successful:

npx node-pre-gyp --update-binary --fallback-to-build --target_arch=arm64 --target_platform=linux --target_libc=glibc clean install faiss--node

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

** Possible Solution**

In the package.json the binary section is not complete, hence node-pre-gyp doesn't know how to fetch the binary.

I tested, and this snippet of code does the trick (although it's incomplete because I hardcoded the napi-version to v8):

"binary": {
    "module_name": "faiss-node",
    "module_path": "./build/Release/faiss-node.node",
    "package_name": "faiss-node-v{version}-napi-v8-{platform}-{arch}.tar.gz",
    "host": "https://github.com/",
    "remote_path": "ewfian/faiss-node/releases/download/v{version}"
  },

Can you maybe fix this or can I propose a PR?

Operating system: Windows 10
Nodejs Version: v18.15.0
Package Version: 0.5.1

To Reproduce
Steps to reproduce the behavior:

Close internet connection
Observe behavior

Expected behavior
Should work with internet connection

ewfian / faiss-node Goto Github PK

faiss-node's Introduction

Hi there 👋

faiss-node's People

Contributors

Stargazers

Watchers

Forkers

faiss-node's Issues

Recommend Projects

Recommend Topics

Recommend Org