ewenquim / renpy-graphviz Goto Github PK

Assuming the browser version is still client based. It would be nice if it could work without the API key, like normal git when only reading. Just passing in the public git HTTPS link. That way stuff like gitlab, bitbucket etc. could work too, without needing an API key per platform!

The tool crashes if the .rpy file has a UTF-8 BOM marker (EF BB BF) at the start. Test file attached:
test_bom.rpy.txt

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0x509c16]

goroutine 1 [running]:
pkg.amethysts.studio/renpy-graphviz/parser.(*RenpyGraph).AddEdge(0xc0000cdd80, 0x0, 0x0, 0xc0000cdde0, 0x3, 0x3)
/source/parser/graph.go:115 +0x136
pkg.amethysts.studio/renpy-graphviz/parser.Graph(0xc0000d6100, 0x3, 0x4, 0x1, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
/source/parser/parser.go:48 +0x50f
main.main()
/source/main.go:17 +0xa5

label a:
	return
	jump b

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0x50a616]

goroutine 1 [running]:
pkg.amethysts.studio/renpy-graphviz/parser.(*RenpyGraph).AddEdge(0xc000123d80, 0x0, 0x0, 0xc000123de0, 0x3, 0x3)
renpy-graphviz/parser/graph.go:115 +0x136
pkg.amethysts.studio/renpy-graphviz/parser.Graph(0xc000062180, 0x4, 0x4, 0x1, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
renpy-graphviz/parser/parser.go:48 +0x50f
main.main()
renpy-graphviz/main.go:17 +0xa5

The logic in the example is faulty, but it doesn't break RenPy, so it shouldn't break renpy-graphviz either. A call or a duplicate return or "" after return don't crash the tool, so, without digging deep into the source I can't figure out why jump does.

This link, also located in the readme file no longer works. I can update the readme if you'd like me to.

BEFORE FILING THIS:

• My game is made with the Ren'Py visual novel game engine
• My game is uploaded on GitHub
• I have tried the online tool by entering myusername/mygame and it works

Hello, I wanted to add xxx/yyy to the game list.

Thanks

BEFORE FILING THIS:

• My game is made with the Ren'Py visual novel game engine
• My game is uploaded on GitHub
• I have tried the online tool by entering myusername/mygame and it works

Hello,

I make Renpy games in Chinese.

Label_name use Chinese won't be able to run.

Label_name use English can run, but the Chinese menu can't display properly.(I guess Japanese has the same problem.)

Thanks.

BEFORE FILING THIS:

• My game is made with the Ren'Py visual novel game engine
• My game is uploaded on GitHub
• I have tried the online tool by entering myusername/mygame and it works

Hello,

I make Renpy games in Chinese.

Label_name use Chinese won't be able to run.

Label_name use English can run, but the Chinese menu can't display properly.(I guess Japanese has the same problem.)

Thanks.

Haven't found a mention of this, but I noticed that underscores in label names don't get drawn on the outputted image.

If you're not familiar with the renpy code, it'll take some guessing attempts to find the correct label.