evertonesc / rock-school Goto Github PK

Backend

• Change instruments enum to courses enum
• Refactor unit tests

Frontend

• Check the needed change points

• Encrypt password

Check if it's worth validate entities inside the factory methods, with this:

• The entities or value objects will implement their respective interface and extends IValidateResult properties.

• Create validation for literal numbers
• Create password Dto with validation
• Test the use cases

• remove all unnecessary folder

• Create a standard return with a abstract class for use cases
• Remove the return type from domain
• Create Presenters folder in Adapters Layer
• Move the standard response to the adapters
• Decouple use-cases layer from adapters layer
• Create a standard type for entities and value objects validations interface example {message: string, valid: boolean}

• Change jest setup to use config giles

• Example:

• "test": "jest --passWithNoTests --runInBand --no-cache",

  "test:unit": "npm test -- --watch -c jest-unit-config.js",
  "test:integration": "npm test -- --watch -c jest-integration-config.js",
  "test:staged": "npm test -- --findRelatedTests",
  "test:ci": "npm test -- --coverage",
  "test:coveralls": "npm run test:ci && coveralls < coverage/lcov.info"

There are several validations that shouldn't be in the domain

Node can't find import modules on dist folder