evandixon / ds-rom-patcher Goto Github PK

View Code? Open in Web Editor NEW

14.0 14.0 2.0 343 KB

Sky Editor's ROM patcher for NDS and 3DS ROMs

License: Other

Visual Basic .NET 100.00%

ds-rom-patcher's People

Contributors

Stargazers

Watchers

Forkers

goofwear vb6hobbyst7

ds-rom-patcher's Issues

Create Mod window accepts files, but the Mod builder does not

This should accept files:
https://github.com/evandixon/DS-ROM-Patcher/blob/master/DS%20ROM%20Patcher/ModBuilder.vb#L135

Workaround: use .Net 3DS Toolkit to extract the ROM first, and give the Create Mod window a directory.

UI to distinguish 3DS output formats

Add patch creation UI

Criteria:

UI to add mods to current mod pack
Create patch given source rom/directory and destination rom/directory
UI to manage custom file patchers on a per mod basis

No line break between author and description in mod details

Add OnionFS support

http://gbatemp.net/threads/release-onionfs-for-ntr-cfw-layeredfs-plugin-fork-that-works-with-any-game.453218/

Mod creation freezes UI when working

Everything should happen on a different thread from the UI.

Warn user when no compatible mods are available

This probably means the wrong ROM was supplied

Convert existing mods to 7-zip

Following the completion of #11, there should be an option to convert old zip mods to 7-zip to save space.

Move game code info from modpack to mod

Can't create a patch for NDS ROMs

Repro steps:

Open an existing modpack
Give it an existing rom and click Patch
Watch the progress bar
The progress bar goes to "Ready" instead of opening the dialog to choose the output file.

Workaround: Use DSPatcher.exe from the command-line, using absolute paths.
Example:

DSPatcher.exe "C:\whatever\rom.nds" "C:\whatever\output.nds"

When failing to launch a program in ProcessHelper, include the filename and arguments in the exception

Replace xdelta with LibIPS

Instead of using an xdelta executable, use LibIPS.Net to make this even more platform-independent and avoid platform-specific issues using xdelta.

Exeption: Invalid folder name

Folder:C:\page\nds
I tried to create a mod

`Exception Details:
System.IO.IOException: Неверно задано имя папки.

в System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
в System.IO.FileSystemEnumerableIterator1.CommonInit() в System.IO.FileSystemEnumerableIterator1..ctor(String path, String originalUserPath, String searchPattern, SearchOption searchOption, SearchResultHandler`1 resultHandler, Boolean checkHost)
в System.IO.Directory.GetFiles(String path, String searchPattern, SearchOption searchOption)
в DS_ROM_Patcher.ModBuilder._Closure$__77-0.VB$StateMachine___Lambda$__0.MoveNext() в C:\BuildAgent\work\8846286b43186fcd\DS ROM Patcher\ModBuilder.vb:строка 159
--- Конец трассировка стека из предыдущего расположения, где возникло исключение ---
в System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
в System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
в System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task)
в DS_ROM_Patcher.ModBuilder.VB$StateMachine_77_BuildMod.MoveNext() в C:\BuildAgent\work\8846286b43186fcd\DS ROM Patcher\ModBuilder.vb:строка 153
--- Конец трассировка стека из предыдущего расположения, где возникло исключение ---
в System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
в System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
в DS_ROM_Patcher.CreateModWindow.VB$StateMachine_146_Build.MoveNext() в C:\BuildAgent\work\8846286b43186fcd\DS ROM Patcher\Forms\CreateModWindow.vb:строка 98
--- Конец трассировка стека из предыдущего расположения, где возникло исключение ---
в System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
в System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
в DS_ROM_Patcher.CreateModWindow.VB$StateMachine_145_btnCreate_Click.MoveNext() в C:\BuildAgent\work\8846286b43186fcd\DS ROM Patcher\Forms\CreateModWindow.vb:строка 74
--- Конец трассировка стека из предыдущего расположения, где возникло исключение ---
в System.Runtime.CompilerServices.AsyncMethodBuilderCore.<>c.b__6_0(Object state)

Loaded Assemblies:

mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089
C:\Windows\Microsoft.NET\Framework\v4.0.30319\mscorlib.dll

DSPatcher, Version=1.2.0.111, Culture=neutral, PublicKeyToken=null
C:\DSPatcher.exe

System, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089
C:\Windows\Microsoft.Net\assembly\GAC_MSIL\System\v4.0_4.0.0.0__b77a5c561934e089\System.dll

System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089
C:\Windows\Microsoft.Net\assembly\GAC_MSIL\System.Windows.Forms\v4.0_4.0.0.0__b77a5c561934e089\System.Windows.Forms.dll

System.Drawing, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
C:\Windows\Microsoft.Net\assembly\GAC_MSIL\System.Drawing\v4.0_4.0.0.0__b03f5f7f11d50a3a\System.Drawing.dll

Microsoft.VisualBasic, Version=10.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
C:\Windows\Microsoft.Net\assembly\GAC_MSIL\Microsoft.VisualBasic\v4.0_10.0.0.0__b03f5f7f11d50a3a\Microsoft.VisualBasic.dll

System.Configuration, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
C:\Windows\Microsoft.Net\assembly\GAC_MSIL\System.Configuration\v4.0_4.0.0.0__b03f5f7f11d50a3a\System.Configuration.dll

System.Core, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089
C:\Windows\Microsoft.Net\assembly\GAC_MSIL\System.Core\v4.0_4.0.0.0__b77a5c561934e089\System.Core.dll

System.Xml, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089
C:\Windows\Microsoft.Net\assembly\GAC_MSIL\System.Xml\v4.0_4.0.0.0__b77a5c561934e089\System.Xml.dll

Accessibility, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
C:\Windows\Microsoft.Net\assembly\GAC_MSIL\Accessibility\v4.0_4.0.0.0__b03f5f7f11d50a3a\Accessibility.dll

SkyEditor.Core, Version=4.1.0.0, Culture=neutral, PublicKeyToken=null
C:\SkyEditor.Core.dll

System.IO.Compression.FileSystem, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089
C:\Windows\Microsoft.Net\assembly\GAC_MSIL\System.IO.Compression.FileSystem\v4.0_4.0.0.0__b77a5c561934e089\System.IO.Compression.FileSystem.dll

Newtonsoft.Json, Version=9.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed
C:\Newtonsoft.Json.dll

DotNet3dsToolkit, Version=2.0.0.51, Culture=neutral, PublicKeyToken=null
C:\DotNet3dsToolkit.dll

DotNetNdsToolkit, Version=2.0.0.0, Culture=neutral, PublicKeyToken=null
C:\DotNetNdsToolkit.dll

mscorlib.resources, Version=4.0.0.0, Culture=ru, PublicKeyToken=b77a5c561934e089
C:\Windows\Microsoft.Net\assembly\GAC_MSIL\mscorlib.resources\v4.0_4.0.0.0_ru_b77a5c561934e089\mscorlib.resources.dll

User Message:
An unhandled exception has occurred.
You can continue running the program, but please report this error.
`

Bad manifest inside Sky Editor

Exception Details:
System.IO.FileLoadException: Could not load file or assembly 'System.Runtime, Version=4.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
File name: 'System.Runtime, Version=4.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
   at DS_ROM_Patcher.Form2.VB$StateMachine_105_Form2_Load.MoveNext()
   at System.Runtime.CompilerServices.AsyncVoidMethodBuilder.Start[TStateMachine](TStateMachine& stateMachine)
   at DS_ROM_Patcher.Form2.Form2_Load(Object sender, EventArgs e)
   at System.Windows.Forms.Form.OnLoad(EventArgs e)
   at System.Windows.Forms.Form.OnCreateControl()
   at System.Windows.Forms.Control.CreateControl(Boolean fIgnoreVisible)
   at System.Windows.Forms.Control.CreateControl()
   at System.Windows.Forms.Control.WmShowWindow(Message& m)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ScrollableControl.WndProc(Message& m)
   at System.Windows.Forms.Form.WmShowWindow(Message& m)
   at System.Windows.Forms.Form.WndProc(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

WRN: Assembly binding logging is turned OFF.
To enable assembly bind failure logging, set the registry value [HKLM\Software\Microsoft\Fusion!EnableLog] (DWORD) to 1.
Note: There is some performance penalty associated with assembly bind failure logging.
To turn this feature off, remove the registry value [HKLM\Software\Microsoft\Fusion!EnableLog].


Loaded Assemblies:
--------------------
mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089
C:\Windows\Microsoft.NET\Framework\v4.0.30319\mscorlib.dll

DSPatcher, Version=1.2.0.102, Culture=neutral, PublicKeyToken=null
D:\SkyEditor\Starter Test 2017-06-04\ModPack\Output\ModPack 1.0.0\DSPatcher.exe

System, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089
C:\WINDOWS\Microsoft.Net\assembly\GAC_MSIL\System\v4.0_4.0.0.0__b77a5c561934e089\System.dll

System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089
C:\WINDOWS\Microsoft.Net\assembly\GAC_MSIL\System.Windows.Forms\v4.0_4.0.0.0__b77a5c561934e089\System.Windows.Forms.dll

System.Drawing, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
C:\WINDOWS\Microsoft.Net\assembly\GAC_MSIL\System.Drawing\v4.0_4.0.0.0__b03f5f7f11d50a3a\System.Drawing.dll

Microsoft.VisualBasic, Version=10.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
C:\WINDOWS\Microsoft.Net\assembly\GAC_MSIL\Microsoft.VisualBasic\v4.0_10.0.0.0__b03f5f7f11d50a3a\Microsoft.VisualBasic.dll

System.Core, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089
C:\WINDOWS\Microsoft.Net\assembly\GAC_MSIL\System.Core\v4.0_4.0.0.0__b77a5c561934e089\System.Core.dll

System.Configuration, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
C:\WINDOWS\Microsoft.Net\assembly\GAC_MSIL\System.Configuration\v4.0_4.0.0.0__b03f5f7f11d50a3a\System.Configuration.dll

System.Xml, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089
C:\WINDOWS\Microsoft.Net\assembly\GAC_MSIL\System.Xml\v4.0_4.0.0.0__b77a5c561934e089\System.Xml.dll

SkyEditor.Core, Version=4.1.0.0, Culture=neutral, PublicKeyToken=null
D:\SkyEditor\Starter Test 2017-06-04\ModPack\Output\ModPack 1.0.0\SkyEditor.Core.dll

--------------------
User Message:
An unhandled exception has occurred.
You can continue running the program, but please report this error.

7-zip for mods

Some large xdelta patches can be significantly reduced in size if 7-zip is used. The 7-zip standalone executable should be bundled with the application.

Bundle 7-zip
Create new mods as 7-zip files with a new extension (not .mod)
Ensure older mods still extract properly
Ensure application is compliant with the LGPL license