evan / has_many_polymorphs Goto Github PK

For Rails 3.2 write_inheritable_hash is Depricated change with

class_attribute :attribute_name
self.attribute_name = value

I have the following situation:

class Housing::Kennel < ActiveRecord::Base
has_many_polymorphs :guests, :from => [:dogs,:cats,_birds]
end

class GuestKennel < ActiveRecord::Base
belongs_to :kennel
belongs_to :guest, :polymorphic => true
end

class Pets::Dog < ActiveRecord::Base
end

Which I cannot get to run: (ActiveRecord::Associations::PolymorphicError: Could not find a valid class for :guests_kennels (tried GuestsKennel). If it's namespaced, be sure to specify it as :"guests/guests_kennels" instead.) - the error-message varies, depending in which module Kennel, GuestsKennel, Dog are put.

In the end, putting all three classes in one module and adding this module with :namespace => :housingandpets solves this issue.

Is there a way to specifiy the module for all three particpiants (Kennel, GuestsKennel, Dog) independently from each other and put them into different modules?!

(and thx for hmp anyway, works great!)

here's what I see in the console in production:
Loading production environment (Rails 2.3.11)
/opt/ruby-enterprise-1.8.7-2010.02/lib/ruby/gems/1.8/gems/activerecord-2.3.11/lib/active_record/base.rb:1998:in method_missing':NoMethodError: undefined methodhas_many_polymorphs' for #Class:0xd11d480

but in development mode, no problems.

Why would there be a difference?

my production.rb and development.rb files make no mention of has_many_polymorphs.

I'm trying to define multiple polymorphic relations (has_many_polymorphs plugin) from a single parent to same children.

Note has many viewers
Note has many editors
Viewers could be either Users or Groups
Editors could be either Users or Groups
Permission is the association model with note_id, viewer_id, viewer_type, editor_id, editor_type fields

Everything works out as expect as long as I have only one has_many_polymorphs relation defined in Note model

class User < ActiveRecord::Base; end
class Group < ActiveRecord::Base; end

class Note < ActiveRecord::Base
    has_many_polymorphs :viewers, :through => :permissions, :from => [:users, :groups]
end

class Permission < ActiveRecord::Base
    belongs_to :note
    belongs_to :viewer, :polymorphic => true
end


Note.first.viewers << User.first # =>  [#<User id: 1, ....>]
Note.first.viewers << Group.first # =>  [#<User id: 1, ....>, #<Group ...>]
Note.first.viewers.first # => #<User ....>
Note.first.viewers.second # => #<Group ....>

Now, problems start to appear when I add the second relation

class Note < ActiveRecord::Base
    has_many_polymorphs :viewers, :through => :permissions, :from => [:users, :groups]
    has_many_polymorphs :editors, :through => :permissions, :from => [:users, :groups]
end

class Permission < ActiveRecord::Base
    belongs_to :note
    belongs_to :viewer, :polymorphic => true
    belongs_to :editor, :polymorphic => true
end

Note.first.viewers << User.first # => [#<User id: ....>]

# >>>>>>>>
Note.first.editors << User.first

NoMethodError: You have a nil object when you didn't expect it!
The error occurred while evaluating nil.constantize
... vendor/plugins/has_many_polymorphs/lib/has_many_polymorphs/base.rb:18:in `instantiate'

I've tried refining the definition of has_many_polymorphs but it didn't work. Not even with an STI model for ViewPermission < Permission, and EditPermission < Permission.

Any thoughts / workarounds / issue pointers are appreciated.

Rails 2.3.0

Hello,

I am going to create a package for Fedora. Do you have plans to release a gem?

Would be nice. Its easier and more efficient for linux distribution to track gem releases and then repack them.

The runtime performance of hmp is killing me in development mode. How can we make this better? Code generation maybe? I'm willing to help build it.

I get this error from the plugin when I try to create a new model:

/rubyprograms/dreamstill/vendor/plugins/has_many_polymorphs/lib/has_many_polymorphs/configuration.rb:7: Configuration is not a class (TypeError)
from /Library/Ruby/Gems/1.8/gems/activesupport-3.0.4/lib/active_support/dependencies.rb:239:in require' from /Library/Ruby/Gems/1.8/gems/activesupport-3.0.4/lib/active_support/dependencies.rb:239:inrequire'
from /Library/Ruby/Gems/1.8/gems/activesupport-3.0.4/lib/active_support/dependencies.rb:225:in load_dependency' from /Library/Ruby/Gems/1.8/gems/activesupport-3.0.4/lib/active_support/dependencies.rb:596:innew_constants_in'
from /Library/Ruby/Gems/1.8/gems/activesupport-3.0.4/lib/active_support/dependencies.rb:225:in load_dependency' from /Library/Ruby/Gems/1.8/gems/activesupport-3.0.4/lib/active_support/dependencies.rb:239:inrequire'
from /rubyprograms/dreamstill/vendor/plugins/has_many_polymorphs/lib/has_many_polymorphs.rb:23
from /Library/Ruby/Gems/1.8/gems/activesupport-3.0.4/lib/active_support/dependencies.rb:239:in require' from /Library/Ruby/Gems/1.8/gems/activesupport-3.0.4/lib/active_support/dependencies.rb:239:inrequire'
from /Library/Ruby/Gems/1.8/gems/activesupport-3.0.4/lib/active_support/dependencies.rb:225:in load_dependency' from /Library/Ruby/Gems/1.8/gems/activesupport-3.0.4/lib/active_support/dependencies.rb:596:innew_constants_in'
from /Library/Ruby/Gems/1.8/gems/activesupport-3.0.4/lib/active_support/dependencies.rb:225:in load_dependency' from /Library/Ruby/Gems/1.8/gems/activesupport-3.0.4/lib/active_support/dependencies.rb:239:inrequire'
from /rubyprograms/dreamstill/vendor/plugins/has_many_polymorphs/init.rb:2
from /Library/Ruby/Gems/1.8/gems/railties-3.0.4/lib/rails/plugin.rb:81
from /Library/Ruby/Gems/1.8/gems/railties-3.0.4/lib/rails/initializable.rb:25:in instance_exec' from /Library/Ruby/Gems/1.8/gems/railties-3.0.4/lib/rails/initializable.rb:25:inrun'
from /Library/Ruby/Gems/1.8/gems/railties-3.0.4/lib/rails/initializable.rb:50:in run_initializers' from /Library/Ruby/Gems/1.8/gems/railties-3.0.4/lib/rails/initializable.rb:49:ineach'
from /Library/Ruby/Gems/1.8/gems/railties-3.0.4/lib/rails/initializable.rb:49:in run_initializers' from /Library/Ruby/Gems/1.8/gems/railties-3.0.4/lib/rails/application.rb:134:ininitialize!'
from /Library/Ruby/Gems/1.8/gems/railties-3.0.4/lib/rails/application.rb:77:in send' from /Library/Ruby/Gems/1.8/gems/railties-3.0.4/lib/rails/application.rb:77:inmethod_missing'
from /rubyprograms/dreamstill/config/environment.rb:5
from /Library/Ruby/Gems/1.8/gems/railties-3.0.4/lib/rails/application.rb:103:in require' from /Library/Ruby/Gems/1.8/gems/railties-3.0.4/lib/rails/application.rb:103:inrequire_environment!'
from /Library/Ruby/Gems/1.8/gems/railties-3.0.4/lib/rails/commands.rb:16
from script/rails:6:in `require'
from script/rails:6

What's going on here?

In ActiveRecord's accepts_nested_attributes_for, it uses a case statement on the reflection macro to determine the association type, and predictably, it doesn't include :has_many_polymorphs, which results in a call to a nonexistent method.

See my fork for a failing test case and possible fix for Rails 2.3.5 (test fails on master, succeeds on nested_attributes_fix branch): http://github.com/brettdh/has_many_polymorphs

I'm a Rails neophyte, so I'm not sure what would be The Right Way to fix this, since the fix requires a complete override of the relevant methods. How might I go about keeping such an override working over different Rails versions?

The new code in question is:

open(filename, :encoding=>"utf-8") do |file|

the error reported is:

open-uri.rb:32:in `initialize': can't convert Hash into String (TypeError)

The same error occurs using File.open:

File.open(filename, :encoding=>"utf-8") do |file|

Presumably this only works in Ruby 1.9. I'm building Ruby 1.9 now to check. In the latest Pickaxe book this is the method described for setting the encoding to utf-8 when using File.open:

File.open(filename, 'r:utf-8')

This method also doesn't work in 1.8.x

Also see comments on this commit:

http://github.com/fauna/has_many_polymorphs/commit/bacaeb095f5e8cf7427679b2755680ab24f8503e

I was hoping somebody might point me in the right direction. I have a class Ad that has a number of different placements on a website. It has_many_polymorphs :placements, :from => [:categories, :products, :pages, :menu_items], giving me the ability to have an ad show up on a number of different models - all of this works great!

I'd like to use two more attributes on each ad - one is position for acts_as_list, and the other is location which would just be a string. I have set up the placements table with these two new fields, but I can't figure out how to extend the Ad class to include these join attributes so I can refer to these attributes when I call for child_class.ads.first.position for instance. I think I'm supposed to be using :parent_extend to assign the joined attrs to the Ad model when a child references it. Any help?

The tagging-extension definse two additional finders on the model, tagged_with and tagged_with_any - the code for tagged_with any (in tagging_extensions.rb) reads like this:

def self.tagged_with_any(*tag_list)

Shouldnt't this be
def tagged_with_any(*tag_list)

With the self. I get an "undefined method" but even without the self, I get a
Association named 'from' was not found; perhaps you misspelled it? (ActiveRecord::ConfigurationError)

Is this supposed to work, is it used/tested somewhere? Just asking, before I dive deeper into this and try to fix it...

thx&cheers
Stefan

P.S: Is this the right place for communication anyway? It doesn't look like anybody is looking into these issues ever, should I go ask somewhere else?!

We're getting an interesting situation where a specific series of relationships produces an unknown column error in production only.

Consider the following:
class User < ActiveRecord::Base
has_many_polymorphs :accessible_products, :through => :accessibles, :as => :contact,
:foreign_key => 'contact_id', :foreign_type_key => 'contact_type',
:polymorphic_key => 'owner_id', :polymorphic_type_key => 'owner_type',
:from => [:"product/one",:"product/two"]
end

                 class Product < ActiveRecord::Base
                 has_many_polymorphs :accessors, :through => :accessibles, :as => :owner, 
                  :foreign_key => 'owner_id', :foreign_type_key => 'owner_type',
                  :polymorphic_key => 'contact_id', :polymorphic_type_key => 'contact_type',
                  :from => [:emails, :users]
                  end

                  class Accessible < ActiveRecord::Base
                  acts_as_double_polymorphic_join :owners =>[:"product/one",:"product/two"],
                              :contacts => [:users, :emails]
                  end

This cyclical relationship should be handled by the acts_as_double_polymorphic_join but it's erroring in production, possibly due preloading of models and caching them, not sure.

The error we receive in production is ActionView::TemplateError: Mysql::Error: Unknown column 'accessibles.accessible_product_id'

The foreign and polymorphic keys are clearly defined, not sure why this is happening and only in production.

is oracle supported?
I'm having problems with "as" keywords in joins.
... join table_name as polymorphic_parent on ...
results in missing keyword on my oracle installation. should be
... join table_name polymorphic_parent on ...
without "as"

Hi,
is your plugin compatible with rails3?

I've been creating a rails project using has_many_polymorphs to create associations between models. Some of these models store data in columns directly related to keys in incoming/outgoing plists. This has resulted in some of the columns having capitalized names. Unfortunately, postgres automatically lowercases all characters in passed column names unless they are correctly double quoted. In its current form, has_many_polymorphs does not correctly handle this case. The error looks similar to this:

CollectionsMember Load (0.0ms) PGError: ERROR: column devices.udid does not exist
LINE 1: ...S t0_r2, collections_members.updated_at AS t0_r5, devices.Udid...

I have managed to force things to work correctly by adding quotes around column names in base.rb, function instantiate_with_polymorphic_checks, and in class_methods.rb, function build_table_aliases, though this is likely just a stop gap, as I haven't tested its effects on any other databases, and not fit for actual integration.

This issue likely effects a lot more people than just me, as this seems like a pretty common use case, and can hopefully be addressed quickly.

I am using ACL ( http://github.com/rurounijones/acl9/tree/master ) for access control and combining it with has_many_polymorphs for easy associations.

It is working great with one problem. ACL9 allows you to assign roles on objects,Classes or nothing. When I assign a role on an Object or Class then everything works fine (authorizable_type is not nil in these cases). However when I add a global role ( where authorizable_type is nil) I get the following error.

  The error occurred while evaluating nil.constantize
    from (eval):7:in `before_save'
    from /usr/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/callbacks.rb:347:in `send'
    from /usr/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/callbacks.rb:347:in `callback'
    from /usr/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/callbacks.rb:249:in `create_or_update'
    from /usr/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/base.rb:2539:in `save_without_validation'
    from /usr/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/validations.rb:1009:in `save_without_dirty'
    from /usr/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/dirty.rb:79:in `save_without_transactions'
    from /usr/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/transactions.rb:229:in `send'
    from /usr/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/transactions.rb:229:in `with_transaction_returning_status'
    from /usr/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/connection_adapters/abstract/database_statements.rb:136:in `transaction'
    from /usr/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/transactions.rb:182:in `transaction'
    from /usr/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/transactions.rb:228:in `with_transaction_returning_status'
    from /usr/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/transactions.rb:196:in `save'
    from /usr/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/transactions.rb:208:in `rollback_active_record_state!'
    from /usr/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/transactions.rb:196:in `save'
    from /usr/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/associations/association_collection.rb:242:in `create'
    from /usr/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/associations/association_collection.rb:410:in `create_record'
    from /usr/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/associations/association_collection.rb:428:in `add_record_to_target_with_callbacks'
    from /usr/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/associations/association_collection.rb:410:in `create_record'
    from /usr/lib/ruby/gems/1.8/gems/activerecord-2.3.2/lib/active_record/associations/association_collection.rb:240:in `create'

I believe the error lies in this line:

def association_class
  @owner[@reflection.options[:foreign_type]] ? @owner[@reflection.options[:foreign_type]].constantize : nil
end

Is it possible to change this line to allow for associations where the polymorphic side is nil? In effect ignoring the :through aspect of the association record if the polymorphic side is nil and just leave it to the normal has_many.

Regards

Jeff Jones

Classes follow:

class User < ActiveRecord::Base
  has_many :roles
  has_many_polymorphs :authorizables, :from => [:committees], :through => :roles
end

class Role < ActiveRecord::Base
    belongs_to :user
    belongs_to :authorizable, :polymorphic => true
end

class Committee < ActiveRecord::Base
    has_many :accepted_roles, :as => :authorizable, :class_name => :role, :dependent => :destroy
end

Is it possible to specify conditions to essentially create different name spaces for tags when using the taggin_extensions? For instance, Widgets can be tagged but Widgets belong to a Company and the tag set should be specific to that company and not shared across all widgets.
Any help appreciated.

Would it be possible to get a tagged revision that works with 2.1.2? We have a rather slow-to-upgrade rails code base and I love this plugin in my other projects. Thanks if it's possible!

Here is my code: http://pastie.org/456077
The first time i run it, it goes ok. The second time it blows up when i add the event to the list.

It seems the second time it passes the "if record['polymorphic_parent_class']" in base.rb. The first time it doesnt enter the if.

can't dup NilClass
/Users/magmarules/Sites/Probono/vendor/plugins/has_many_polymorphs/lib/has_many_polymorphs/base.rb:14:in dup' /Users/magmarules/Sites/Probono/vendor/plugins/has_many_polymorphs/lib/has_many_polymorphs/base.rb:14:ininstantiate'
/Library/Ruby/Gems/1.8/gems/activerecord-2.2.2/lib/active_record/base.rb:635:in find_by_sql' /Library/Ruby/Gems/1.8/gems/activerecord-2.2.2/lib/active_record/base.rb:635:incollect!'
/Library/Ruby/Gems/1.8/gems/activerecord-2.2.2/lib/active_record/base.rb:635:in find_by_sql' /Library/Ruby/Gems/1.8/gems/activerecord-2.2.2/lib/active_record/base.rb:1490:infind_every'
/Library/Ruby/Gems/1.8/gems/activerecord-2.2.2/lib/active_record/base.rb:589:in find' /Library/Ruby/Gems/1.8/gems/activerecord-2.2.2/lib/active_record/associations/has_many_through_association.rb:73:infind_target'
/Library/Ruby/Gems/1.8/gems/activerecord-2.2.2/lib/active_record/associations/association_collection.rb:344:in load_target' /Users/magmarules/Sites/Probono/vendor/plugins/has_many_polymorphs/lib/has_many_polymorphs/association.rb:19:in<<'
/Users/magmarules/Sites/Probono/lib/tasks/import.rake:222
/Library/Ruby/Gems/1.8/gems/rake-0.8.4/lib/rake.rb:617:in call' /Library/Ruby/Gems/1.8/gems/rake-0.8.4/lib/rake.rb:617:inexecute'
/Library/Ruby/Gems/1.8/gems/rake-0.8.4/lib/rake.rb:612:in each' /Library/Ruby/Gems/1.8/gems/rake-0.8.4/lib/rake.rb:612:inexecute'
/Library/Ruby/Gems/1.8/gems/rake-0.8.4/lib/rake.rb:578:in invoke_with_call_chain' /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/monitor.rb:242:insynchronize'
/Library/Ruby/Gems/1.8/gems/rake-0.8.4/lib/rake.rb:571:in invoke_with_call_chain' /Library/Ruby/Gems/1.8/gems/rake-0.8.4/lib/rake.rb:564:ininvoke'
/Library/Ruby/Gems/1.8/gems/rake-0.8.4/lib/rake.rb:2027:in invoke_task' /Library/Ruby/Gems/1.8/gems/rake-0.8.4/lib/rake.rb:2005:intop_level'
/Library/Ruby/Gems/1.8/gems/rake-0.8.4/lib/rake.rb:2005:in each' /Library/Ruby/Gems/1.8/gems/rake-0.8.4/lib/rake.rb:2005:intop_level'
/Library/Ruby/Gems/1.8/gems/rake-0.8.4/lib/rake.rb:2044:in standard_exception_handling' /Library/Ruby/Gems/1.8/gems/rake-0.8.4/lib/rake.rb:1999:intop_level'
/Library/Ruby/Gems/1.8/gems/rake-0.8.4/lib/rake.rb:1977:in run' /Library/Ruby/Gems/1.8/gems/rake-0.8.4/lib/rake.rb:2044:instandard_exception_handling'
/Library/Ruby/Gems/1.8/gems/rake-0.8.4/lib/rake.rb:1974:in run' /Library/Ruby/Gems/1.8/gems/rake-0.8.4/bin/rake:31 /usr/bin/rake:19:inload'
/usr/bin/rake:19

I stumbled upon a situation where join model would get inserted two records whenever has_many_polymorphs was used.

Here is the scenario

class Item < ActiveRecord::Base

after_create :add_info

has_many_polymorphs :describables, :from => [:public_product_infos, :propriatary_product_infos], :through => :product_descriptions

def add_info
describables << PublicProductInfo.create(:stuff=>"blah")
end

end

I've noticed that this would insert two records into 'product_descriptions' table. Doing backtracing in debug mode it seems that the first insert is triggered by has_many_polymorphs during array append operation (as expected). However, the second one seems to be happening as if it was a regular has_many relationship. The latter one is undesirable. The fix for that was to change

after_create

to

after_save

I have a owner model:

class Person < ActiveRecord::Base
  has_many_polymorphs :things, :from => [ :books, :cds, :dvds ], :through => :person_things
end

a relationship model:

class PersonThing < ActiveRecord::Base
  belongs_to :person
  belongs_to :thing, :polymorphic => true
end 

and several owned models:

class Book < ActiveRecord::Base
end
...

If I create a relationship:

person = Person.create!(:name => 'Barney')
book = Book.create!('Dinosaurs for Dummies')
person.things << book

then include? fails even when select doesn't:

person.things.include? book
# => false
person.things.select { |t| t == book }.any?
# => true

I'm guessing include? is redefined on this enumeration, but it's not redefined correctly.

Hi,

I am in the process of updating Rails 2.x to 3.x , it will support for Rails 3.x version?