`russh::server::Server::handle_session_error` seems to reference the new client instance rather than the one with the failed session about russh HOT 5 CLOSED

It's because you're conflating Server with Handler. You should have separate structs that implement these traits. Russh works with one Server instance and multiple Handlers.

handle_session_error is a Server method and you're seeing your own self-incremented <self as Server>.id.

from russh.

In case you've used echoserver example as the base for your code, that's on me as echoserver omits having separate structs to keep the code shorter ✌️

from russh.

@Eugeny, thanks for the quick reply.

It's because you're conflating Server with Handler.

You are right, I am. Now that you said that the traits descriptions make more sense to me.

In case you've used echoserver example as the base for your code

ratatui_app is the one I used as a reference since it was the most suitable to my use case. I understand the urge to keep the code shorter in the examples, but in my case this led to confusion. I'm not suggesting anything though, just sharing my experience with the lib.

from russh.

@Eugeny, I think having separate structs that implement Server and Handler traits might not be acceptable for my use case yet. I've just realized the server runs an infinite loop that renders the view to the connected clients (each client has own terminal handle, of course). This is exactly what ratatui_app does and perhaps this explains the reason behind implementing both traits for one struct, i.e. AppServer. What do you think?

from russh.

Even in this case, you still don't need it to be the same structure. The busy loop does not even reference self (beyond using the shared clients Arc)

from russh.