Giter Club home page Giter Club logo

Comments (12)

etianen avatar etianen commented on May 19, 2024

I think this is covered in the LowLevelAPI wiki section. It's really just a case of

# Insert management comment boilerplate...
with reversion.revision:
    your_model.save()

from django-reversion.

jedie avatar jedie commented on May 19, 2024

I tried this, but it doesn't work. No new version saved and no error.

But i found the failure: I only registered my model with VersionAdmin. In this case it's needed to register the model in models.py, isn't it?

So it's a good idea to clarify this in LowLevelAPI wiki page?

from django-reversion.

etianen avatar etianen commented on May 19, 2024

If you register with VersionAdmin, then you just need to import the relevant
admin.py file.

Yeah, a little clarification wouldn't go amis here. I'll put it in.

No error is the correct behaviour, though, as it's quite correct to save
models within the scope of a revision that aren't intended for version
control.

I tried this, but it doesn't work. No new version saved and no error.

But i found the failure: I only registered my model with VersionAdmin. In
this case it's needed to register the model in models.py, isn't it?

So it's a good idea to clarify this in LowLevelAPI wiki page?

Reply to this email directly or view it on GitHub:
#63 (comment)

Dave Hall
Etianen.com

Telephone: 07525 452381
Web: http://www.etianen.com

from django-reversion.

jedie avatar jedie commented on May 19, 2024

Btw. How to add a comment to this?

I tried:

with reversion.revision:
    reversion.comment = "one"
    your_model.save()

and:

with reversion.revision:
    your_model.save()
    reversion.comment = "two"

But no comment saved.

from django-reversion.

etianen avatar etianen commented on May 19, 2024

To quote the LowLevelApi wiki:

It is possible to attach a comment and a user reference to an active revision using the following method:

    @revision.create_on_success
    def your_view(request):
        your_model.save()
        # Set the revision meta data.
        revision.user = me
        revision.comment = "Doing some changes..."

from django-reversion.

jedie avatar jedie commented on May 19, 2024

OK, it only works with create_on_success decorator, but not with "with" statement? Good idea to put this to docs, too ;)

from django-reversion.

jedie avatar jedie commented on May 19, 2024

I tried @revision.create_on_success in a management command. A new reversion saved, but without comment.

from django-reversion.

jedie avatar jedie commented on May 19, 2024

Here is a example of my command: https://gist.github.com/1037609

from django-reversion.

etianen avatar etianen commented on May 19, 2024

It's revision.comment, not reversion.comment

from django-reversion.

jedie avatar jedie commented on May 19, 2024

Ah! That's it. Thank you.

Foolish that's the words are so similar. ;)

from django-reversion.

etianen avatar etianen commented on May 19, 2024

Heh, I'll take a look at the docs and try to make things easier! :P

from django-reversion.

etianen avatar etianen commented on May 19, 2024

I've added in some clarification to the docs.

from django-reversion.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.