Comments (3)
Rewriting this project to only support PostgreSQL and JSON serialization would allow indexing on the versioned data, yes.
The loss of general usefulness to support a single use-case seems like a bad tradeoff to me.
If efficient introspection of the versioned data is required, I'd suggest going one step further and having a dedicated version table for each model. That would avoid any JSON overhead whatsoever.
from django-reversion.
I'm not sure how this could be implemented. A database field that is one type or another based on a setting is tricky, since the migrations would have to vary depending on that setting too! And if a user changed the setting after running the migrations, a new migration would have to be made, and where would Django store it?
I'm not sure Django really supports the idea of a database field that is dependent on a setting. I fear this would cause a lot of weird behavior for people.
filtering very efficiently a QuerySet of Version instances
Unfortunately, this would still likely involve a sequential table scan in postgres. It's likely that for large tables this would still be prohibitive.
from django-reversion.
Thank you for your feedback (and for your work here).
I had the feeling that such a change could quickly become a burden in terms of development and maintenance cost. But I wanted to hear your perspectives on this idea. You're right that this is probably not feasible without deeply rethinking the extension / without significant breaking changes, which is not an option...
Unfortunately, this would still likely involve a sequential table scan in postgres. It's likely that for large tables this would still be prohibitive.
That being said, I'm not an expert on the subject but isn't it exactly the contrary? According to Django documentation:
PostgreSQL users
PostgreSQL has two native JSON based data types: json and jsonb. The main difference between them is how they are stored and how they can be queried. PostgreSQL’s json field is stored as the original string representation of the JSON and must be decoded on the fly when queried based on keys. The jsonb field is stored based on the actual structure of the JSON which allows indexing. The trade-off is a small additional cost on writing to the jsonb field. JSONField uses jsonb.
As I understand it, that means PostgreSQL users (the vast majority of Django users) should be able to add indexes to JSONFields
. Admittedly, this seems to be a recent & not commonly used feature in Django. So from a pure theoretical point of view, should you rewrite the extension from scratch for PostgreSQL users only & for users who would never use anything else than JSON to serialize data, don't you think the idea could make sense?
(Yeah, that makes quite a few conditions)
from django-reversion.
Related Issues (20)
- Using fixtures to initialise versioned inline data HOT 3
- "Could not load - incompatible version data" for versions having an empty PartialDateField HOT 1
- Decorator: create_revision request parameter is inheriting wrong object HOT 1
- Browsing history entries in admin fires pre/post save signals potentially leading to nasty side effects HOT 5
- Django 4.2 with VersionAdmin: wrapping in tuples does not have any effect (each field on separate line) HOT 1
- Admin: 'GET' on a change_view creates a transaction block HOT 1
- following OnetoOneField HOT 1
- Using reversion with async on python 3.8 HOT 2
- AttributeError: 'HttpResponseRedirect' object has no attribute 'render' HOT 4
- Allow displaying "non-recoverable" objects as read-only HOT 1
- Admin integration: Issue when reverting HOT 3
- #951 BUG SELECT DISTINCT ON expressions must match initial ORDER BY HOT 1
- i was looking for a way to add reversions for changes via DRF HOT 1
- Restore FK logic and best way to ignore fields HOT 3
- ignore_duplicate fields HOT 1
- 5.0.11 misses migration files HOT 6
- Migration file missing for changes introduced in v5.0.11 HOT 3
- Use object_id other than primary key HOT 1
- how to show preview of previous versions in django views. exactly as it is done in admin panel HOT 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-reversion.