ethereum / asyncio-cancel-token Goto Github PK

Also, this might indicate that we need to do something to fix the cancel token chaining API because honestly, I've had trouble sometimes figuring out what the right order should be. Maybe we need something like token.create_child_token() rather than actually combining two tokens and thus, having to figure out the right ordering.

(From ethereum/py-evm#1234 (comment))

Another thing that is problematic and may need to be redesigned (or at least documented), is the fact that sometimes a class will keep a direct reference to the token passed to its constructor (e.g. https://github.com/ethereum/py-evm/blob/master/trinity/protocol/common/managers.py#L200 and https://github.com/ethereum/py-evm/blob/master/trinity/p2p/handlers.py#L33), which means they will cancel their parents if they ever trigger their tokens. Even though some of those may never actually trigger their tokens (e.g. when they only use the token to detect when their parent has terminated), they could still pass these tokens to other classes that eventually do trigger them