Steps to recreate:

• Unsure you have no Asset Volumes set up
• Attempt to download an image from Splash
• CP will return Image downloaded successfully!

When navigating to the settings page in RC9 the following error is encountered:

Internal Server Error
Argument 1 passed to craft\services\Fields::getLayoutById() must be of the type integer, null given, called in /***/***/***/***/***/vendor/ether/splash/src/Splash.php on line 79

Should be links.download_location as per API docs.

Hi, is a Craft 4 compatible release on the roadmap?

When running RC1 the Splash menu item doesn't display correctly, see screenshot below:

PHP Notice 'yii\base\ErrorException' with message 'Undefined offset: 1'

in C:\Users\Caleb\Local Sites\c\app\vendor\ether\splash\src\controllers\SplashController.php:76

Stack trace:
#0 C:\Users\Caleb\Local Sites\c\app\vendor\craftcms\cms\src\web\ErrorHandler.php(76): craft\web\ErrorHandler->handleError()
#1 C:\Users\Caleb\Local Sites\c\app\vendor\ether\splash\src\controllers\SplashController.php(76): craft\web\ErrorHandler->handleError()
#2 C:\Users\Caleb\Local Sites\c\app\vendor\yiisoft\yii2\base\InlineAction.php(57): ether\splash\controllers\SplashController->actionUn()
#3 C:\Users\Caleb\Local Sites\c\app\vendor\yiisoft\yii2\base\InlineAction.php(57): ::call_user_func_array:{C:\Users\Caleb\Local Sites\c\app\vendor\yiisoft\yii2\base\InlineAction.php:57}()
#4 C:\Users\Caleb\Local Sites\c\app\vendor\yiisoft\yii2\base\Controller.php(180): yii\base\InlineAction->runWithParams()
#5 C:\Users\Caleb\Local Sites\c\app\vendor\craftcms\cms\src\web\Controller.php(190): ether\splash\controllers\SplashController->runAction()
#6 C:\Users\Caleb\Local Sites\c\app\vendor\yiisoft\yii2\base\Module.php(528): ether\splash\controllers\SplashController->runAction()
#7 C:\Users\Caleb\Local Sites\c\app\vendor\craftcms\cms\src\web\Application.php(274): craft\web\Application->runAction()
#8 C:\Users\Caleb\Local Sites\c\app\vendor\yiisoft\yii2\web\Application.php(103): craft\web\Application->runAction()
#9 C:\Users\Caleb\Local Sites\c\app\vendor\craftcms\cms\src\web\Application.php(259): craft\web\Application->handleRequest()
#10 C:\Users\Caleb\Local Sites\c\app\vendor\yiisoft\yii2\base\Application.php(386): craft\web\Application->handleRequest()
#11 C:\Users\Caleb\Local Sites\c\app\public\index.php(22): craft\web\Application->run()
#12 {main}
Splash!
Search Unsplash...

Can'y get this to pull in the Image author URL and the color of the image.

I've set the following fields to capture the above, but not working (the image author is fine). They fields are applied to the asset volumes field layout too.

Image Author URL imageAuthorUrl -> Plain Text (tried URL too)

Image Colour imageColour -> Colour

Any ideas why it's not pulling in that info?

Thanks
Lewis

After installing the plugin I get this message:

2019-03-27 09:09:03 [-][1][b9bjju5ps0886ji1apuk1assf2][error][TypeError] TypeError: Argument 1 passed to craft\services\Fields::getLayoutById() must be of the type integer, null given, called in /Users/clarknelson/Documents/lse/vendor/ether/splash/src/Splash.php on line 79 and defined in /Users/clarknelson/Documents/lse/vendor/craftcms/cms/src/services/Fields.php:974
Stack trace:
#0 /Users/clarknelson/Documents/lse/vendor/ether/splash/src/Splash.php(79): craft\services\Fields->getLayoutById(NULL)
#1 /Users/clarknelson/Documents/lse/vendor/craftcms/cms/src/base/Plugin.php(224): ether\splash\Splash->settingsHtml()
#2 /Users/clarknelson/Documents/lse/vendor/craftcms/cms/src/controllers/PluginsController.php(117): craft\base\Plugin->getSettingsResponse()
#3 [internal function]: craft\controllers\PluginsController->actionEditPluginSettings('splash', Object(ether\splash\Splash))
#4 /Users/clarknelson/Documents/lse/vendor/yiisoft/yii2/base/InlineAction.php(57): call_user_func_array(Array, Array)
#5 /Users/clarknelson/Documents/lse/vendor/yiisoft/yii2/base/Controller.php(157): yii\base\InlineAction->runWithParams(Array)
#6 /Users/clarknelson/Documents/lse/vendor/craftcms/cms/src/web/Controller.php(109): yii\base\Controller->runAction('edit-plugin-set...', Array)
#7 /Users/clarknelson/Documents/lse/vendor/yiisoft/yii2/base/Module.php(528): craft\web\Controller->runAction('edit-plugin-set...', Array)
#8 /Users/clarknelson/Documents/lse/vendor/craftcms/cms/src/web/Application.php(297): yii\base\Module->runAction('plugins/edit-pl...', Array)
#9 /Users/clarknelson/Documents/lse/vendor/yiisoft/yii2/web/Application.php(103): craft\web\Application->runAction('plugins/edit-pl...', Array)
#10 /Users/clarknelson/Documents/lse/vendor/craftcms/cms/src/web/Application.php(286): yii\web\Application->handleRequest(Object(craft\web\Request))
#11 /Users/clarknelson/Documents/lse/vendor/yiisoft/yii2/base/Application.php(386): craft\web\Application->handleRequest(Object(craft\web\Request))
#12 /Users/clarknelson/Documents/lse/web/index.php(21): yii\base\Application->run()
#13 /Users/clarknelson/.composer/vendor/laravel/valet/server.php(158): require('/Users/clarknel...')
#14 {main}

When I click the "download" button on an image, I get a spinning wheel and after a while "Image downloaded successfully". However, there is no image in the folder I set up in the configuration. (I only have volumes hosted on 3S, I don't know if that might be the issue.)

Craft Pro 3.0.30.2
Splash 3.0.2

I just noticed that we can't fetch any images from Unsplash after we updated Craft to 3.7.25 and in the log the following error is shown:
Prevented saving /app/storage/runtime/tempA5E-ym6WyGM.jpg as an asset. It must be located within a temp directory or the project root

We are using the latest version of the plugin: 3.0.5

It seems that one slash is missing in the path to the temp image that is saved in the storage so the file is saved directly under the runtime folder with temp as a prefix instead of being saved to the folder temp. Adding slash before the filename fixes this for me on row 139 in the actionDl() method.

Before:

$tempLocation = $tempPath . $fileName; // Results in /storage/runtime/tempxxxxx.png

After:

$tempLocation = $tempPath . '/' . $fileName;  // Results in /storage/runtime/temp/xxxxx.png

Hey.

Just did the update to 3.0.3 and noticed that the plugin only loads 30 images, both initially and and with a search.

Everything seems fine (no errors), but there is nothing showing up in the asset index.

I am using Splash 3.0.2 on Craft 3.0.26.1

Hi,

Is it possible to please add a feature to set the size of the images to download/view. A simple field perhaps in the settings which is then passed to the API query?

Most images are 4mb in size, and after a while this builds up on storage volumes. It would also speed up image transforms and make this the perfect plugin..

Thank you.