ether / ep_font_size Goto Github PK

View Code? Open in Web Editor NEW

3.0 3.0 13.0 341 KB

Font Size support in Etherpad

License: Apache License 2.0

JavaScript 82.10% CSS 6.59% EJS 11.31%

ep_font_size's People

Stargazers

Watchers

Forkers

hasantayyar bertpareyn kamilmowinski successmind rugk citizenos svetaprepprep rhansen woeterman94 webzwo0i isabella232 lgtm-migrator

ep_font_size's Issues

License

Could you please choose a license for this repo.

export then import doesn't work

Changing size then clicking export > html then iumporting that HTML will lose sizes.

This behaviour is contrary to ep_font_color which practically does the same job as this plugin... It is tempting to just copy/paste ep_color and abstract the "style" from color to font size which would mean we can support other css attributes in other plugins much easier...

Size 9 and 10 are not working

I was testing the font size and I saw that size 9 and 10 were not working properly on my instance of etherpad.

Then I went to test on Etherpad's sandstorm demo and was not working there either.
Both 9 and 10 have the same size as 15

Dropdown bar doesn't change when you move the cursor

If you select and area and change the font size, and then move your cursor away from that area, the dropdown bar stays on that font size. It's misleading since it looks like you'd be typing in that font size in the area you just clicked on.

etherpad-lite tag 1.8.14, ep_font_size from npm

Create tests

Once set, Font Size gets forgotten

When setting a font size manually to say 18, then any new text that is written/added in the middle or at the end of the document gets the default (smaller) font size.
When copying a portion of the text (which has font size 18) and pasting it elsewhere in the same page, resets the fontsize back to the default (smaller) font size.

This happens all the time and is a consistent bug. Apart from this little annoyance its a very very nice opensource realtime texteditor! Tested in FireFox 50 on a Windows 10 64 bit machine.

(im forwarding this from here where I originally opened the topic, where lpagliari suggested me to post it here instead so.... ether/etherpad-lite#3200

Button Icon is missing

It would be great and more useful to display a Button Icon in the Button bar instead of the Text which clutters the "Button" Bar. A click on the Button could open up the Menu so people can choose from it. The chosen format could get highlighted as replacing it with a long text would crash the Button bar completely.

By Hover or longer Tapping with the finger (on tablet/phone), the actual chosen value could be shown in the title tag.

Font size information cannot be exported through getHTML api

I tried using getHTML to get the content of a pad and found the style information of font size is lost.

Show active font selection

See ep_subscript for example

PDF export error due to custom HTML tags

Note: For posterity, this has been posted here.

Hello there,

I just realized why HTML to PDF conversion via AbiCommand fails. It's due to custom HTML tags like this:

<body>Cool<br><br> Nam fringilla tellus et erat faucibus efficitur. 
Interdum et malesuada fames ac ante ipsum primis in faucibus. 
In mattis tempus aliquet.<br><fs15>ddaa</fs15><br><br></body>

The fs15 is not part of the current HTML tags libxml2 understands, and thus throws an error during the conversion request and fails to complete. That tag is generated by the awesome ep_font_size plugin by John M. I tried to poke around and see if I could swap that to a class="fs15" but unfortunately I don't see anything easy for a non-coder to change.

Here's the AbiCommand debug log while attempting to convert this HTML file: http://pastie.org/private/mkvwxwqaiy3movoepacugq

DEBUG: !!!!!!!!!!----------------- Created string db8010ac-a312-11e4-9ee0-adcae427221b
DEBUG: !!!!!!!!!!----------------- Orig string db8010ac-a312-11e4-9ee0-adcae427221b
DEBUG: PD_DocumentRDF() this:0x1367880 doc:0x1371580
DEBUG: PD_Document::_importFile... name:file:///tmp/etherpad_export_1459309582.html
DEBUG: PD_DocumentRDF::setupWithPieceTable() m_indexAP:0
DEBUG: PD_Document::importStyles -- file is not plain file
DEBUG: PD_Document::importStyles -- file is not plain file
DEBUG: PD_Document::importStyles -- file is not plain file
DEBUG: PD_Document::importStyles -- file is not plain file
DEBUG: PD_Document::importStyles -- file is not plain file
DEBUG: PD_Document::importStyles -- file is not plain file
DEBUG: pd_Document::setAttrProp: setting dom-dir to ltr
DEBUG: TableHelperStack created document = (nil)
DEBUG: startElement: html, parseState: 0, listType: 0
DEBUG: startElement: head, parseState: 6, listType: 0
DEBUG: startElement: title, parseState: 6, listType: 0
DEBUG: endElement: title, parseState: 14, listType: 0
DEBUG: startElement: meta, parseState: 6, listType: 0
DEBUG: endElement: meta, parseState: 6, listType: 0
DEBUG: startElement: style, parseState: 6, listType: 0
DEBUG: endElement: style, parseState: 6, listType: 0
DEBUG: endElement: head, parseState: 6, listType: 0
DEBUG: startElement: body, parseState: 6, listType: 0
DEBUG: XHTML Import - appendStruxStrux type 0 document 0x1371580
DEBUG: CSS->Props (utf8val): []
DEBUG: XHTML Import - appendStruxStrux type 1 document 0x1371580
DEBUG: CSS->Props (utf8val): []
DEBUG: startElement: br, parseState: 3, listType: 0
DEBUG: endElement: br, parseState: 3, listType: 0
DEBUG: startElement: br, parseState: 3, listType: 0
DEBUG: endElement: br, parseState: 3, listType: 0
DEBUG: startElement: br, parseState: 3, listType: 0
DEBUG: endElement: br, parseState: 3, listType: 0
DEBUG: startElement: br, parseState: 3, listType: 0
DEBUG: endElement: br, parseState: 3, listType: 0
DEBUG: startElement: fs15, parseState: 3, listType: 0
DEBUG: Unknown tag [fs15]
DEBUG: libxml2/html: error: Tag fs15 invalid
endElement: fs15, parseState: 3, listType: 0
DEBUG: Unknown end tag [fs15]
DEBUG: startElement: br, parseState: 3, listType: 0
DEBUG: endElement: br, parseState: 3, listType: 0
DEBUG: startElement: br, parseState: 3, listType: 0
DEBUG: endElement: br, parseState: 3, listType: 0
DEBUG: endElement: body, parseState: 3, listType: 0
DEBUG: XHTML Import - appendStruxStrux type 0 document 0x1371580
DEBUG: CSS->Props (utf8val): []
DEBUG: XHTML Import - appendStruxStrux type 1 document 0x1371580
DEBUG: CSS->Props (utf8val): []
DEBUG: CSS->Props (utf8val): []
DEBUG: XHTML Import - appendStruxStrux type 1 document 0x1371580
DEBUG: CSS->Props (utf8val): []
DEBUG: endElement: html, parseState: 0, listType: 0
DEBUG: Error parsing '' (Line: 39, Column: 8)
DEBUG: Problem reading document
DEBUG: XHTML Import - appendStruxStrux type 0 document 0x1371580
DEBUG: CSS->Props (utf8val): []
DEBUG: XHTML Import - appendStruxStrux type 1 document 0x1371580
DEBUG: CSS->Props (utf8val): []
DEBUG: DOM: suffix: .html
DEBUG: PD_Document::importFile -- could not import file
AbiWord: could not open the file [/tmp/etherpad_export_1459309582.html]
DEBUG: ~PD_DocumentRDF() this:0x1367880
error -1

This is a centos 7 x64bit, running the latest git release of etherpad, and abiword 3.0.1 compiled from source. Latest svn abiword, and 2.9.4 fail the same way.

Fontsize not listed in FileMenu

In Filemenu the font sizes don't get listed

d

Formatting does not get exported

When exporting a complete formatted file the given values do not get exported to .doc, .md, .odt, .pdf, etc.
Check issue ether/etherpad-lite#5211 as it is not clear if it is a problem with the core import/export functionality or a problem with the plugins that provide that information. The document inside etherpad gets actually properly formatted by those plugins!

That is the page that got exported! You can upload the NEW.ETHERPAD.txt file - remove (txt) before uploading.

Other export formats look as follow - on the same page:
Github doesn't like all formats so .txt got added and needs to get removed first.

DOC - New.doc.txt
ETHERPAD - New.etherpad.txt
HTML - New.html.txt
MD - New.md
ODT - New.odt
PDF - New.pdf
TXT - New.txt

Copy paste pageupdown.js test spec into plugin

Copy paste tests and modify to make sure font size is changed on divs/spans etc. randomly then ensure pageup/down functionality works correctly.

Blocked by ether/etherpad-lite#4622

Export will cause abiword to crash

I had a temp fix in place but it wasn't async, see ether/etherpad-lite#2494

ep_font_size/static/css/iframe.css bug

I found your source a small bug.

ep_font_size/static/css/iframe.css

fs8{font-size:8px}; // -> fs8{font-size:8px;}
fs9{font-size:9px}; // -> fs9{font-size:9px;}
fs10{font-size:10px;}
fs11{font-size:11px;}
fs12{font-size:12px;}
fs13{font-size:13px;}
fs14{font-size:14px;}
fs15{font-size:15px;}
fs16{font-size:16px;}
fs17{font-size:17px;}
fs18{font-size:18px;}
fs19{font-size:19px;}
fs20{font-size:20px;}

this problem cause the font8, font9 is not wowrking.
Thanks.

problem with setHTML and getHTML

We use an external data source for our documents and use etherpad for collaborative editing. In order to integrate etherpad into our system we are planning to use the etherpad apis to create a pad and set the content using the setHTML api and once done use the getHTML to capture the content and save it back to our system. The problem we are running into the styles are not honored on the setHTML. On the other side the getHTML does not return the styles and therefore making the result HTML useless for use in other HTML based clients. I noticed that doing a HTML export from the etherpad client returns the styles which is not the case for the getHTML. I am using the font size as an example but there are other formatting and styling requirements that we must maintain as we bring in/out documents to and from etherpad. What are we missing or doing wrong to avoid these issues?

Thank you
Shawn

ether / ep_font_size Goto Github PK

ep_font_size's People

Stargazers

Watchers

Forkers

ep_font_size's Issues

Recommend Projects

Recommend Topics

Recommend Org