Comments (6)
Thanks for the fix @prometheansacrifice !
Writing tests for this will be a little tricky since the cygwin binaries are already on the path when run in the test environment.
This is because we run the tests via esy b dune runtest
? So the paths already get included by esy
?
One alternative would be to continue using node/javascript for our tests - we could run those outside of the esy sandbox. We'd just have to change the way that we invoke esy-bash - using our executable instead of the JS script.
Another option would be that we could run the built Reason test_runner executable outside of the esy sandbox.
Or perhaps it makes sense to have two classes of tests - inline unit tests (Reason), end-to-end tests (Node runner)?
from esy-bash.
Weird. Works fine here.
c:\Users\manas\development\esy-bash\re>.\_build\default\bin\EsyBash.exe ls
_build appveyor.yml dune-project esy-bash.opam lib package.json
_esy bin esy-bash.install esy.lock.json node_modules tests
Infact thats how I used to make sure it was working. Nevertheless, looking into it.
from esy-bash.
Turnout it was because of cygwin on my path that didn't let me know of this issue.
from esy-bash.
Turnout it was because of cygwin on my path that didn't let me know of this issue.
Oh interesting, so it picked up the other cygwin install - thanks for the help with this @prometheansacrifice !
from esy-bash.
Writing tests for this will be a little tricky since the cygwin binaries are already on the path when run in the test environment.
from esy-bash.
Thanks for the fix, @prometheansacrifice ! Verified it works now (and we have integrated esy-bash
native with master
on esy!
from esy-bash.
Related Issues (16)
- Investigate even more silent installation HOT 1
- Create zip / repo of packages HOT 2
- Clean up temporary files
- Ignore user's `.bash_profile` HOT 1
- Convert to native reason executable HOT 7
- Native EsyBash: Enable remaining tests HOT 1
- First run of esy-bash has extraneous output HOT 4
- Run tests against installed package HOT 3
- Performance: 'asyncify' postinstall tasks
- Reduce verbosity of logging of postinstall tasks
- Investigate using gow instead of cygwin HOT 1
- Bug: 'cd: too many arguments' if path has spaces
- Can't install esy on github action HOT 2
- New release? HOT 1
- MinGW gcc vs gcc? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from esy-bash.