Giter Club home page Giter Club logo

Comments (6)

bryphe avatar bryphe commented on July 18, 2024 1

Thanks for the fix @prometheansacrifice !

Writing tests for this will be a little tricky since the cygwin binaries are already on the path when run in the test environment.

This is because we run the tests via esy b dune runtest? So the paths already get included by esy?

One alternative would be to continue using node/javascript for our tests - we could run those outside of the esy sandbox. We'd just have to change the way that we invoke esy-bash - using our executable instead of the JS script.

Another option would be that we could run the built Reason test_runner executable outside of the esy sandbox.

Or perhaps it makes sense to have two classes of tests - inline unit tests (Reason), end-to-end tests (Node runner)?

from esy-bash.

ManasJayanth avatar ManasJayanth commented on July 18, 2024

Weird. Works fine here.

c:\Users\manas\development\esy-bash\re>.\_build\default\bin\EsyBash.exe ls
_build  appveyor.yml  dune-project      esy-bash.opam  lib           package.json
_esy    bin           esy-bash.install  esy.lock.json  node_modules  tests

Infact thats how I used to make sure it was working. Nevertheless, looking into it.

from esy-bash.

ManasJayanth avatar ManasJayanth commented on July 18, 2024

Turnout it was because of cygwin on my path that didn't let me know of this issue.

from esy-bash.

bryphe avatar bryphe commented on July 18, 2024

Turnout it was because of cygwin on my path that didn't let me know of this issue.

Oh interesting, so it picked up the other cygwin install - thanks for the help with this @prometheansacrifice !

from esy-bash.

ManasJayanth avatar ManasJayanth commented on July 18, 2024

Writing tests for this will be a little tricky since the cygwin binaries are already on the path when run in the test environment.

from esy-bash.

bryphe avatar bryphe commented on July 18, 2024

Thanks for the fix, @prometheansacrifice ! Verified it works now (and we have integrated esy-bash native with master on esy! 🎉 )

from esy-bash.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.