Comments (7)
@ulrikstrid and @bryphe Can I take this one up? I'll definitely need help and will not hesitate to reach out to you guys. This is only if it can wait, because it might take me some time :)
from esy-bash.
Is it this file: bin/esy-bash.js
?
from esy-bash.
@ulrikstrid I think all the js (index.js, bash-exec etc) need to be converted to reason so that we can avoid node's overhead.
from esy-bash.
@prometheansacrifice - would love to have help with this! 💯 Thanks for offering to pick it up. It will be a significant perf improvement for esy
on Windows, because esy-bash
is called quite a bit, and every time we pay a node start-up tax today.
It'd also be a neat example to show users how they can use Reason to speed up their tools.
Keep us posted if you need anything!
from esy-bash.
@prometheansacrifice Iv'e done some conversions before so feel free to ask here or on Discord if you have any questions. I'm strid#4430 on Discord.
@bryphe I guess this needs a minimal esy
setup for it to work, is that something you want to setup or is that part of the PR?
from esy-bash.
Yes, exactly, we'd need to convert both the index.js
and bash-exec.js
. We're lucky that we only need to really compile this for one platform.
There's also a few tests that directly call bashExec
and toCygPath
, like these ones:
https://github.com/bryphe/esy-bash/blob/e1e81e772fb006faf32549daa9fca13cc1653c8d/__tests__/all-platforms/esy-bash-tests.js#L78
It'd make sense to refactor these to call via spinning up the process instead (like esyBashRun
: https://github.com/bryphe/esy-bash/blob/e1e81e772fb006faf32549daa9fca13cc1653c8d/__tests__/all-platforms/esy-bash-tests.js#L109), since we won't have those functions anymore once we convert the code to a native executable.
from esy-bash.
This is now complete thanks to @prometheansacrifice 's awesome contribution in #19 🎉
from esy-bash.
Related Issues (20)
- Investigate even more silent installation HOT 1
- Create zip / repo of packages HOT 2
- Clean up temporary files
- Ignore user's `.bash_profile` HOT 1
- Native EsyBash: Enable remaining tests HOT 1
- Native EsyBash: 'ls' command doesn't work HOT 6
- First run of esy-bash has extraneous output HOT 4
- Run tests against installed package HOT 3
- Performance: 'asyncify' postinstall tasks
- Reduce verbosity of logging of postinstall tasks
- Investigate using gow instead of cygwin HOT 1
- Bug: 'cd: too many arguments' if path has spaces
- Can't install esy on github action HOT 2
- New release? HOT 1
- MinGW gcc vs gcc? HOT 3
- Occasional syntax errors in the temp sh file
- Why does Cygwin touch Windows registry?
- Try esy-bash as an optional dependency in esy
- Way around path translations and /cygdrive mounting
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from esy-bash.