Convert to native reason executable about esy-bash HOT 7 CLOSED

@ulrikstrid and @bryphe Can I take this one up? I'll definitely need help and will not hesitate to reach out to you guys. This is only if it can wait, because it might take me some time :)

from esy-bash.

Is it this file: bin/esy-bash.js?

from esy-bash.

@ulrikstrid I think all the js (index.js, bash-exec etc) need to be converted to reason so that we can avoid node's overhead.

from esy-bash.

@prometheansacrifice - would love to have help with this! 💯 Thanks for offering to pick it up. It will be a significant perf improvement for esy on Windows, because esy-bash is called quite a bit, and every time we pay a node start-up tax today.

It'd also be a neat example to show users how they can use Reason to speed up their tools.

Keep us posted if you need anything!

from esy-bash.

@prometheansacrifice Iv'e done some conversions before so feel free to ask here or on Discord if you have any questions. I'm strid#4430 on Discord.

@bryphe I guess this needs a minimal esy setup for it to work, is that something you want to setup or is that part of the PR?

from esy-bash.

Yes, exactly, we'd need to convert both the index.js and bash-exec.js. We're lucky that we only need to really compile this for one platform.

There's also a few tests that directly call bashExec and toCygPath, like these ones:
https://github.com/bryphe/esy-bash/blob/e1e81e772fb006faf32549daa9fca13cc1653c8d/__tests__/all-platforms/esy-bash-tests.js#L78

https://github.com/bryphe/esy-bash/blob/e1e81e772fb006faf32549daa9fca13cc1653c8d/__tests__/windows/toCygwinPath-tests.js#L7

It'd make sense to refactor these to call via spinning up the process instead (like esyBashRun: https://github.com/bryphe/esy-bash/blob/e1e81e772fb006faf32549daa9fca13cc1653c8d/__tests__/all-platforms/esy-bash-tests.js#L109), since we won't have those functions anymore once we convert the code to a native executable.

from esy-bash.

This is now complete thanks to @prometheansacrifice 's awesome contribution in #19 🎉

from esy-bash.