Part of the workflow for developing a range card is identifying the "dead space," area that is not visible to the firing position.

Currently, the user can sketch out the dead space, but it would be much easier and accurate to provide a tool that does that automatically.

RlosRangeFan.py needs to be updated for arcpy.mapping for Pro
Lines 384 to 401 are affected:

    sourceLayer = arcpy.mapping.Layer(layerSymLocation + "\Radial Line Of Sight Output With Range Fans.lyr")
    sourceLayer.name= os.path.basename(outFeature)
    # Grab the MXD and Dataframe
    mxd = arcpy.mapping.MapDocument('CURRENT')
    df = arcpy.mapping.ListDataFrames(mxd)[0]
    # Create the new layer from the output data
    layerToAdd = arcpy.mapping.Layer(outFeature)
    layerToAdd.name = os.path.basename(outFeature)
    # Configure and turn on labeling - this has to be done manually because the layer file's labeling specs are ignored
    layerToAdd.showLabels = True
    if layerToAdd.supports("LABELCLASSES"):
        for lblclass in layerToAdd.labelClasses:
            lblclass.showClassLabels = True
            lblclass.expression = "\"Range: \" & [Range] & \" m\" & vbcrlf & \"Bearing: \" & [Bearing] & \" deg.\" & vbcrlf & \"Model: \" & [Model]"
    layerToAdd.showLabels = True
    arcpy.ApplySymbologyFromLayer_management(layerToAdd, sourceLayer)
    #    Add the layer
    arcpy.mapping.AddLayer(df, layerToAdd, "AUTO_ARRANGE")

@nfeuerstein @conklinbd
With a lot of the recent issues with Web Mercator, should we start removing it from use in our scripts as well? I found that Point Of Origin uses it internally in the script. To remove it would require us to replace it with something else (e.g. localized Azimuthal Equidistant like we did for Radial Line Of Sight). Thoughts?

1. Under "Data Requirements" on page 5 for MAoT for 10.1 states...
   Operational Environment sample data.
   ▪ Download from www.ArcGIS.com, search for 'operational environment'
   ▪ The MAoT template requires the Operational Environment (OE) to be completed. The Operational Environment geodatabases are where MAoT gets input data and publishes analytic results.
2. Why isn't there a hyperlink to the Operational Environment template that produces and/or contains the prerequisite data for MAoT?
3. Searched for "Operational Environment" in ArcGIS Online and the searched returned zero results with the title. The first and most recent search result is for the Military Aspects of Terrain (MAoT) template that I'm already attempting to use.
4. After going in circles for awhile I realized there is a hyperlink to download the Operational Environment sample data on the item page for MAoT. Why not make the data part of the download if it's required for the template?

There was a problem with windows not finding the path to the toolboxes.

I was able to get it working on my machine by changing the first line of code (commented out) to the second.

toolboxPath = os.path.dirname(os.path.dirname(arcpy.env.workspace)) + "\toolboxes\ClearingOperations.tbx"

toolboxPath = os.path.dirname(arcpy.env.workspace) + "\toolboxes\ClearingOperations.tbx"

arcpy.ImportToolbox(toolboxPath, "VillageClearing")

arcpy.ImportToolbox(toolboxPath, "ClearingOperations")
...........................
...........................

Also fixed references to the .lyr file at the end of the script.

symbologyPath = os.path.abspath(os.path.join(os.path.dirname(arcpy.env.workspace), os.pardir)) + "\data\Layers\GRG.lyr"

symbologyPath = os.path.dirname(arcpy.env.workspace) + "\data\Layers\GRG.lyr"

Need README files for each folder:
common
environment
emergencymanagement
analysis
operations
planning

The Patrol Data Capture Toolbox needs to have tests created for all of the tools. This toolbox has a large number of script tools.

So the following 5 tools do NOT have tests:

• Append Tracks to DB
• Import Patrol Rpt --- Not a great tool name
• Make Track Lines
• Recalculate Delta Times
• Rejoin Track Parts

• analysis\Sun Position Analysis Tools
• analysis\PointOfOrigin
• analysis\Incident Analysis Tools
• analysis\Helicopter Landing Zone
• analysis\ClearingOperations
• analysis\AdjustSampleDataDates
• common\Position Analysis Tools
• common\Range Card Tools
• environment\Geonames Tools
• environment\Imagery Basemap Tools
• environment\Maritime Decision Aid Template --- alias is bad, too long and must not contain spaces
• environment\Scanned Map Basemap Tools
• environment\Topographic Basemap Tools

GeoNames still fails when building locator from Afghanistan (af.txt) data, though it works for French (fr.txt). Fails around 240,000 features.

ClearingOperations tools needs test written for the following tools:

• Canvas Area GRG
• Number Features
• Point Target GRG

I was not able to run the ERGbyPlacard tool locally. I got this error message:

Executing: ERGByPlacard "Feature Set" 1994 115 Day Large F:\temp\emergency-response-guidebook-toolbox-master\results.gdb\ERGByPlacardpoly F:\temp\emergency-response-guidebook-toolbox-master\results.gdb\ERGByPlacardline
Start Time: Wed Oct 16 07:21:37 2013
Running script ERGByPlacard...
Getting the projected point
Found Iron pentacarbonyl
Initial Isolation Distance = 400.0 meters
Protective Action Distance = 4800.0 meters

Traceback (most recent call last):
File "", line 337, in execute
File "F:\temp\emergency-response-guidebook-toolbox-master\emergency-response-guidebook-toolbox-master\toolboxes\scripts\ERG.py", line 119, in MakeERGFeatures
sr = pProjectedPointGeometry.spatialReference
AttributeError: 'NoneType' object has no attribute 'spatialReference'

Failed to execute (ERGByPlacard).
Failed at Wed Oct 16 07:21:39 2013 (Elapsed Time: 2.58 seconds)

Need to import tools and test from MAoW repo into this one...
https://github.com/ArcGIS/military-aspects-of-weather-toolbox

Runnning ANT in ..\environment\test and getting the error:

`test_config:

BUILD FAILED
C:\Workspace\GitHubTesting\defense-and-intel-toolbox\environment\test\build.xml:14: The following error occurred while e
xecuting this line:
C:\Workspace\GitHubTesting\defense-and-intel-toolbox\environment\test\test_build_elevation\build.xml:18: Execute failed:
java.io.IOException: Cannot run program "C:\Python27\ArcGIS10.1\python.exe" (in directory "C:\Workspace\GitHubTesting\d
efense-and-intel-toolbox\environment\test\test_build_elevation"): CreateProcess error=2, The system cannot find the file
specified`

Avi says that the script is looking for a 10.1 folder to check the version. While I DO have 10.2 installed the 10.1 folder will ALWAYS be left behind because of the .PYC files left by Python. Better than looking for a folder would be to run an ArcPy subscript using GetInstallInfo() to find the version:

http://resources.arcgis.com/en/help/main/10.1/index.html#//018v00000004000000

@nfeuerstein
A user asked about tools to work with and modify Observer features, like we used to do with Military Analyst, e.g. add required observer fields to a point dataset, etc. This could be a very easy enhancement for Visibility and Range toolbox. The tools included:

• Add Observer Fields
• Create Observers From Table
• Create Single Observer

ArcGIS Desktop 10.2 - Unit tests

TestModelRangeFan
TestModelRadialLineOfSight

are failing after a few minutes with Invalid field grid_code

Here is the failing unit test: https://github.com/ArcGIS/defense-and-intel-toolbox/blob/master/common/test/test_viz_and_range/TestModelRangeFan.py#L80

& Here is the error:

tel-toolbox\common\data\geodatabases\scratch.gdb\RasPolys visibility SHORT # # #
"Observer visibility" NULLABLE NON_REQUIRED #
[exec] Start Time: Fri Nov 22 08:47:42 2013
[exec] Adding visibility to C:\MyFiles\Github\defense-and-intel-toolbox\com
mon\data\geodatabases\scratch.gdb\RasPolys...
[exec] Succeeded at Fri Nov 22 08:47:42 2013 (Elapsed Time: 0.23 seconds)
[exec] Executing (Calculate Field (3)): CalculateField C:\MyFiles\Github\de
fense-and-intel-toolbox\common\data\geodatabases\scratch.gdb\RasPolys visibility
!grid_code! PYTHON #
[exec] Start Time: Fri Nov 22 08:47:42 2013
[exec] ERROR 000539: Invalid field grid_code
[exec] Failed to execute (Calculate Field (3)).
[exec] Failed at Fri Nov 22 08:47:42 2013 (Elapsed Time: 0.35 seconds)
[exec] Failed to execute (RangeFan).
[exec] Failed at Fri Nov 22 08:47:44 2013 (Elapsed Time: 37.78 seconds)

BUILD FAILED
C:\MyFiles\Github\defense-and-intel-toolbox\common\test\build.xml:26: The follow
ing error occurred while executing this line:
C:\MyFiles\Github\defense-and-intel-toolbox\common\test\test_viz_and_range\build
.xml:43: exec returned: -1

HLZ toolbox needs to have an automated test written for HLZ Touchdown Points. This important for automated release testing, but also so GitHub users have samples of the input data used to run the tool (they get this when they setup the tool tests, don't even have to run them).

Please update the ERG By Placard and ERG by Chemical tool to have the incident point parameter as required not optional.

Incident Point isn't a required parameter, however, so if the user runs the tool without it will proceed through validation then fail once executed.

The tool seems to be pulling some relic due to the output. No layers are selected and the tool does not rail. I have included a screen shot of the result.

PolylineToPolygon.py needs to use the ArcPy Data Access InsertCursor instead of the old InsertCursor around line 47:

outRows = arcpy.InsertCursor(outputPolygons,sr)

Data Access is for faster processing by reducing the number of fields used in creating the cursor.

Rework Raster Off-road Mobility tool validation to not hide options as this causes some issues in Pro.
Pro hides tool parameters under certain conditions (parameter disabled, etc.). However in some cases (Raster Off-road Mobility) this throws hidden errors. When this tool comes from GitHub the required parameter tables do not exist (they come with the template, not repo) so the validation throws and error. Because these tables were optional in the dialog they (and the errors) are hidden. In the dialog below the ONLY clue we have that something is wrong is when you click RUN the tool gives a message "Missing 3 required parameters"....

TowerLOS.py needs to be update for arcpy.mapping for Pro
Lines 321 to 325 are affected:

    mxd = arcpy.mapping.MapDocument('CURRENT')
    df = arcpy.mapping.ListDataFrames(mxd)[0]
    layerToAdd = arcpy.mapping.Layer(output_rlos)
    arcpy.ApplySymbologyFromLayer_management(layerToAdd, layerSymLocation + "\Radial Line Of Sight Output.lyr")
    arcpy.mapping.AddLayer(df, layerToAdd, "AUTO_ARRANGE")

Convert Coordinate Notation at 10.3 handles several additional formats from 10.1 when the Convert Coordinates tool was made for Position Analysis Tools, including:
Coordinate format of the input fields. The default is DD_2.

• DD_1—Both longitude and latitude values are in a single field. Two values are separated by a space, a comma, or a slash.
• DD_2—Longitude and latitude values are in two separate fields.
• DDM_1—Both longitude and latitude values are in a single field. Two values are separated by a space, a comma, or a slash.
• DDM_2— Longitude and latitude values are in two separate fields.
• DMS_1—Both longitude and latitude values are in a single field. Two values are separated by a space, a comma, or a slash.
• DMS_2—Longitude and latitude values are in two separate fields.
• GARS—Global Area Reference System. Based on latitude and longitude, it divides and subdivides the world into cells.
• GEOREF—World Geographic Reference System. A grid-based system that divides the world into 15-degree quadrangles and then subdivides into smaller quadrangles.
• UTM_ZONES—The letter N or S after the UTM zone number designates only North or South hemisphere.
• UTM_BANDS—The letter after the UTM zone number designates one of the 20 latitude bands. N or S does not designate a hemisphere.
• USNG—United States National Grid. Almost exactly the same as MGRS but uses North American Datum 1983 (NAD83) as its datum.
• MGRS—Military Grid Reference System. Follows the UTM coordinates and divides the world into 6-degree longitude and 20 latitude bands, but MGRS then further subdivides the grid zones into smaller 100,000-meter grids. These 100,000-meter grids are then divided into 10,000-meter, 1,000-meter, 100-meter, 10-meter, and 1-meter grids.
• SHAPE—Only available when a point feature layer is selected as input. The coordinates of each point are used to define the output format.

DD, DDM, DMS, and UTM are also valid keywords; they can be used just by typing in (on dialog) or passing the value in scripting. However, keywords with underscore and a qualifier tell more about the field values.

In some cases this is causing validation errors in the tools, which means they cannot be run.

1. It appears that the link to view the item page and download the template for "Creating Suitability" under Terrain Analysis is not accessible at solutions.arcgis.com, http://maritime-ops.maps.arcgis.com/home/item.html?id=ad9c667d26aa49e5bc7e8265cc3a54e6 The item page begins to load and then an error page is displayed "Error: You do not have permissions to access this resource."

The lines don't draw properly in 10.2.1 (build 3495). The left line seems to connect to the middle of the arc, not the egge.

AjdustSampleDataDates needs tests written for 'Change Sample Data Dates to Recent Dates' tool.

http://vjenk01.esri.com:8080/job/Daily%20Build%20-%20solutions-geoprocessing-toolbox/234/console

test_lowest_point:
[exec] Starting Test: LowestPoint
[exec] Creating New Scratch Workspace (Workaround)
[exec] Valid Object: samplePolygonArea
[exec] Valid Object: Jbad_SRTM_USGS_EROS
[exec] Valid Object: Visibility And Range Tools.tbx
[exec] Running from: C:\Program Files (x86)\Jenkins\workspace\Daily Build - solutions-geoprocessing-toolbox\common\test\test_viz_and_range
[exec] Geodatabase path: C:\Program Files (x86)\Jenkins\workspace\Daily Build - solutions-geoprocessing-toolbox\common\data\geodatabases
[exec] Input FeatureClass: C:\Program Files (x86)\Jenkins\workspace\Daily Build - solutions-geoprocessing-toolbox\common\data\geodatabases\test_inputs.gdb\samplePolygonArea
[exec] Input Feature Count: 1
[exec] ERROR: Executing: GetCount "C:\Program Files (x86)\Jenkins\workspace\Daily Build - solutions-geoprocessing-toolbox\common\data\geodatabases\test_outputs.gdb\LowestPoint"
[exec] Start Time: Mon Aug 18 20:40:08 2014
[exec] Failed to execute. Parameters are not valid.
[exec] ERROR 000732: Input Rows: Dataset C:\Program Files (x86)\Jenkins\workspace\Daily Build - solutions-geoprocessing-toolbox\common\data\geodatabases\test_outputs.gdb\LowestPoint does not exist or is not supported
[exec] Failed to execute (GetCount).
[exec] Failed at Mon Aug 18 20:40:08 2014 (Elapsed Time: 0.00 seconds)

Error code 403 returned when running the ant build - ant build extract below.

Buildfile: C:\Users\a.colby.HELYX\Documents\GitHub\solutions-geoprocessing-toolbox\build.xml

make_dirs:
[echo] Creating: ./downloaded_data

get_common_data:
[echo] Downloading common maps
[get] Getting: http://www.arcgis.com/sharing/content/items/1ab069b8ed5749c083069289151fe127/data
[get] To: C:\Users\a.colby.HELYX\Documents\GitHub\solutions-geoprocessing-toolbox\downloaded_data\defense-and-intel-analysis-toolbox-maps.zip
[get] local file date : Fri May 03 15:52:58 BST 2013
[get] http://www.arcgis.com/sharing/content/items/1ab069b8ed5749c083069289151fe127/data moved to https://ago-item-storage.s3.amazonaws.com/1ab069b8ed5749c083069289151fe127/defense-and-intel-analysis-toolbox-maps.zip?Expires=1387212375&AWSAccessKeyId=AKIAJS2Y2E72HYCOE7BA&Signature=nOIDDAEgxAHrBWtoXAtQFcfFwfQ%3D
[get] Not modified - so not downloaded
[echo] Unzipping common maps
[unzip] Expanding: C:\Users\a.colby.HELYX\Documents\GitHub\solutions-geoprocessing-toolbox\downloaded_data\defense-and-intel-analysis-toolbox-maps.zip into C:\Users\a.colby.HELYX\Documents\GitHub\solutions-geoprocessing-toolbox\common
[echo] Downloading common data
[get] Getting: http://www.arcgis.com/sharing/content/items/b818862d16b0425a85e66747874f3a16/data
[get] To: C:\Users\a.colby.HELYX\Documents\GitHub\solutions-geoprocessing-toolbox\downloaded_data\defense-and-intel-analysis-toolbox-data.zip
[get] local file date : Tue May 07 22:16:58 BST 2013
[get] http://www.arcgis.com/sharing/content/items/b818862d16b0425a85e66747874f3a16/data moved to https://ago-item-storage.s3.amazonaws.com/b818862d16b0425a85e66747874f3a16/defense-and-intel-analysis-toolbox-data.zip?Expires=1387212376&AWSAccessKeyId=AKIAJS2Y2E72HYCOE7BA&Signature=OArTPk7U8RQEHLhbOpXx0nCVjh0%3D
[get] Not modified - so not downloaded
[echo] Unzipping common data
[unzip] Expanding: C:\Users\a.colby.HELYX\Documents\GitHub\solutions-geoprocessing-toolbox\downloaded_data\defense-and-intel-analysis-toolbox-data.zip into C:\Users\a.colby.HELYX\Documents\GitHub\solutions-geoprocessing-toolbox\common
[echo] Downloading publishable tasks data
[get] Getting: http://www.arcgis.com/sharing/content/items/92e0592d385e471d8216823f9844182e/data
[get] To: C:\Users\a.colby.HELYX\Documents\GitHub\solutions-geoprocessing-toolbox\downloaded_data\PublishableTasksData.gdb.zip
[get] Error opening connection java.io.IOException: Server returned HTTP response code: 403 for URL: http://www.arcgis.com/sharing/content/items/92e0592d385e471d8216823f9844182e/data
[get] Error opening connection java.io.IOException: Server returned HTTP response code: 403 for URL: http://www.arcgis.com/sharing/content/items/92e0592d385e471d8216823f9844182e/data
[get] Error opening connection java.io.IOException: Server returned HTTP response code: 403 for URL: http://www.arcgis.com/sharing/content/items/92e0592d385e471d8216823f9844182e/data
[get] Can't get http://www.arcgis.com/sharing/content/items/92e0592d385e471d8216823f9844182e/data to C:\Users\a.colby.HELYX\Documents\GitHub\solutions-geoprocessing-toolbox\downloaded_data\PublishableTasksData.gdb.zip

This tool throws an error when running due to a Python version issue (!grid_code! vs. !gridcode!). @mfunk is aware.

Ant files grab public data from several different AGOL accounts - we'll combine these so they are in one place account & organize the AGOL folders so it is easier to tell which Github repo relies on the data,

Can we please add default values for all parameters (expect incident point) ?

The ERG tools are used in the COP, the previous version had default values for all the parameters (except incident point). Because this is a primarily a ArcGIS Server workflow and it is required to have the tools in ArcGIS Desktop publish successfully first before pushing to server, having default parameter saves clicks, time, and documentation.

TowerRangeFan.py needs to be updated for arcpy.mapping for Pro
Lines 392 - 409 are affected.

    sourceLayer = arcpy.mapping.Layer(layerSymLocation + "\Radial Line Of Sight Output With Range Fans.lyr")
    sourceLayer.name= os.path.basename(outFeature)
    # Grab the MXD and Dataframe
    mxd = arcpy.mapping.MapDocument('CURRENT')
    df = arcpy.mapping.ListDataFrames(mxd)[0]
    # Create the new layer from the output data
    layerToAdd = arcpy.mapping.Layer(outFeature)
    layerToAdd.name = os.path.basename(outFeature)
    # Configure and turn on labeling - this has to be done manually because the layer file's labeling specs are ignored
    layerToAdd.showLabels = True
    if layerToAdd.supports("LABELCLASSES"):
        for lblclass in layerToAdd.labelClasses:
            lblclass.showClassLabels = True
            lblclass.expression = "\"Range: \" & [Range] & \" m\" & vbcrlf & \"Bearing: \" & [Bearing] & \" deg.\" & vbcrlf & \"Model: \" & [Model]"
    layerToAdd.showLabels = True
    arcpy.ApplySymbologyFromLayer_management(layerToAdd, sourceLayer)
    #    Add the layer
    arcpy.mapping.AddLayer(df, layerToAdd, "AUTO_ARRANGE")

Range Fan tool in Visibility and Range passes RADIUS2 and OFFSETA to the target observer for VIEWSHED, but it does NOT pass any other variables. This is a problem with overlapping range fans where the bearing limits of one may not be correctly transferred to the other (see screenshot below). We need to account for (and use the defaults) for the others including RADIUS1 = 0.0, VERT1 = 90.0, VERT2 = -90.0, OFFSETB = 0.0. But for AZIMUTH1 and AZIMUTH2 we need to calculate from the central bearing and traversal.

Need to start using releases to mark compatible ArcGIS versions

Issue in ERG by Chemical and ERG by Placard

Accepting the default of 0 for wind bearing gives the error below.

Please update the script to recognize the default parameter for wind bearing.

(if you click on the Wind Bearing, parameter text box before executing the tool will not fail)

Tool does not run when applied to test data from Jalalabad data. Here is the error:

Executing: IncidentHotSpots "Incidents\All Incidents" Districts C:\Users\lyle6003\Desktop\Working\data\Results.gdb\HotSpots
Start Time: Wed Jul 30 08:51:00 2014
Executing (Optimized Hot Spot Analysis): OptimizedHotSpotAnalysis "Incidents\All Incidents" C:\Users\lyle6003\Desktop\Working\data\Results.gdb\HotSpots # COUNT_INCIDENTS_WITHIN_FISHNET_POLYGONS Districts # #
Start Time: Wed Jul 30 08:51:00 2014
Running script OptimizedHotSpotAnalysis...
Failed script OptimizedHotSpotAnalysis...

Traceback (most recent call last):
File "c:\program files (x86)\arcgis\desktop10.3\ArcToolbox\Scripts\OptimizedHotSpotAnalysis.py", line 999, in
setupOptHotSpot()
File "c:\program files (x86)\arcgis\desktop10.3\ArcToolbox\Scripts\OptimizedHotSpotAnalysis.py", line 250, in setupOptHotSpot
"NEW_SELECTION")
File "C:\Program Files (x86)\ArcGIS\Desktop10.3\ArcToolbox\Scripts\SSUtilities.py", line 442, in innerFunction
returnValue = functionName(_args, *_kw)
File "c:\program files (x86)\arcgis\desktop10.3\arcpy\arcpy\management.py", line 6996, in SelectLayerByLocation
raise e
ExecuteError: Failed to execute. Parameters are not valid.
ERROR 000840: The value is not a Feature Layer.
Failed to execute (SelectLayerByLocation).

Failed to execute (Optimized Hot Spot Analysis).
Failed at Wed Jul 30 08:51:03 2014 (Elapsed Time: 2.84 seconds)
Failed to execute (IncidentHotSpots).
Failed at Wed Jul 30 08:51:03 2014 (Elapsed Time: 2.93 seconds)

GDB here: https://github.com/ArcGIS/defense-and-intel-toolbox/tree/master/emergencymanagement/toolboxes/tooldata/Templates.gdb

gdbs can’t be managed in a Configuration Management systems, but in general data should be pulled down separately and put in a data folder
defense-and-intel-toolbox\emergencymanagement\data

Maritime Decision Aid Tools need tests written for the following tools:

• Distance Of Horizon
• Farthest On Circle

Helicopter Landing Zone toolbox needs alias and description

Using the "Canvas GRG" tool in the Clearing Operations Template with WGS 1984 for the data layers and data frame over Boston, MA. Input AO equals 1.4 mile square but the output produces a single grid square (A1) with 4,600 mile diameter: Boston to the Black Sea. Changed AO feature class input projection to WGS 1984 Web Merc and the tools worked as designed.

┆Issue is synchronized with this Asana task

Range Fan tool was replaced by Range Fans From Weapon Bearing Limits and Range Fans from Weapon Bearing Parameters. The tool tests need to be updated as the tool no longer exists.

test_range_fan:
     [exec] Starting Test: RangeFans
     [exec] Creating New Scratch Workspace (Workaround)
     [exec] Valid Object: sampleRangePoints
     [exec] Valid Object: Jbad_SRTM_USGS_EROS
     [exec] Valid Object: Visibility and Range Tools.tbx
     [exec] Running from: C:\Users\matt2542\Documents\GitHub\solutions-geoprocessing-toolbox\common\test\test_viz_and_range
     [exec] Geodatabase path: C:\Users\matt2542\Documents\GitHub\solutions-geoprocessing-toolbox\common\data\geodatabases
     [exec] Input FeatureClass: C:\Users\matt2542\Documents\GitHub\solutions-geoprocessing-toolbox\common\data\geodatabases\default.gdb\sampleRangePoints
     [exec] Input Feature Count: 3
     [exec] ERROR: PYTHON ERRORS:
     [exec] Traceback info:
     [exec]   File "./TestModelRangeFan.py", line 80, in RunTest
     [exec]     arcpy.RangeFan_VandR(inputPointsFC, maximumRange, bearing, traversal, inputSurface, outputRangeFansFC, outputRangeVizFC, oberverHeight)
     [exec]
     [exec] Error Info:
     [exec] 'module' object has no attribute 'RangeFan_VandR'
     [exec] ERROR: ArcPy ERRORS:
     [exec] Executing: GetCount C:\Users\matt2542\Documents\GitHub\solutions-geoprocessing-toolbox\common\data\geodatabases\default.gdb\sampleRangePoints
     [exec] Start Time: Mon Aug 11 16:01:14 2014
     [exec] Row Count = 3
     [exec] Succeeded at Mon Aug 11 16:01:14 2014 (Elapsed Time: 0.04 seconds)
     [exec]

BUILD FAILED
C:\Users\matt2542\Documents\GitHub\solutions-geoprocessing-toolbox\common\test\build.xml:26: The following error occurred while executing this line:
C:\Users\matt2542\Documents\GitHub\solutions-geoprocessing-toolbox\common\test\test_viz_and_range\build.xml:49: exec returned: -1

A screenshot is needed

The test steps in the readme are not correct (need to add the additional folder paths/tests)

Currently the existing Build Elevation Mosaics tool builds a mosaic dataset in Web Mercator.

We need to start using Geographic WGS 1984 for this dataset.

Incident Analysis tool Find Hot Spot by Area will not run properly at 10.1 if there is no data present in each area in the polygon. Tool makes ArcMap crash if this happens.

Maritime Decision Aid Tools need test to be written

Tool tests need to be written for all GP tools in GitHub.
test info starts in the Team Notebook in OneNote: Team Notebook >> GitHub (tab) >> Testing Standards - Test Drivers

Currently there are only two tools:

• Distance Of Horizon
• Farthest On Circle

Copied from original issue: Esri/ops-server-config#196 and assigning to @jfrygeo

┆Issue is synchronized with this Asana task

I successfully published the Range Fan service (Visibility and Range Tools.tbx\Range Fan tool). However, the Range Fan geoprocessing service cannot be run. In ArcGIS Server log, it says:

PYTHON ERRORS: Traceback info: File "C:\arcgisserver\directories\arcgissystem\arcgisinput\RangeFan.GPServer\extracted\v101\toolboxes\RangeFan.py", line 91, in shapefieldname = arcpy.Describe(prjInFeature).ShapeFieldName Error Info: "c:\arcgisserver\directories\arcgisjobs\rangefan_gpserver\ja4e234d0a9934efaa82727afdb487f03\scratch\prjInFeature" does not exist ArcPy ERRORS: Executing: Project c:\arcgisserver\directories\arcgisjobs\rangefan_gpserver\ja4e234d0a9934efaa82727afdb487f03\scratch\scratch.gdb\obs c:\arcgisserver\directories\arcgisjobs\rangefan_gpserver\ja4e234d0a9934efaa82727afdb487f03\scratch\prjInFeature PROJCS['WGS_1984_Web_Mercator_Auxiliary_Sphere',GEOGCS['GCS_WGS_1984',DATUM['D_WGS_1984',SPHEROID['WGS_1984',6378137.0,298.257223563]],PRIMEM['Greenwich',0.0],UNIT['Degree',0.0174532925199433]],PROJECTION['Mercator_Auxiliary_Sphere'],PARAMETER['False_Easting',0.0],PARAMETER['False_Northing',0.0],PARAMETER['Central_Meridian',0.0],PARAMETER['Standard_Parallel_1',0.0],PARAMETER['Auxiliary_Sphere_Type',0.0],UNIT['Meter',1.0]] # PROJCS['WGS_1984_Web_Mercator_Auxiliary_Sphere',GEOGCS['GCS_WGS_1984',DATUM['D_WGS_1984',SPHEROID['WGS_1984',6378137.0,298.257223563]],PRIMEM['Greenwich',0.0],UNIT['Degree',0.0174532925199433]],PROJECTION['Mercator_Auxiliary_Sphere'],PARAMETER['False_Easting',0.0],PARAMETER['False_Northing',0.0],PARAMETER['Central_Meridian',0.0],PARAMETER['Standard_Parallel_1',0.0],PARAMETER['Auxiliary_Sphere_Type',0.0],UNIT['Meter',1.0]],VERTCS['WGS_1984',DATUM['D_WGS_1984',SPHEROID['WGS_1984',6378137.0,298.257223563]],PARAMETER['Vertical_Shift',0.0],PARAMETER['Direction',1.0],UNIT['Meter',1.0]] Start Time: Mon Jul 21 13:10:13 2014 Succeeded at Mon Jul 21 13:10:13 2014 (Elapsed Time: 0.12 seconds) Failed to execute (sourceRangeFan). Failed to execute (RangeFan). Failed to execute (Range Fan).

TowersLOS.py needs to be updated for arcpy.mapping for Pro.
Currently lines 286 to 290:

mxd = arcpy.mapping.MapDocument('CURRENT')
df = arcpy.mapping.ListDataFrames(mxd)[0]
layerToAdd = arcpy.mapping.Layer(thisOutputFeatureClass)
arcpy.ApplySymbologyFromLayer_management(layerToAdd, layerSymLocation + "\Radial Line Of Sight Output.lyr")
arcpy.mapping.AddLayer(df, layerToAdd, "AUTO_ARRANGE")