From @lfunkhouser on October 3, 2017 16:48

From @lfunkhouser on October 2, 2017 15:24

This issue is used to transfer issues to another repo

Copied from original issue: Esri/solutions-grg-widget#119

Copied from original issue: Esri/solutions-geoevent-java#79

From @topowright on December 15, 2017 9:8

Context

Problem, Idea, or Engagement

Possible solution or next step

Copied from original issue: ArcGIS/solutions-defense#532

Having a jenkins file here will allow us to build Military Tools using a pipeline approach with all of the build code saved and tracked via Github.

• become admin on repo
• create jenkins file on the root directory
• enable Service Hooks on the repo for Jenkins
• configure pipeline to pull jenkins file
• write logic to copy documentation to test jenkins file

Scenario: My G3 planner comes in and requests for a map of field artillery locations with at the following locations:
38SKF5432252450
38SKF6679518706
38SKF9451726142
38SKF9158739314
38SKF8009823749
Then come in to add another point that is being planned. I go to add this point manually to my previously made product.
Workflow steps:

1. Add my map background (AGC Common Map Background (CMB)) raster catalog
   2 Zoom to locations
2. Input button

Expected Behavior

My point should be added to the map.

Current Behavior

Add-in does not recongize the layer in my map as a basemap. Receives error "Missing Layer" Please add a basemap or a layer to the map.
Direct input works but interactive does not.

But after the raster catalog is converted to a raster dataset it works properly.

Steps to Reproduce (for bugs)

Your Environment

Version: ArcMap 10.6.1
Data: Army Geospatial Center Common Map Background

Add the tag #Military-Tools-for-ArcGIS to the README.

FYI @topowright

If you follow any of the links on the release page here:

https://github.com/Esri/military-tools-desktop-addins/wiki/Releases#version-10

You are directed to the dev branch not the master branch which contains the released version.

This could be confusing for the user as they may accidentally end up downloading a version that is incomplete as work is still in progress or not tested.

I think this link should point to the master branch.

Attempting to build ArcMap addins on ArcMap/ArcObjects SDK 10.6 results in error: "Unable to create .esriAddin; missing ESRI ArcGIS Add-in SDK component(s)."

Ex:
ArcMapAddinDistanceAndDirection\ArcMapAddinDistanceAndDirection.csproj(241,5): warning : Unable to create .esriAddin; missing ESRI ArcGIS Add-in SDK component(s).

Reason:

The project is looking for the original name for this file which was ESRI.ArcGIS.AddIns.11.targets and it has been changed (again) to ESRI.ArcGIS.AddIns.targets

Note: this is similar (but reversed) to the problem building on 10.3 discussed here: https://community.esri.com/thread/118989)

Workaround:

To workaround this problem, go to the %MSBuildExtensionsPath% folder:

VS2017 : C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\MSBuild
VS2015: C:\Program Files (x86)\MSBuild\Esri

Copy ESRI.ArcGIS.AddIns.targets -> ESRI.ArcGIS.AddIns.11.targets

@kgonzago - FYI

Switching ArcGIS Pro 1.4+ to Dark Theme in options cause visibility issues with some UI elements:

Issue to capture all dark theme issues in ArcGIS Pro 1.4+ - add a line/check box for any issues encountered (starting with issue list from previous repo):

Military Tools for ArcGIS Toolbar

• None

Coordinate Conversion

• Dark and White Backgrounds mixed in Text/Combo Boxes (See: 2: Below)

Distance and Direction

• Label Text that is hard to read (See 1: Below)
• Dark and White Backgrounds mixed in Text/Combo Boxes (See: 2: Below)

Visibility

• Label Text that is hard to read (See 1: Below)

Military Symbol Editor

• Tags

Esri UI Design guidance on this is at: https://blogs.esri.com/esri/arcgis/2017/01/30/arcgis-pro-ui-styling-with-the-pro-sdk/

Examples:

1:

2:
There are input text boxes and non-input text boxes that have both white and black backgrounds.

DEV

• Change the target version to ArcGIS Pro 2.1 for Each Pro Addin
  • Toolbar
  • CC - Esri/coordinate-conversion-addin-dotnet#479
  • DD (already done)
  • Viz - Esri/visibility-addin-dotnet#267
  • MSE - Esri/military-symbology#215

CHECKLIST

• Add statement to checklist to identify the target version is correct
  Note: rather than list a specific version step can be to just cross check against release table for releasse

ISSUE:

Currently our 3.0 built add-in shows version 2.0 should be 2.1

I'm currently testing military tools in the holistic lab and I was unaware of the fact that our ArcGIS Pro Add-In (built and tested against 1.4) was incompatible with Pro 2.0. When trying to install the Add-In, you get this error message:

If I click yes to continue with the installation, nothing happens, no military tools ribbon appears.

I would expect the Add-In to successfully install in a newer version of Pro (in this case 2.0).

Has anyone else ran into this issue or tried to use military tools in Pro 2.0?
@csmoore @kgonzago any thoughts?

To reproduce this simply grab the Add-In from our current build location and try and install it on a machine that is currently running Pro 2.0

I tested this with Pro 2.0 both in a disconnected and connected environment, and got the same result.

@nfeuerstein @lfunkhouser FYI

Esri/visibility-addin-dotnet#224

Point build to utilize new folder structure.

Military Tools 2.0 supports ArcGIS Pro 1.4, 1.4.1 and 2.0; however only 1.4 is documented in the Get Started section of the documentation.

Expected Behavior

The supported versions of ArcGIS Pro are provided under the Home tab, http://solutions.arcgis.com/defense/help/military-tools/ and should be removed from the Get Started section.

Current Behavior

The online and offline documentation states:
Military Tools for ArcGIS in ArcGIS Pro supports ArcGIS Pro 1.4.

Steps to Reproduce (for bugs)

http://solutions.arcgis.com/defense/help/military-tools/arcgis-pro/military-tools-for-arcgis-in-arcgis-pro-overview.htm
Under Get Started with Military Tools for ArcGIS in ArcGIS Pro, the documentation states: Military Tools for ArcGIS in ArcGIS Pro supports ArcGIS Pro 1.4

Your Environment

Military Tools 2.0
Documentation

I have added an image service of elevation data to my map.
(data at: http://navigator.state.or.us/arcgis/services /Framework/Elevation_DEM_10)
I can run the Military Tools Add-In LLOS tool against it and it works (two points separated by 10,000 meters).
When I run the Military Tools Add-In RLOS against it (default values 1000 m distance, 2m height), I get a message box titled "Calculation cancelled" which says "Results not calculated. Check Input parameters and try again."

Expected Behavior

I would expect the tool to use the elevation data as it would a local layer. The LLOS tool does.

Steps to Reproduce (for bugs)

Add image service of elevation data. (data at: http://navigator.state.or.us/arcgis/services /Framework/Elevation_DEM_10)
Open LLOS tab. Add two points 10,000 meters apart. Accept defaults, click OK, get correct results.
Open RLOS tab. Add single point (in my case, near the midpoint of the previous two). Accept defaults. Click OK, get error message.

Your Environment

ArcMap 10.4.1
Military Tools Add-in build 1228
(03-01-2017_1228)

Expected Behavior

The Rings functionality should account for a map set in various coordinate systems.

Current Behavior

If a map is set to Azimuthal_Equidistant and the Distance and Direction>Rings function is used some odd behavior occurs. In non-interactive mode a center point is chosen in the middle of the USA. Number of Rings=5 with a distance between rings of 100NM. The function seems to do something as it zooms in to the area but no rings are drawn. However I zoom out and the rings are drawn but in a location far from the center point that was selected.

Your Environment

• Addin Version used: June 2017 release
• Environment name and version: ArcMap 10.6
• Operating System and version: Windows 7 Enterprise x86

From @dfoll on September 12, 2017 21:53

When normal.mxt gets saved with a Military Tools window open it causes a crash when double-clicking any other saved .mxd to open.

1. Delete normal.mxt (located in C:\Users\xxxxXXXX\AppData\Roaming\ESRI\Desktop10.3\ArcMap\Templates with a typical installation)
2. Open ArcMap. Add a basemap. Save as "noMT.mxd". Close.
3. Close ArcMap. Double-click "noMT.mxd" and it opens. "noMXT.mxd" opens.
4. Add the Military Tools toolbar. Save as "MT_toolbar.mxd" and close.
5. Double-click "MT_toolbar.mxd" and it opens.
6. Save as "MT_toolbar_CCwindow.mxd", and close.
7. Double-click "MT_toolbar_CCwindow.mxd", and ArcMap crashes when it tries to open the document.
8. Open ArcMap and browse to "MT_toolbar_CCwindow.mxd" and open it, it opens fine.
9. Close "MT_toolbar_CCwindow.mxd" without saving.
10. Delete normal.mxt.
11. Double-click "MT_toolbar_CCwindow.mxd" and it opens (without the CC window or MT toolbar, because you deleted normal.mxt)
12. Add the Military Tools toolbar and open the Coordinate Conversion window.
13. Save as "MT_toolbar_CCwindow.mxd" and close.
14. Double-click "MT_toolbar_CCwindow.mxd". ArcMap closes when trying to open.
15. Open ArcMap and browse to "MT_toolbar_CCwindow.mxd" and open it, it opens fine.
16. Close the Coordinate Conversion window, and save as "MT_toolbar_CCwindow.mxd"
17. Double-click "MT_toolbar_CCwindow.mxd" to open, it opens fine.
18. Open the Distance and Direction window. Save as "MT_toolbar_DDwindow.mxd", and close.
19. Double click "MT_toolbar_DDwindow.mxd" (or any of the other .mxds created in previous steps) to open, and it crashes ArcMap.
20. Open ArcMap and browse to "MT_toolbar_DDwindow.mxd", it opens.
21. Close the Distance and Direction window and open the Visibility window, and save as "MT_toolbar_Vizwindow.mxd" and close.
22. Try double-click to open "MT_toolbar_Vizwindow.mxd" (or any of the other .mxds created in previous steps), ArcMap crashes.
23. Delete normal.mxt
24. Open any of the .mxds previously created (5 at this point) and any of them open, (without a MT window open or the Military Tools toolbar, because you deleted normal.mxt)

repro steps are from 10.3.1

Copied from original issue: ArcGIS/solutions-defense#424

We spell out KML in the document multiple times.

Expected Behavior

We need only to say this once per component. This needs to be said in the first topic of the components documentation in which the feature is mentioned.

Current Behavior

Steps to Reproduce (for bugs)

Your Environment

• Addin Version used:
• Environment name and version (e.g. ArcMap 10.3, Pro 1.4):
• Operating System and version (desktop or mobile):
• Link to your project/test data (if applicable):

Background

Currently we write features to a default database based on the project that the user is currently working in. The following addins write features:

• Visibility
• Military Symbol Editor
• Distance and Direction

Current State

Because we are writing features across multiple components to the same database there are starting to create performance problems. This is causing crashes in one addin because the other addin did not save its last edits.

Expected Results

Each time we are creating content in a addin it must also save the edits or the user might have challenges in the next addin:

Similar to Issue #44 (update target version) and PR #38 - we should update the dates for the next release (i.e. 4/XX/2018).

DEV

• Modify the Visual Studio Project file to set the addin date to %BUILD_DATE% environment variable if it is set (by Jenkins for instance) - otherwise use the system date.

QC/ CHECKLIST

• Check the release date for each:

• ArcMap Addin

  • Toolbar
  • CC
  • DD
  • Viz

• Pro Addin

  • Toolbar
  • CC
  • DD
  • Viz
  • MSE

• Add statement to checklist to identify the addin date is correct
  Note: rather than list a specific date, the step can be to just cross check against release table for release

Update the resources (ex: version and dates in Daml and addinx files) for Release:

Proposed Versions:

Version: 1.1

* - no version resources to update

Update wiki after release: https://github.com/Esri/military-tools-desktop-addins/wiki/Releases

Update: a draft release for this is on wiki here: https://github.com/Esri/military-tools-desktop-addins/wiki/Releases#version-11--june-2017

Expected Behavior

Military Tools for ArcGIS should have a build number populated based on the build number from Jenkins.
This is for ArcGIS Pro only not for ArcMap for now.
The code on how we did this for Coordinate Conversion in ArcGIS Pro is the samething we want to do for this issue:
Esri/coordinate-conversion-addin-dotnet@22fad09#diff-d9358db34019268f8ca62c22b2ef1c48R222

Current Behavior

Currently we do not have any way to identify what build is installed on ArcGIS Pro

We updated the Pro Addins versions/auto-version-setting process (ex: here, here) and the ArcMap version/auto-version-setting process for Distance and Direction - Esri/distance-direction-addin-dotnet#499 - but this same change is still needed for the remaining ArcMap addins

DEV

• Change each project to get the version from Jenkins/build environment and update the esriaddinx file - like was done for D&D in https://github.com/Esri/distance-direction-addin-dotnet/pull/505/files to address Esri/distance-direction-addin-dotnet#499

• Change the project/version in the project file for each ArcMap Addin

  • Toolbar
  • CC
  • DD (Already done in Esri/distance-direction-addin-dotnet#499 - https://github.com/Esri/distance-direction-addin-dotnet/pull/505/files
  • Viz

DEV Jenkins

• Make any necessary updates to set the version environment variables and test build

CHECKLIST

• Add statement to checklist to identify the addin version is correct
  Note: rather than list a specific version, the step can be to just cross check against release table for release

Military Tools 2.0 supports ArcMap 10.3.1-10.5.1; however only 10.3.1-10.5 is documented in the Get Started section of the documentation.

Expected Behavior

The supported versions of ArcMap are provided under the Home tab, http://solutions.arcgis.com/defense/help/military-tools/ and should be removed from the Get Started section.

Current Behavior

The online and offline documentation states:
Military Tools for ArcGIS in ArcMap supports ArcMap 10.3.1, 10.4, 10.4.1, and 10.5.

Steps to Reproduce (for bugs)

http://solutions.arcgis.com/defense/help/military-tools/arcmap/military-tools-for-arcgis-in-arcmap-overview-page.htm
Under Get Started with Military Tools for ArcGIS in ArcMap, the documentation states: Military Tools for ArcGIS in ArcMap supports ArcMap 10.3.1, 10.4, 10.4.1 and 10.5

Your Environment

Military Tools 2.0
Documentation

From @lfunkhouser on August 14, 2018 22:50

From @lfunkhouser on August 14, 2018 22:50

Copied from original issue: Esri/coordinate-conversion-addin-dotnet#515

Copied from original issue: Esri/distance-direction-addin-dotnet#622

The GP tools installed with the Pro add-in for the Military Tools button on the Analysis toolbar have "pin" symbol for input points. When you add the PYT toolbox to your Pro project and run the tools from there, they have the default blue circle input point symbol.
It seems that the tools installed by the Add-In for the Analysis toolbar cannot find the LYRX file for symbolizing the input points.

Expected Behavior

I would expect the symbology of input points from both locations to match.

Current Behavior

These tools Point input feature set symbols are affected:
GRG from Point
Range Rings from Interval
Range Rings from Min Max
Range Rings from Min Max Table
Linear Line of Sight (Observers, but not Targets) <- it might be useful to know why one works and the other does not
Radial Line of Sight
Radial Line of Sight and Range

generic blue "pin" symbols when run from Analysis ribbon

Blue circles when run from PYT:

Steps to Reproduce (for bugs)

1 .Install the Military Tools Pro Add-in.
2. Click the Analysis tab.
3. Click Military Tools.
4. Choose Linear Line of Sight (or one of the other tools with input point feature sets).
5. Observe that the input feature set symbols are blue pin markers.
6. Connect to the \MilitaryToolsforArcGIS\Geoprocessing folder in Pro.
7. Add a toolbox to your Pro project and navigate to the folder.
8. Add the Military Tools.pyt
9. Run the same tool from the PYT.
10. Notice that the input feature set symbol is a blue circle.

Your Environment

• Addin Version used: \Commercial\Solutions\DefenseSolutions\MilitaryToolsForArcGIS\December2018\172
• Environment name and version: ArcGIS Pro 2.1
• Operating System and version (desktop or mobile): Windows 8.1 Enterprise

The Conda package was NOT installed at the time.
I am still seeing it after having installed the Conda package.

I ran the LLOS tool from the Military Tools in ArcGIS Pro 1.4.1. but can't clear the graphics
Multiple inputs and outputs. Raster data in WGS 1984 UTM Zone 10N, set Map to have same coordinate system. Tool runs as expected. However, the Clear Graphics button does not become enabled. I can delete the Observer Points and Target Points from the lists using right-click > Delete All, and add new observers and targets, and the process re-runs with expected results (old locations not included) but the old output hangs around on the display. Shouldn't I be able to clear them?

I see that the tool output is added as feature layers to the Contents (though Contents are hidden behind the Visibility tab, for me), so perhaps the workflow is to just remove them, or turn them off there... but in that case, why is there a "Clear Graphics" button on the tool in the first place? Does it do anything? Maybe should be removed.

ArcGIS Pro 1.4.1
Military Tools for ArcGIS 1.0
installed on Pro1.4.1 using [server]\software\Esri\Released\ArcGISforDefense\MilitaryToolsforArcGIS1.0.zip

Tasks to be done June 13

• Add statement for licensing for each component
• Add a matrix table to Military Tools @topowright

We currently need to understand what licenses a user needs to run each part and the entire product. This needs to be done for ArcMap and ArcGIS Pro.

Expected Behavior

A user should understand by looking at one chart what they will need in order to use the product.

Current Behavior

No Chart

Steps to Reproduce (for bugs)

Your Environment

• Addin Version used:
• Environment name and version (e.g. ArcMap 10.3, Pro 1.4):
• Operating System and version (desktop or mobile):
• Link to your project/test data (if applicable):

Currently we have a python package and conda package for Military Tools. We give users the ability to install these tools as a system tool; however, we would like to create a button the analysis ribbon that gives our users the ability to find these tools in a custom button dialog drop down menu.

Current State

The gp tools live in the following repo:
https://github.com/Esri/military-tools-geoprocessing-toolbox

Crime Analysis addin is a good example of already doing this:
https://solutions.arcgis.com/local-government/help/crime-analysis/

when you hover over the button there is a tooltip with short description. Once you click the button you are presented with a list of the gp tools grouped by toolset in a gray header. The toolset does not need a description or icon, just name. Each tool has a name, icon, and short description. Icons are here. Toolsets/tools/descriptions provided here

This (Crime Analysis) must be downloaded from the Solutions Deployment Tool:
https://solutions.arcgis.com/shared/help/deployment-tool/

These tools are not accessible in a way that takes advantage of the ArcGIS Pro custom ribbons

Expected Behavior

• Add a custom button to the analysis ribbon
• Store the python package or conda package in a local directory so that the ribbon can find the tools (Possibly the assembly cache)
• If the user has the conda package for Military Tools installed allow the button to work using the Military Tools that are access like system tools
• Add the tools into their custom sections based on the tools box
• conversion
• grg
• visibility
• distance and direction
• Add custom icons for each tool
• Add description for each tool

Current Behavior

Steps to Reproduce (for bugs)

Your Environment

This will only be done for ArcGIS Pro

Current Behavior

I love this add-in!!! Love it!!! One improvement that I may suggest is to make the auto zoom an option. Often we are working on a big area of the map and want to see what a range ring might look like in a smaller region. Well I don't necessarily want it to auto-zoom to the graphic just created. Kind of drives me nuts. :) Please consider for next release.

~AGP

As always thank you so much for a great product!
When we generate ellipses, circles, range rings I would vote for them to be created as a polygon rather than a polyline. Quite often I need to add a fill to the ellipse and as a polyline you can't do that. I believe the reason for this was so all geometry could be saved to one feature class. I think, as a user I would not mind one feature class for polylines and one feature class for polygons. Another reason I think polygons are a good idea is that post-processing like unionization of multiple polygons is possible.

Current
The version of the add-in is 3.2.0.152

Expected
The version of the add-in should be updated to 3.3.0.

The steps that it took to add a python package at ArcGIS Pro 2.2 have changed at ArcGIS Pro 2.3

Expected Behavior

The steps need to be outlined for adding a python package at ArcGIS Pro 2.3 and previous versions. Previous versions allowed you to create a new environment via this dialog that is captured below. The add button only gives you an ability to add an existing environment. The new concept has been removed or has been moved somewhere else.

Your Environment

ArcGIS Pro 2.3 build: 15679

Our product needs to be localized for international use.

Expected Behavior

All components are localized

Current Behavior

• MSE is not localized
• Distance and DIrection is not localized

Steps to Reproduce (for bugs)

Your Environment

• Addin Version used:
• Environment name and version (e.g. ArcMap 10.3, Pro 1.4):
• Operating System and version (desktop or mobile):
• Link to your project/test data (if applicable):

List of issues to be addressed for January Release

Logging this here because I am experiencing this using the add-in, but not the toolbox.

Background

Military Tools 3.3 will provide access to our gp tools through a button on the Analysis ribbon. This is in addition to offering the same tools in a Python toolbox and a conda package. This issue is being logged specifically about the behavior from the analysis ribbon.

Current Behavior -vs- expected behavior (add-in -vs- toolbox)

Build 163 of the button on the Analysis ribbon is being compared to the tools in the Python toolbox from build 163.
At build 163 this problem seems to be happening with any tool that can use feature sets as inputs. One visual example is given, after that, only the tool name and "symptoms" are given.

Range Rings From Interval

should only be able to use points as input, also does not have correct symbol like the tool accessed directly from the .pyt

• tool executes correctly

Range Rings From Minimum and Maximum

should only be able to use points as input, also does not have correct symbol like the tool accessed directly from the .pyt

• tool executes correctly

Range Rings From Minimum and Maximum Table

should only be able to use points as input, also does not have correct symbol like the tool accessed directly from the .pyt

• tool executes correctly

Steps to Reproduce/Additional Info

1. Open Range Rings from Minimum and Maximum from Analysis ribbon
2. It opens correctly with correct feature set symbology
3. Without running anything open Range Rings from Minimum and Maximum from toolbox
4. It opens correctly with correct feature set symbology
5. Without running anything open Range Rings from Minimum and Maximum from Analysis ribbon
6. Tool now opens as described in the issue, without correct symbology.

Alternative repro steps

1. Click GRG From Area tool
2. Tool opens with correct symbology
3. Click GRG From Point tool
4. Tool opens with correct symbology
5. Click GRG From Area tool again
6. Tool opens without correctly layer file for input feature set

Your Environment

Pro 2.3.0.14508 MT build 163 (built from cybertech-dev branch.

Feb 2017 Release: Just absolutely love this add-in. I have been testing it on ArcMap 10.6 and so far so good. One thing, however, that I did notice is the requirements on the home page do not specify what license level of ArcMap is required. I think for the most part Basic is supported. But the Toolbox function "Find Local Peaks" requires a call to FeatureToPoint_management which according to the ESRI help

Licensing information
ArcGIS Desktop Basic: No
ArcGIS Desktop Standard: No
ArcGIS Desktop Advanced: Yes

The error says the appropriate license was not found and I checked to make sure that Spatial Analyst and 3D Analyst were checked. But it turns out it's the core ArcGIS License Level that caused this error.

Either way this tool is awesome! I will continue my testing.

When exporting features for users we should support a layer package that can be used in a Runtime mobile solution

Expected Behavior

Add export to layer package to all components

Current Behavior

We do not support exporting to a layer package.

Steps to Reproduce (for bugs)

Your Environment

• Addin Version used:
• Environment name and version (e.g. ArcMap 10.3, Pro 1.4):
• Operating System and version (desktop or mobile):
• Link to your project/test data (if applicable):

From @lfunkhouser on January 5, 2017 22:58

From @lfunkhouser on January 5, 2017 22:57

Copied from original issue: Esri/coordinate-conversion-addin-dotnet#224

Copied from original issue: ArcGIS/military-tools-arcmap-single-add-in_RETIRED#4

Expected Behavior

I've been trying to run Radial Line of Sight and Linear Line of Sight in Pro 2.3, but getting an error "AddSurfaceInformation_3D" when they try and run.

Current Behavior

I'm able to add inputs and click OK to start the process for both LLOS and RLOS. My elevation layer is in .tif format and projected, along with my map, in NAD 1983 StatePlane California IV Projected Coordinate System. I'm also able to reproduce with a variety of projected coordinate systems (including WGS 84 Web Mercator)

Steps to Reproduce (for bugs)

1. Open a new project with a blank map
2. Add this elevation layer to the map
3. Open the Visibility pane
4. Enter parameters for LLOS or RLOS (I've tried with multiple observers/targets and single observer/target and get the same error)
5. Click OK to run, this is when I get this error:

Your Environment

• Addin Version used: Military Tools 3.2
• Environment name and version (e.g. ArcMap 10.3, Pro 1.4): Pro 2.3 Build 14229 ICAP 2.0 beta build 580
• Operating System and version (desktop or mobile): windows 10

Currently we do not allow the user to set the symbology for graphics we draw on the map. This is true in coordinate conversion, distance and direction, visibility.

Expected Behavior

Can this be done in a way that makes sense for CC, VIS, and DD?

Current Behavior

No ability to set the output graphic types

Steps to Reproduce (for bugs)

Your Environment

• Addin Version used:
• Environment name and version (e.g. ArcMap 10.3, Pro 1.4):
• Operating System and version (desktop or mobile):
• Link to your project/test data (if applicable):

The version/target versions are incorrect for each of the Single/Component Addins (see screenshot below), these should be:

Pro:
Version: 2.0
Target Version: 1.4
Date: should probably update this also to release date

ArcMap:
Version: 1.0
Target Version: 10.3.1

(For version matrix see: https://github.com/Esri/military-tools-desktop-addins/wiki/Releases#version-10)

Example (from Pro):

Just recording this here since it effects all of the dependent add-ins:
https://github.com/Esri/coordinate-conversion-addin-dotnet
https://github.com/Esri/distance-direction-addin-dotnet
https://github.com/Esri/military-symbol-editor-addin-wpf
https://github.com/Esri/visibility-addin-dotnet

Expected Behavior

All UI updates support Dark Theme

Current Behavior

Many buttons and layouts do not support dark theme

With the latest build of Military Tools, when I install the GP tools using the Conda install package, two tools in the Visibility toolset lack feature sets for input observer points
Radial Line of Sight
Linear Line of Sight (input observers missing, targets feature set is present)

RLOS and Range does have feature set.

This was fixed for the toolbox in the repo, I think the Conda package needs to be rebuilt with the latest version of the GP tools.

Expected Behavior

Tools should have input observer points feature sets.

Your Environment

Pro 2.3.0 Beta 2
Military Tools 12/14 build.

From @kgonzago on February 2, 2018 18:28

• Review RegEx used in Coordinate Conversion Distance and Direction Widget
• Reconfigure each notation's regular expression in the add-in to mirror what's in the widget
  • DD
  • DMS
  • DDM
  • GARS
  • MGRS
  • USNG
  • UTM
• Use test json files from the widget in unit tests in add-in
  • DD
  • DMS
  • DDM
  • GARS
  • MGRS
  • USNG
  • UTM

If needed, refactor code to accommodate for new entries added to add-in regular expressions

Copied from original issue: Esri/coordinate-conversion-addin-dotnet#470

Currently I think our product hides the add-in tab

Expected Behavior

If I have other add-ins that I want to work with along with Military Tools Installed I do not have access to the Add-in ribbon

Current Behavior

I think we are hiding the add in ribbon in Military Tools

Steps to Reproduce (for bugs)

install a add in
Install Military tools and then try to access the other add in

Your Environment

• Addin Version used:
• Environment name and version (e.g. ArcMap 10.3, Pro 1.4):
• Operating System and version (desktop or mobile):
• Link to your project/test data (if applicable):

It has been decided that we are going to create a non backwards compatible version of Military Tools starting at ArcGIS Pro 2.1.

Questions

What features or bugs is making this inevitable?

The only feature that I understand that has kept us to continue building on ArcGIS Pro 2.0 is:
Esri/coordinate-conversion-addin-dotnet#460

We have been provided Dark Themed Icons (zip below) - Pro desktop addins projects should be updated to add these icons.

DarkIcons.zip

• coordinate-conversion-addin-dotnet
• distance-direction-addin-dotnet
• military-symbol-editor-addin-wpf
• visibility-addin-dotnet
• military-tools-desktop-addins

If needed there is a complete Dark Theme SDK sample

Build 1615
Military Tools Add-In version needs to be updated to 2.0 before it is released.

Adding the release pdf for Military Tools for ArcGIS to Master

Addin Version used: Feb 2017 release
Environment name and version: ArcMap 10.5.1 and 10.6
Windows 10 Enterprise x86 and x64 Desktop

We are at 10.1 currently and the only thing holding us back was the use of the Military Analyst extension. In our custom extension I have worked for a year or two to replace all MA API with core ArcGIS functionality. That part is complete but the users also quite heavily use the MA Toolbar. Mainly to draw geodesic lines and geoellipses.

I see that the Military Tools add-in has most if not all the functions from Military Analyst. I am overwhelmingly thankful for the work that has gone into this add-in. It will save me tons of time. Thanks!!! Now on to my question...does this release support ArcMap 10.6? We can upgrade to 10.5 but if the MT add-in supports 10.6 then we will make that jump.

Rgds
~AGP

While looking at the date issue I noticed that only the ArcMap Distance and Direction Addin seems to have the necessary project/code changes to get the Build Number from Jenkins:

In Distance and Direction- it was these lines of code in this Change/PR: Esri/distance-direction-addin-dotnet#505

So I would not expect the build version to be updated for:

ArcMap

• Toolbar
• Visibility
• Coordinate Conversion

ArcMap Addins until this change is made to those repos/csproj files also.

@topowright @ACueva