When using Chrome on android (Samsung Galaxy S3), the search input box doesn't cause the soft keyboard to display. I tried to "force" focus on the input control, which works for stock android browser and safari on iPad...but not for chrome on android.

Hi, I'm trying to set some options but I guess I'm doing something wrong. Here is my code.

var GeoSearchOptions = {
'useMapBounds': true,
'maxResults': 3
}

var searchControl = new L.esri.Controls.Geosearch(GeoSearchOptions).addTo(map);

Sometimes you might want to use the geocoder for functionality similar to Foursquare or Yelp, typing in "Starbucks" and getting multiple results back.

This would involve an option called allowMultipleResults which would when enter is hit without a selected result geocode the input text and limit results to the current map bounds. When geocoding is done a results event would be fired with the bounds of all results and the array of possible places.

Suggested by @alaframboise

in Geosearch, we need to instantiate a new LatLngBounds() object here to cope with Leaflet/Leaflet/issues/3408

Maybe I am missing the option, but if it does not exist it would be nice to have an option to not put a placeholder/marker at the found location. Once the location is found the placeholder does not go away until another place is found via search or the map is reloaded, so the user needs some way to either remove the placeholder/marker or just not have one at all.

I've started work on this locally. I want to refactor the geocoder to work with a variety of plug and play data providers.

The would result in a new set of classes that would be responsible for generating results and suggestions for the geosearch control namespaced under L.esri.Controls.Geosearch.Providers

• FeatureLayer - #31
• MapService - Via the new find() task.
• GeocodeService
• ArcgisOnline
• FuzeSearch - #20

How can we set multiple layers for L.esri.Geocoding.Controls.Geosearch.Providers.MapService provider?

The current developers terms of use prohibit the storage of points unless the forStorage parameter is set to true.

Unfortunately setting forStorage:true requires a token. So we need to allow setting a token on instances of the geocoder and the controls.

From the geocoding documentation...

Applications are contractually prohibited from storing the results of single geocode transactions.

However, by passing the forStorage parameter with value "true" in a geocode request, a client application is allowed to store the results

When a user clicks enter but no query is placed, should ignore the input and not run a search or display the "No results" dropdown.

I made a small edit in my own copy in the "geocode" function of the Geocoders that simply returns if (query.length == 0) that works. I'm not very familiar with using github though or the rest of the code, so I'll just mention it and leave it up to someone else to add to the on-line code if they'd like.

#75 (comment)

• actual refactor
• update samples

when the search control is configured to display more results than will fit on the screen simultaneously, it becomes noticeable that map zoom is not disabled when attempting to scroll through results.

STR:

1. search for 'wash' in this app leveraging the RC2 Geosearch Control.
2. attempt to scroll through the collection of matching results and notice that map zoom is still enabled.

you can find an app i wrote for my related records plugin that uses a bootstrap-table plugin and exhibits the desired behavior (map zoom disabled) here.

As a Developer, I would like to limit world geocoder results to a specific country (e.g. USA)

the Geocode API accepts sourceCountry=USA. so this would be an option passed into locators that would only be used by certain providers.

just realized that all the live sample links here (in the repo header and main readme) are pointing out to a esri.github.io example.

i think thats a good thing, but we should probably just get rid of the index.html (and gh-pages branch) here.

like this!

Please add this to the _geocode method so it zooms to the selected item, not all results.

_geocode: function(text, key, provider){
...
var callback = L.Util.bind(function(error, results){
activeRequests--;

  // Single selection from suggestions
  if(results && key){
    allResults = allResults.concat(results[0]);
  } else {
    allResults = allResults.concat(results);
  }

in creating a doc page for L.esri.Geocoding.geosearch i noticed some problems with the doc page in this repo's README

1. the control doesn't fire a loading event
2. the control says the load event corresponds with a request being started, but the event is actually triggered immediately before results.

seems like we either need to fix when load actually fires or drop it altogether.

we also need to make a decision about whether to duplicate the API reference for plugins in individual repo READMEs and the main esri-leaflet site or remove them from READMEs altogether. seems easiest to just remove it from here once the updates to the esri leaflet website are in place and skip managing both.

I haven't dug in to see what's going on yet, but here's how to reproduce on the demo site (tested with Chrome 35.0.1916.114 on OSX)

1. Type 94103, then press RETURN -- control will contract without zooming to a location
2. Type 94103 again (or anything else) and you'll see this:

i assume we're going to follow @ngoldman's advice here for plugins as well and make the final 0.7.3 Leaflet compatible release 1.0.0 (with no release candidate qualifier).

i was anxious to tag esri-leaflet-geocoder as soon as we'd incorporated support for 'suggest' from custom geocoding services, but perhaps i should wait until we finally see a Leaflet 1.0.0.beta1 announcement? or maybe since nothings going to change with 0.7.3 we can just get started publishing our 1.0.0 releases now?

I am using esri-leaflet-geocoder like this
" var geocoderControl = new L.esri.Controls.Geosearch({
expanded : true,
collapseAfterResult : false,
useArcgisWorldGeocoder : false,
allowMultipleResults : true,
useMapBounds : false,
});"
But when I create packaged version of my application that is its .exe or .dmg then I do not see suggested results it seems like esri-geocoder is not able to load the results.

Got errors on each result in Chrome:

Resource interpreted as Script but transferred with MIME type text/plain: "https://geocode.arcgis.com/arcgis/rest/services/World/GeocodeServer/suggest…y&f=json&callback=L.esri.Services.Geocoding._callback.c68qksx_uaqlrie2vs4i".

It is highly desirable to:
Control GeoCoding Search to be "limited to US Addresses only".
The US Addresses that I'm thinking of, would includes:
Hawaii, Alaska, the US Main Land, American Samoa, Guam, Puerto Rico/Virgin Islands, and territories like that. See http://www.weather.gov, for a map display, if needs be.

I'm sure if I was in Europe, France, and I would have wanted to filter all of my
geoSearch be limited to France, I would have asked something similar.

The attached image, shows non-desirable searches that presently would display, by default.
We would NOT have the weather information for non-US locations.

Hi, wanted to check and see if any updates were planned to support the new and depreciated functionality in ArcGIS Server 10.3 Geocode service? I'm trying to switch the plug-in from using the Esri world geocode service to a locally hosted 10.3 geocode service. Any tips?

NEW: With suggestions now available at 10.3 and I'd like to take advantage of those and plug my geocoder in as a provider while disabling the ArcGIS Online World Geocoder.

Depreciated: At 10.3 the Find operation of a Geocode service does not return an Extent, as it did in prior versions. As a result, adding a 10.3 geocode service as a provider does not work.

Thanks!

I have successfully gotten the GIS FeatureService example implemented. Now I'm implementing this on layers within a single MapService. I can get the suggestions to display 🏆 and the results callback fires. But in the results callback there are no result objects and the bounds and latlng are undefined
The code, the GIS Day Events works but the other MapService providers do not (valid urls):

var gisDay = new L.esri.Geocoding.Controls.Geosearch.Providers.FeatureLayer('https://services.arcgis.com/uCXeTVveQzP4IIcx/arcgis/rest/services/GIS_Day/FeatureServer/0', {
    searchFields: ['EventName', 'Organizati'], // Search these fields for text matches
    label: 'GIS Day Events',
    formatSuggestion: function(feature){
        return feature.properties.EventName + ' - ' + feature.properties.Organizati;
    }
});
var facilitiesProvider = new L.esri.Geocoding.Controls.Geosearch.Providers.MapService(cwns.config.mapServiceUrl, {
    layer: cwns.config.layerIndexes.facilitiesLayerIndex,
    searchFields: ['FACILITY_NAME', 'FACILITY_ID'], // Search these fields for text matches
    label: 'Facilities', // Group suggestions under this header
    formatSuggestion: function(feature){
        return feature.properties.FACILITY_NAME; // format suggestions like this.
    }
});

var searchControl = L.esri.Geocoding.Controls.geosearch({
    providers: [gisDay, facilitiesProvider],
    placeholder: "Search for facilities, counties, congressional districts, places or addresses..."
}).addTo(cwns.map);

var results = new L.LayerGroup().addTo(cwns.map);

searchControl.on('results', function(data){
    results.clearLayers();
    for (var i = data.results.length - 1; i >= 0; i--) {
        //results.addLayer(L.marker(data.results[i].latlng));
        console.log(data.results[i].toString());
    }
});

I took a stab at debugging but got as far as seeing the results: method fire but with no bounds, results, etc.

Happy to provide more input on reproducing if necessary.

Would be nice to have an option to offset where the geocoder zooms to if you have some content over the map, like an info panel.

Hey Pat, when are we going to push the provider code in? I have a bunch of fixes for the prototype.

It would be awesome to allow developers to specify a list of places that users could search.

Possible api follows...

var geocoder  = new L.esri.Controls.Geosearch().addTo(map);

geocoder.addPlaces([
  {
    name: "Cherry Lane Park"
    center: [45.65, -121.56],
    zoom: 14,
    group: "Parks"
  },
  {
    name: "Clinton Community Garden",
    bounds: [[45.65, -121.56], [46.65, -120.56]]
    group: "Parks"
  },
  {
    name: "Eastridge Park",
    id: "eastBridge",
    center: [45.65, -121.56],
    group: "Parks"
  }
]);

addPlaces takes an array of "places". A place has at least a name and center or bounds. zoom would pair with center and id would override a internal generated id.

These custom results would be placed under the respective group header.

We could use techniques from http://stackoverflow.com/questions/3975871/optimize-search-through-large-js-string-array to optimize the search.

STR:

1. open this sample
2. prior to using the geosearch control, cmd + left arrow acts as a shortcut to redirect you to the previous website
3. after giving the geosearch control focus and closing it again, the same command pans the map left.

I believe it's worse in IE8. Need to get this fixed before it can be deployed to the Developers site.

The zoom level doesn't really zoom you in much to a selected location e.g. California, UK... It would be great to be able to pass the preferred zoomlevel via options to control this. Right now you just have to edit the source.

i ran into the error below before running npm install -g karma-cli, so it'd be helpful to list this as a dependency

sh: karma: command not found

After some experimentation it seems both performant and possible to text search (with auto completion) on Feature Services.

Here is an example query searching through car share data by license plates.

where=license LIKE '%ZS%'
outFields=license,FID
f=pjson
returnGeometry=false

The above query searches the 'license' field for 'ZS' and takes ~110ms more then adequate for autocompletion.

To configure all you would need to do would be to pass an array of layer url and fields to search on the layers.

new L.esri.Controls.Geosearch({
  searchLayers: [
    {
      url: layerUrl
      fields: ["name", "description"]
    },
    {
      url: layerUrl
      fields: ["title", "notes"]
    }  
  ]
}).addTo(map);

I am trying to use our own internal geocode service with esri-leaflet-geocoder, but the search always seems to use the default geocoder no matter what I do. Here's my code:

var hcgeocoder = "http://192.168.30.45:6080/arcgis/rest/services/HendersonCounty_AddressLocator/GeocodeServer";

var geooptions = {
'url': hcgeocoder,
'useMapBounds': true,
'maxResults': 3,
'collapseAfterResult': false,
'expanded': true
}

please option for set title on search button

Cannot click a suggestion in the dropdown in IE 11 on sample site. Enter key doesn't seem to work either.

There should be an attribution Like "Geocoding by Esri" on the map when the control gets added to the map.

If you are using 3rd Party development tools, you must include attribution acknowledging that your app is using online services provided by Esri

From the ArcGIS for Developers FAQ

I mean if it's a custom service maybe we want to be able to do a lot more than only put a marker on the map... what do you think?

EsriLeafletGeocoding.Controls.Geosearch.Providers.FeatureLayer = L.esri.Services.FeatureLayerService.extend({

            (...)
            results: function(text, key, bounds, callback){
            (...)
                        results.push({ ... });
                        if (feature.geometry) {
                                    result.geometry = feature.geometry;
                        }

                                    or

                        results.push({
                                    geometry: feature.geometry,  //null or geometry
                                    latlng: bounds.getCenter(),
                                    bounds: bounds,
                                    text: this.options.formatSuggestion.call(this, feature),
                                    properties: feature.properties
                        });
            }
});```

Since using the ArcGIS Online Geocoding service is an option the map attribution text should also be an option in the constructor. The default option could remain "Geocoding by Esri".

I have my html

How to link Geosearch to input?

Since this repo is running 2.0.0-beta.x, the cut-n-paste readme sample needs to have a provider specified. In its current state it throws a You must specify at least one provider error.

we just need to update to the README (it currently says true)

cc @benstoltz

This line:
https://github.com/Esri/esri-leaflet-geocoder/blob/master/src/Controls/Geosearch.js#L210

Should be: var bounds = new L.LatLngBounds();

Edit: Oops I was in beta 3, my bad.

While bower.json in src/ says v1.0.0-rc.3...

$ head bower.json -n4

{
  "name": "esri-leaflet-geocoder",
  "version": "v1.0.0-rc.3",

when I go to dist/ both dist files say v1.0.0-rc.2

$ head esri-leaflet-geocoder.js -n1
/*! esri-leaflet-geocoder - v1.0.0-rc.2 - 2014-10-26

$ head esri-leaflet-geocoder-src.js -n1
/*! esri-leaflet-geocoder - v1.0.0-rc.2 - 2014-10-26

I've tried this on coworker's machine (just to rule out occasional caching issues I'm experiencing with bower on win) but same thing happens.

Is bower dist updated properly?

Bower installation log...

bower esri-leaflet-geocoder#~1.0.0-rc.3       not-cached git://github.com/Esri/esri-leaflet-geocoder.git#~1.0.0-rc.3
bower esri-leaflet-geocoder#~1.0.0-rc.3          resolve git://github.com/Esri/esri-leaflet-geocoder.git#~1.0.0-rc.3
bower esri-leaflet-geocoder#*                 not-cached git://github.com/Esri/esri-leaflet-geocoder.git#*
bower esri-leaflet-geocoder#*                    resolve git://github.com/Esri/esri-leaflet-geocoder.git#*
bower esri-leaflet-geocoder#*                   download https://github.com/Esri/esri-leaflet-geocoder/archive/v1.0.0-rc.3.tar.gz
bower esri-leaflet-geocoder#~1.0.0-rc.3         download https://github.com/Esri/esri-leaflet-geocoder/archive/v1.0.0-rc.3.tar.gz
bower esri-leaflet-geocoder#*                    extract archive.tar.gz
bower esri-leaflet-geocoder#~1.0.0-rc.3          extract archive.tar.gz
bower esri-leaflet-geocoder#*                   resolved git://github.com/Esri/esri-leaflet-geocoder.git#1.0.0-rc.3
bower esri-leaflet-geocoder#~1.0.0-rc.3         resolved git://github.com/Esri/esri-leaflet-geocoder.git#1.0.0-rc.3
bower esri-leaflet-geocoder#~1.0.0-rc.3          install esri-leaflet-geocoder#1.0.0-rc.3

I haven't been able to get the geocoder to honor searching for world results. The results seem stuck within a fixed value of the visible map extent, maybe it's simply using the default value of 12?

Example: http://jsbin.com/noluho > trying typing in Boulder or Ft Collins

      var searchControl = L.esri.Geocoding.geosearch({ 
        useMapBounds: false,
        providers: [
          L.esri.Geocoding.arcgisOnlineProvider({
            countries: ['USA'],
            categories: ['Address', 'Postal', 'Populated Place','POI' ]
          })
        ]
      }).addTo(map);

For example: 9th and Market St, San Francisco, ends up just pointing you to "Market St"
However, passing this in as a single line query to the geocoder does work as expected.

<<<<<<< HEAD:Readme.md expanded | Boolean | true | Start the control in an expanded state.

allowMultipleResults | true | When ...

I'm attempting to geocode against a server that requires authentication, but the geocoder plugin doesn't seem to support an option for authentication. Am I misunderstanding the proper method?

*Edit: * sorry, meant version >2.0.0 not 1.

Hey guys,

I've just upgraded to version 2.0.1 and came across an issue with Webpack.
Before I was creating a dependencies bundle:

dependencies: [
    'leaflet',
    'esri-leaflet-geocoder'
]

That was enough for me to be able to access L.esri.Geocoding.

Since v2, Webpack is trying trying to pull the source files for the esri-leaflet-geocoder package which are not converted to ES5 hence failing. I added the package to the resolve.alias list so it points to the compiled file inside dist. This time I got the same error but with esri-leaflet, which the geocoder package is trying to require but is going for the source version rather than the dist one.

Tried adding esri-leaflet to the resolve alias list as well and even specifically adding it to the bundle. In every case webpack is able to build but L.esri is undefined.

Has anyone come across this issue and/or know how to solve it?

Hi,

I'm definitely missing something fundamental...using RequireJS I get all geocoding tasks, services, and controls at Esri.Geocoding which I can see in the source.

I've added the following to the top of the file
define(['leaflet', 'leaflet.esri'],
(function (L,Esri) {
replacing the module definitions i.e. line 5-22.

However other examples are adding controls to Esri.Controls etc. and I can see in the source that tasks, controls, and services are part of Geocoding (line 36). Not sure what I need to do to get this matching the examples and expected behavior using RequireJS i.e. Geosearch Control in Esri.Controls.

Thanks,

T.