esbanarango / ember-model-validator Goto Github PK

Model validator shouldn't be a mixin but part of the DS.Model object by default.

DEPRECATION: Enumerable#contains is deprecated, use Enumerable#includes instead. On ember#2.7.2

I have a property observing model-validator mixin property validationErrors but this is not observing the changes done in model values which are already validated. So it needs an explicit call to validate() method to update the error values in the form. Please guide us how to handle this here.

This looks like an awesome addon! ⛵️

I think many Ember users also know about ember-changeset-validations. Would you be willing to make a short comparison between the two, listing pros/cons. I think it would be very helpful to people trying to understand this addon.

I did not get ember-model-validator to work, I did the following in my model:

export default Model.extend(Validator,{
  login: attr(),
  password: attr(),

  validations: {
    login: {
         presence: true
    }
  },

I get the warning when I am creating a new user:

WARNING: Interacting with a record errors object will no longer change the record state.

These values: '1', 1, and true should be the acceptable values. But the user can specify it as well with the accept option.

Hi,
I can't get the model inside the router,
I am getting an error:
TypeError: fakeModel is undefined
or
TypeError: fakeModel.validate is not a function

also I am using ember-mirage as a single mock server.

Hi

Is there a way to add i18n support for the default error messages (like "can't be blank"). Especially if it would work with ember-i18n :) ?

The devDependency ember-cli was updated from 3.15.1 to 3.15.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

ember-cli is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The devDependency ember-template-lint was updated from 1.5.2 to 1.5.3.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

ember-template-lint is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Is it possible to configure a date validation with something like this?

{
  date: {
    after: {
      value: '2016-12-01',
      message: 'should be before 2016-12-01'
    },
    before: {
      value: '2016-12-12'
      message: 'should be after 2016-12-12'
    }
  }
}

Hello! I've faced with a validation problem of an Email address: [email protected]
It will throw the validation error, but it is right Email address.

It should have the option to validate in different countries, or at least, Canada and US.

This is an example of a Canadian zipcode: T2A2V8

Hey!

I'm working with ember-model-validator and EmberData 2.1 and I'm having an issue validating a belongsTo relationship. I'm using version 1.1.0 of ember-model-validator

I've create my model like the following

import DS from 'ember-data';
import Ember from 'ember';
import Validator from 'weldnote/mixins/model-validator';

const { computed, isEmpty, inject } = Ember;
const { belongsTo } = DS;

export default DS.Model.extend(Validator, {
  i18n: inject.service(),
  code: belongsTo('industry-code', { async: false }),

  validations: {
    code: {
      presence: true
    }
  }

});

When I call validate() the code is considered to be empty (but it's not).
I've managed to debug the issue to the following:

//model-validator.js
_validatePresence: function _validatePresence(property, validation) {
      var propertyValue = this.get(property);
      // If the property is an async relationship.
      if (this._modelRelations() && !Ember['default'].isBlank(this._modelRelations()[property])) {
        propertyValue = this.get(property + '.content'); // Here is the problem
      }
      if (Ember['default'].isBlank(propertyValue)) {
        this.set('isValidNow', false);
        this._addToErrors(property, validation.presence, Messages['default'].presenceMessage);
      }
    },

If I console.log propertyValue, right before the this.get(property + .content') I get the following
Class {store: Class, container: Container, _internalModel: ember$data$lib$system$model$internal$model$$InternalModel, isError: false, adapterError: (...)

But the this.get(property + '.content') returns undefined.... was it this way with older versions of Ember Data (I'm guessing that's my problem).

I've been dealing with this through custom validations, but it's kind of annoying to always do this:

validations: {
    code: {
      custom: {
        validation(key, value, model) {
          let id = model.get('code.id');
          return !isEmpty(id);
        }, message(key, value) {
          let translation = value.translate('edit-view.attributes.required');
          return translation;
        }
      }
    }

Thanks a lot for the project. It's been very helpful

The devDependency ember-ajax was updated from 3.1.2 to 3.1.4.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

ember-ajax is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The devDependency ember-cli-htmlbars-inline-precompile was updated from 3.0.0 to 3.0.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

ember-cli-htmlbars-inline-precompile is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

I have the following model

import DS from 'ember-data';
import Validator from '../mixins/model-validator';

var attr = DS.attr;

export default DS.Model.extend(Validator, {
  plan: DS.belongsTo('plan', {async: true}),
  validations: {
    plan: {
      presence: {
        message: 'Please select a plan'
      }
    }
  }
});

Then when I'm trying to validate a model trying to test the behavior when the validation fail, the validation pass, but if I delete the {async: true} the validations doesn't pass (as expected)

HI,
I noticed that if I have:

logoUrl: {
  URL:true,
},

It required from me value cuz empty string or null is always invalid. Is there an option for make any empty string or null always valid?

Hey,

I stumbled upon an issue with custom messages not receiving the values correctly. I've create this PR to fix the issue. Hope it helps :)

Thanks for the great addon.

in https://github.com/esbanarango/ember-model-validator/blob/master/addon/mixins/model-validator.js#L38

you are making a transition to the state updated.uncommitted and that set model properties to isNew == false and isDirty == true breaking the API like this: https://gist.github.com/sescobb27/5becc19ba451a18f5e15

a workaround to fix that problem is this, but it isn't generic for all situations.

if (!order.get('id')) {
  if (order.get('currentState.stateName') === 'root.loaded.updated.uncommitted') {
    order.transitionTo('loaded.created.uncommitted');
  }
  return order.save().then(deferred.resolve);
}

I think you should save the previous state of the model, and when the model is valid again reset that state

I have set out to give ember-model-validator a serious try-out. It would be very helpful for me, if the documentation included an example (best practice) about how to use the error-list in a template.

For instance, look at the example at http://esbanarango.github.io/ember-model-validator/#/validators/length.

Here, it is possible to trigger several errors at the same time - great!

How do you relate errors for a specific model attribute to the field displaying this attribute? Are you using computed properties**?**

How do you make the error-messages immediately disappear from display and error-list, when starting to type something into a specific error-prone field, while all other errors keeps existing in the error-list and keeps being displayed**?**

The dependency ember-cli-babel was updated from 7.13.0 to 7.13.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

ember-cli-babel is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

numericality: {
onlyInteger: true,
allowBlank: true
}

Is there a reason why Ember.isBlank() is being used instead of Ember.isEmpty()?
For the above validation, x = ' ' validates as true, which is expected using isBlank. Coupled with an onlyInteger validation, this doesn't quite make sense.

The devDependency sass was updated from 1.14.2 to 1.14.3.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

sass is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Hi there,

I just upgraded ember-data, ember-cli and ember-source to 2.15 and I got this message from my model validator. Could you plz help me to find a solution on this issue?

Hello there!
First, let me thank you for this very good addon!

Concerning error messages for the length constraint, is there a way to have different messages for minimum and maximum?
Something like this would be great:

length: {
    minimum: {
        value: 3,
        message: 'form.errors.tooShort'
    }
}

I need to validate a field only if another attribute has an specific value and I don't know if the library has this option.

i.e. something like this:

validations: {
  images: {
    presence: true,
    validateIf: function () { return 'gallery' === this.get('type'); }
  }
}

I know I can do it with customValidators so I can solve it that way right but it feels better this way because I can reuse the base validations of the library. Does this exists? If not, I can check the code and add it with a PR.

Validations for related models are not run when the relationship is defined like DS.hasMany('related-model', {async: false})

I believe this is a regression introduced in this commit. I think in this case the related objects are not wrapped in a proxy so the content property is undefined.

I am currently using ember-data 2.8.1

Hi,

I have a model 'property' and 'flat'.
Flat inherits from property, but when i declare validations in both, only 'Flat' validators show, because they are rewritten.
How can I use validations from the parent in the child class?

I see that there is the relation: ['belongsTo']
but I want to only check for the relation if a different relationship's property is true

Using Ember 2.0.0 with Ember Data 2.1.0 and ember-model-validator I get a warning when validating numericality.

numericality: {
  allowBlank: true,
  greaterThanOrEqualTo: 0,
  lessThanOrEqualTo: 30
}

DEPRECATION: Ember.String.fmt is deprecated, use ES6 template strings instead. [deprecation id: ember-string-utils.fmt] See https://babeljs.io/docs/learn-es6/#template-strings for more details.
        at Object.fmt (http://localhost:4200/assets/vendor.js:44511:29)
        at _validateNumericality (http://localhost:4200/assets/vendor.js:167958:88)

In these lines is where the situation occurs.

This validator should accept the same options as the Active Record Numericality validator.

• only_integer
• greater_than - Specifies the value must be greater than the supplied value. The default error message for this option is "must be greater than %{count}".
• greater_than_or_equal_to - Specifies the value must be greater than or equal to the supplied value. The default error message for this option is "must be greater than or equal to %{count}".
• equal_to - Specifies the value must be equal to the supplied value. The default error message for this option is "must be equal to %{count}".
• less_than - Specifies the value must be less than the supplied value. The default error message for this option is "must be less than %{count}".
• less_than_or_equal_to - Specifies the value must be less than or equal the supplied value. The default error message for this option is "must be less than or equal to %{count}".
• odd - Specifies the value must be an odd number if set to true. The default error message for this option is "must be odd".
• even - Specifies the value must be an even number if set to true. The default error message for this option is "must be even".

The devDependency ember-cli-inject-live-reload was updated from 1.8.2 to 1.10.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

ember-cli-inject-live-reload is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

This way we can be specific about which validations run.

The devDependency eslint-plugin-ember was updated from 6.9.1 to 6.10.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

eslint-plugin-ember is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Missing validations

• URL
• Subdomain
• Hex Color

in store.recordWasInvalid(this, errors); throws an error Uncaught TypeError: internalModel.adapterDidInvalidate is not a function.

reading the source code of ember-data I found this

// ===== InternalModel
// FOR USE DURING COMMIT PROCESS
/**
  @method adapterDidInvalidate
  @private
*/
adapterDidInvalidate: function (errors) {
  var recordErrors = this.getErrors();
  ember$data$lib$system$model$internal$model$$forEach.call(Ember.keys(errors), function (key) {
    recordErrors.add(key, errors[key]);
  });
  this._saveWasRejected();
}
// ===== InternalModel

/**
  This method is called once the promise returned by an
  adapter's `createRecord`, `updateRecord` or `deleteRecord`
  is rejected with a `DS.InvalidError`.
   @method recordWasInvalid
  @private
  @param {InternalModel} internalModel
  @param {Object} errors
*/
recordWasInvalid: function (internalModel, errors) {
  internalModel.adapterDidInvalidate(errors);
}

I think you should not call that method manually, instead make something like this: https://github.com/dockyard/ember-validations/blob/master/addon/validators/local/inclusion.js#L23

First, thanks for your library it help me a lot.

Second, is there a way to prioritize errors message. For example, i have a too short message and a required message to show.

I would like to show "Requiredt" when its empty, not both. And if it too short, only "Too short".

Thanks man !

The devDependency ember-cli-htmlbars was updated from 3.0.0 to 3.0.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

ember-cli-htmlbars is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

If I put a numericality validator on one of my nullable number fields, validation will fail if input is blank. The validator should not assume the behavior of the presence validator; presence should be specified separately.

There are a bunch of pre-existing code that uses the locale property of the model:

// my-model
export default Model.extend(Validator, {
  locale: attr('string'),
  ...
})

This conflicts with the locale property defined here: https://github.com/esbanarango/ember-model-validator/blob/master/addon/mixins/model-validator.js#L31-L38

There are obvious workarounds:

• monkey-patch Validator
• use myLocale: attr('string', { key: 'locale' }) and update all existing code

In general, Ember addons tend to be very aggressive with claiming keys in users' namespaces (see emberjs/data#973), so this code is idiomatic.

But what's the suggested workaround?

Also posting so that anyone else with the problem can find it (and a solution, if there is one).

cc @rwwagner90 @jblakeman

To reproduce:

on super class:

• validate one field

on sub class:

• validate a different field

test:

• have an instance of the sub class
• do something that you would expect to cause both validations to fail
• there is only an error for the subclass's validation, and not the superclass

In the model I did like this:

import Ember from 'ember';

import Validator from 'ember-model-validator/mixins/model-validator';

export default Model.extend(Validator,{
  login: attr(),

  password: attr(),

 validations: {
    login: {
       presence: true
    },  
   password: {
     presence: true     
   }
  },

});

In the template.hbs I do something like this:

        <table>
             <tbody>
                 <tr>               
                    <td>{{input value=login}}</td>         
                    <td>{{input value=password}}</td>       
                </tr>
             </tbody>
         </table>

It does not show anything when I try to submit empty login or password.

Do I need to do something else ?