ericsson / ered Goto Github PK

It is useful for developers if the same client can connect to a standalone node, not only a cluster. For this, we need to handle an error response form CLUSTER SLOTS and handle this as if the whole cluster is handled by a single node.

The requirement that the cluster needs to have at least two masters for 'cluster_ok' may need to be reconsidered.

Add options for username and password.

We can send them in the HELLO command.

The readme file should have examples of how to use the library as well as an overview of its API.

There are some quirks regarding pubsub. SUBSCRIBE and other commands don't really return anything, just push messages. When subscribing to multiple channels, ered currently gets out of sync. Thus, we can't say that pubsub is supported yet.

In general, processes should belong to a supervision tree. At least most of them.

This is considered good OTP style. (Hypothetically, if trap exit is later added to a process started using spawn_link, the process is not killed by the link. If it's instead managed by a supervisor, it is brutally killed even if it's trapping exits. One should not re-invent supervisors.)

When gen_tcp:recv (or ssl:recv) is used, the process can't respond to supervisor events. We should use {active, once} or {active, N} instead.

We use one process to send data to a socket and another to receive the responses. Currently the sending process is the controlling process. We should make the receive process the controlling process instead, because gen_tcp:send can block.

Minimize the copying of data between processes. Do as much as possible in the calling process.