ericdallo / spring-s3-properties-loader Goto Github PK

Did you consider adding a license to your project? This makes it easier for others to use it and also enables potential contribution.

Best

Unable to retrieve the requested metadata (/latest/dynamic/instance-identity/document). Failed to connect to service endpoint:

lot of dependancy issues, there is no S3 config from this library, consumers needs to research to add this , can u prove from a client on how this library helps to load application properties from s3 at spring boot startup(deployment time)

I don't think this is working as intended:
@S3PropertiesLocation(value = "${AWS_S3_LOCATION}", profiles = "developer")

From the code:
https://github.com/ericdallo/spring-s3-properties-loader/blob/master/src/main/java/com/spring/loader/util/SystemPropertyResolver.java#L48

We can see that the value comes from String valueFromEnv = System.getenv(key); the env variables.
However, it would be better to fallback into System.getProperties. This way we can pass -D params to the JVM.

This is particularly useful with AWS beanstalk with sets env variables as -D params on the JVM.

I'm trying to load a configuration object from a YAML file in S3.

My YAML file is

test:
  s3property: "Success!!"

I have

@Configuration
@S3PropertiesLocation("testbucket/config/test.yaml")
class S3Config {
}

And

@Component
@ConfigurationProperties("test")
class TestConfig {
    var s3property: String = ""
}

When I Autowire TestConfig, it doesn't hold any value in s3property.

However, it works if I explicitly add @value annotation to read the property.

@Component
@ConfigurationProperties("test")
class TestConfig {
    @Value("\${s3property}")
    var s3property: String = ""
}

Using @value annotation is not practical since I have an object with map of lists.
I would like to be able to read the configuration into an object like we can with Spring application.yaml.

I'm using the 2.0.0 version, like this

@Configuration
@S3PropertiesLocation("s3://example/example-dev/application.yml")
@Import({CommandConfiguration.class,
        C4SDKConfiguration.class})
public class AppClassConfig {

But the app is starting without an application.yml file