eranziel / foundryvtt-lancer Goto Github PK

Describe the bug
User-created frames don't show their name on the pilot sheet when added to a pilot.

To Reproduce
Steps to reproduce the behavior:

1. Create a frame item.
2. Drag it onto a pilot sheet.
3. Pilot sheet will say "Manufacturer" instead of "Manufacturer Frame Name"

Expected behavior
User-created frames should show name on pilot sheet.

Implement macros which print effects text in a fancy chat block. Similar to Roll20 character sheet behaviour.

1. Pilots:

• Skill triggers
• Talents
• Mech systems
• Core bonuses
• Core system active
• Core system passive
• Pilot gear
• Mech traits (are these necessary?) Removing from scope, unless feature is requested by users.

2. NPCs:

• Weapons
• Tech Attacks
• Reactions
• Traits
• Systems

Describe the bug
NPC features do not preserve their type when being exported using adventure importer/exporter module.
This does not, however, happen if you export the item as a JSON manually.
All data is preserved, but feature type is reset.

not the feature type.

To Reproduce
Create an NPC feature, and change it to a feature type that is anything other than a Trait
Use Adventure Importer/Exporter to export the entire world content.
In a different world, import the previous world content

Expected behavior
NPC Features should remember what they were.

Add a macro roller for generic NPC invade option to NPC sheets.

They seem to have a large amount of unused metadata from Adobe Illustrator that makes up the bulk of their size. Simply opening and saving them with Inkscape gets rid of about 780kb. SVGO makes them even smaller.

Add the ability to convert Comp/Con NPCs from JSON to an NPC Actor.

Create editable sheets for the NPC Item types:

• NPC Class
• NPC Template
• NPC Feature, with handling for the following sub-types:
  • Weapon
  • Trait/System

When making a new frame item, new mounts and traits can't be added.

To Reproduce
Make a new item of the frame type in the items tab
Edit the new item, then click the "+" buttons next to either "Available Weapons" or "Traits"

No mount-type drop down or trait text box appears to be edited after doing so

Describe the bug
When NPCs are edited (and maybe Pilots too), the prototype token image gets reset to the actor image.

Implement support for separate pilot and mech images and tokens for each Pilot.

Need a good UX for selecting which token to place. Mech token should be default. Possibly have a draggable token-generator on the pilot/mech sections of the sheet?

Add a HUD button for dismounting/mounting on the canvas. Dismounting will generate the pilot token on top of the mech token. Mounting should only be an option when adjacent to that pilot's mech, and will remove the pilot token from the canvas.

Being able to drag or otherwise assign Macros(Weapons, Skills etc) from the Pilot/NPC Sheet to the Macro Quickbar.

Create Compendiums from the parts of lancer-data which are needed to assemble pilots and mechs:

• Skill Triggers
• Talents
• Core Bonuses
• Pilot Equipment
• Mech Frames
• Mech Systems
• Mech Weapons
• Licenses (derived from Mech data, doesn't exist directly in lancer-data)

Implement reserves as an Item type which can be added to pilots.

Make attack macros responsive to targeting on the canvas. Compare attack rolls to target's evasion/e-defense, damage to target's armor, and preview damage done.

Optional: add a system setting which automatically subtracts damage dealt from recipient's HP? Creates issues around overshield, resistance, damage mitigation reactions, etc...

When there is an update to lancer-data and the Compendiums get updated, only those items get updated. Copies owned by actors don't get updated.

Implement a macro which updates rules text on Items owned by Actors.

• Search Compendium for the lancer-data id that the item has.
• If a match is found, copy the new compendium data to the owned item. Some properties shouldn't be updated - flavor names and descriptions, for example.

NPC features do not seem to roll to chat log. Also their formatting is ugly.

If this is part of non-rendered Systems data in Changelog, please feel free to close.

To Reproduce
Steps to reproduce the behavior:
Create an NPC with Class and template.
Create an NPC Feature. Make it a weapon.
Click on the dice icon.

Expected behavior
The accuracy/difficulty slider window should pop up and allow you to commit the roll to chat log like a PC roll.

Screenshots

Windows 10, Electron applet, no mods that affect sheet/chat logs.

Describe the bug
Right clicking items on the pilot sheet deletes the item without notification.

To Reproduce
Steps to reproduce the behavior:

1. Open pilot sheet.
2. Right click on an item card.
3. Item is deleted from the Actor.

Expected behavior
Right-click deletion is unintuitive. Should at least have a confirmation prompt.

Describe the bug
As title.

To Reproduce
Click on dice icon. When accuracy/difficulty window shows up, close the window. Chat log indicates that the roll has been committed to the log.

Expected behavior
Clicking on the close button should not send the roll to log.

Windows 10, Electron applet, no mods that affect sheet/chat logs.

Not yet published. Description from Discord:

in the next few weeks there will be some breaking changes incoming to the c/c data structure:
1) frames are going to require a license_level integer. License level 0 frames/equipment etc will be available to players from LL0 (like Everest/starter GMS stuff is)
2) item effects (abilities) will now be broken into effects and actions, the former being passive or within the context of the triggering action (eg an on-hit attack is contained within the context of 'skirmish', it's something attacks with that weapon do) and the latter being new actions a piece of equipment allows for (reactions, protocols, tech options, etc). This will likely break most of the homebrew lcps out there currently. sorry :pain: 
3) frame core powers are now explicitly actions, to be handled by active modes
and a few nonbreaking updates:
1) talents, frame traits, items, and core bonuses will now accept synergy fields, discrete data objects that populate a set of decorators that will highlight eg. weapon/talent synergies on player views, targeted to the relevant user view
2) frame traits can optionally furnish item actions
5) talent ranks that confer an integrated weapon or system will link that system with a new data object(talent_item), with an exclusive field for linear upgrades (eg. technophile I > II > III)

Implement a feature to facilitate visually tracking conditions with numbered states on the canvas. Useful for burn, or anything with a tracking die.

The Pathfinder 2e system implements something similar, for a source of inspiration.

Flesh out the readme.

Being able to track Core Power Charges of Frames.

Tracking Core Power Charge on the UI sheet preferably with a nice UI element.

Allow character building/level-up/loadout by drag-and-drop with applicable Item types.

For example, dragging a Talent onto a pilot sheet will add that Talent to the pilot. Dragging a weapon will add that weapon to the pilot or mech. Etc...

Edit:

• Weapon Mount handling
• Mech frame handling

Integrate rollup build with gulp. Config file is done and works separately (npx rollup -c), but gulp needs to call rollup through its JS API.

This is needed so that lancer-data (and any other external dependencies) are available when the system runs from within Foundry.

New NPC weapon sheet does not have tier based damage anymore, while old sheets maintain their tiers.

When rolling from the character sheet, 3D dice from Dice so Nice don't appear. They only appear if rolling manually from chat.

Convert compendium builder/updater functions to macros and merge into master.

Investigate the possibility and feasibility of building support for hex token footprints for sizes above 1.

The API in general seems extensible enough that it should be possible. The larger question is how much work it would be.

Create sheet templates and logic for the Actor types:

• Pilot
• NPC
• Deployable

Describe the bug
System effects appear to be missing in the compendium.

To Reproduce
Steps to reproduce the behavior:

1. Create a new "pilot" actor
2. Open the Systems compendium pack
3. Click on a system to open the description, or drag it onto a pilot actor to equip it to the character
4. Check to see if the Effects field is populated

Expected behavior
I would expect the system effects to be part of the compendium. Some are there - the Autoloader Drone has the full text, and the ASURA-class NHP has part of its text.

Screenshots

Desktop (please complete the following information):

• OS: Win10
• Browser: Chrome
• LANCER System Version 0.1.2
• Foundry Version 0.6.5

Additional context
The console did not produce any errors when I opened the system and applied it to an actor.
I checked as player and gamemaster, and saw the same behavior.

Implement Lancer-specific combat initiative logic.

Is your feature request related to a problem? Please describe.
In the current way template.json is formatted, we have values such as "loaded", "destroyed", "uses", etc being tracked on the item object.

This would mean that these have to be tracked on each individual object, rather than being actor-specific--if two mechs are using the same weapon, the GM will need to have two copies of that item in the game, in order to have players differentiate between uses.

Describe the solution you'd like
Change the actor data object to hold any info that should be actor-specific within the array of weapons etc. Key things I've noticed (but may not be comprehensive) are:

mech_equip->uses
mech_equip->max_use_override
mech_equip->loaded
talent->rank
license->rank
pilot_armor->speed_bonus
pilot_armor->edef_bonus
pilot_armor->evasion_bonus
pilot_gear->uses
mech_weapon->mod

Describe alternatives you've considered
Track these within the Actor->pilot object. The sheet would also need to be changed to accommodate this

Additional context
Been bouncing around my head for a while, but I wanted to make sure this went out there because I may not have time to get around to it for a while--someone else should probably pick it up.
Also, didn't just throw in a change to the data model myself because I wanted to put it out here so there's an opportunity for discussion. I think any sort of change to the template merits some discussion, even if it's much smaller than this.

Window for NPC class creation opens undersized, and you have to double click to commit values to the template. This is somewhat counterintuitive. Also, the up/down values have wierd hitboxes and need to be almost pixel perfect to click.

Windows 10, Electron applet, no mods that affect sheet/chat logs.

Ranking up Talents and Skills is unintuitive.

Maybe we want to add a button or a field to control the level of a skill or talent.

HASE values are regularly used in mech combat and having to switch tabs to f.e. make an engineering check is annoying and unnecessary.

Move or duplicate the HASE Values and Macros into the Frame//Loadout Tab of the pilot sheet.

Implement a means to set damage type on weapons with selectable damage - pilot signature weapons, engineer prototype weapon.

Bring status/condition icons into the system itself. Three sets to include: Hayley's and Cancermantis' from the lancer-conditions module, and the Comp/Con icons should be added as a third set of options.

Implement macros which automate the majority of attack behaviour.

• For pilots, use associated pilot (Actor) stats to determine attack bonus (grit).
• For pilots, use associated weapon (Item) stats to determine natural accuracy/difficulty, damage, and weapon effects.
• For NPCs, use associated NPC feature stats to determine attack bonus, natural accuracy/difficulty, damage, and weapon effects.
• Implement pop-up prompt for accuracy/difficulty.

Since systems and weapons are converted from lancer-data, they include the full effects data structure used by Comp/Con. Implement specific rendering of each effect type on the item sheets.

Describe the solution you'd like
Integrate the PDFoundry Library so we give users the ability to have lancer rules Foundry.

On closing and re-entering a world running the Lancer system, tokens generated from Actor sidebar are reverting to the mysteryman icon. All other attributes are preserved.

Hex Size Support Module was used initially. Problem persists even when module is removed.

Per title.

To Reproduce
Make a new NPC
Apply a class template to it.

Expected behavior
Heat values should be treated like PC sheets, starting at 0.

Screenshots

Windows 10, Electron applet, no mods that affect sheet/chat logs.

Implement importing pilots from Comp/Con in two ways:

• JSON import - copy from C/C, paste into Foundry.
• Cloud import - enter cloud ID, download the gist and build the pilot.

If importing from cloud, save the cloud ID to the Actor and show a sync button on the pilot's sheet.

The Pilot sheet does not save the new image reference when a new image is selected. Selected image also does not apply to token.

Add the option to use AOEs drawn on the canvas for targeting attack macros.

Implement macros which automate the majority of attack behaviour for NPCs.

Use associated NPC feature to determine attack bonus, natural accuracy/difficulty, damage, and weapon effects.

Handle accuracy using the same method as for Pilot attack macros (#7).

Describe the bug
Trying to change name of the NPC sheet (to speed up NPC token overview) and could not.

To Reproduce
Steps to reproduce the behavior:

1. Make and NPC and Name it.
2. Try to find a way to change the name of sheet.
3. Can't.
4. See error

Expected behavior
I would be able to change the sheet name

Screenshots
Not Super applicable

Additional context
Thanks for being rad.

Create sheet templates and logic for the Item-types:

• Skill Triggers
• Talents
• Core Bonuses
• Pilot Equipment
• Mech Frames
• Mech Systems
• Mech Weapons
• Licenses

Describe the bug
Some systems have no description in their entries when viewed in the compendium. When opened up and then closed, "[object Object] Effect" updates on the sheet.

If this is part of non-rendered Systems data in Changelog, please feel free to close.

To Reproduce

1. Open a new character.
2. Go to Frame//Loadout and set up a mech.
3. Drag PATTERN-A SMOKE CHARGES to the mech loadout.
4. Click on PATTERN-A SMOKE CHARGES and then close the window.

Expected behavior
Text should match and also empty boxes should not display odd things.

Windows 10, Electron applet, no mods that affect sheet/chat logs.