eranofek / maat Goto Github PK

When I doing bright star crossmatching, I found that no catalogue can provide bright star sdss magnitude. The bright end is about 9 magnitude for APASS which is the main source of several other catalogue.
After searching, there is a ATLAS-REFCAT2 catalogue compiled by Tonry published at 2018. They have small telescopes called pathfinder, which can cover the bright end of the sky. Also it includes PanSTARRS DR1, ATLAS re-flattened APASS, SkyMapper DR1, APASS DR9, Tycho-2, and the Yale Bright Star Catalog. It is a great help for photometry calibration in some cases. So I want to convert the catalogue to catsHTM format.
Is there a tool for doing this? Or some sample that can be referencing.
Thanks.

1. SIMPLE = T / becomes {'SIMPLE' } {[ NaN]} (ditto: PHOTLINK= F ), i.e it seems that booleans are not parsed correctly
2. COMMENT followed by just blanks (2nd line of) becomes {0×0 double} {0×0 double } {0×0 double }

Reported first in https://github.com/EranOfek/imClass/issues/2, since I discovered them there, but actually bugs of @FITS/FITS.m here. The first one already hopefully corrected with 548e1b6

Is there something really as esoteric as that or is it a typo? All negligible when in docs, but not when in methods like in @WorldCooSys.

$ grep -r mtarix /home/eran/matlab/MAAT
/home/eran/matlab/MAAT/@AstSpec/AstSpec.m:            %            containing spectra in mtarix, cell or AstSpec formats.
/home/eran/matlab/MAAT/@WorldCooSys/WorldCooSys.m:        function CD=read_cd_mtarix(WCS)
/home/eran/matlab/MAAT/+Util/+stat/wmean.m:%          - Optional mtarix of errors. If given, then the first input
/home/eran/matlab/MAAT/@ClassWCS/ClassWCS.m:        function CD=read_cd_mtarix(WCS)
/home/eran/matlab/MAAT/AstroSpec/spec_read_ascii.m:%            containing spectra in mtarix, cell or AstSpec formats.

I think you should add *.*~ to .gitignore, and run a git clean.... just saying...

Line #144 of SIM/coadd: this effectively copies CoaddFunPar to "StdFunPar", resulting in an error when the StdMethod is nanstd (and CoaddMethod is nanmedian, for example).

In the ClassTrans class, is there any difference between the distortion style TPV and PV? I find
that the get_pv method only supports PV style. You can find here, in get_pv method,
'''
if (isfield(W(Iw).(WCSField),'PV'))
'''
https://github.com/EranOfek/MAAT/blob/master/%40ClassWCS/ClassWCS.m#L754
And the get_tpv method call get_pv method, see
https://github.com/EranOfek/MAAT/blob/master/%40ClassWCS/ClassWCS.m#L802
Thus, these two methods are not support tv style. Is this a bug or not? This unsupportment may affect the xy2coo method for tv style.

I do not understand the iteration method to solve inverse_tpv. When I test it, it seems it will not converge. So I use the fsolve to find the root and it now support the vector input.

I had enough of ununderstood units like 'deg ' etc.

If I am wrong in removing whitespace systematically, please revert my commit c17415b

What is this link and what file should it be pointing to?