epyx-src / crowdin-client Goto Github PK

I got "[Errno 17] File exists" error when do crowdin pull.

Change client.py line 125:

        directory = os.path.dirname(path)
        try:
            os.makedirs(directory)
        except OSError as ex:
            logging.error(ex)
            pass
        logger.info("Writing {0}".format(path))

To this:

        directory = os.path.dirname(path)
        if not os.path.isdir(directory):
            try:
                os.makedirs(directory)
            except OSError as ex:
                logging.error(ex)
                if ex.errno != 17:
                    raise
                pass
        logger.info("Writing {0}".format(path))

Fixed this problem for me.

Please take a look.

Currently (client.py) the "push" command uploads the reference language AND the translations.

This should be an option (like --upload-translations). It only serves the use case were you import a new project into crowdin for wich there are existing translations (bootstrap).

In the normal case, it just breaks the crowdin workflow, which should be:

• Upload/update reference language (crowding push)
• People suggest translations via crowding
• Proofreader approves translations
• Build new package
• Import translations (crowding pull)

By pushing updated data AND uploading translation, we introduce new "suggested" translations which break the work of the proofreader.