got nil while trying to play a lyre:
data/actions/scripts/other/music.lua:39: attempt to call a nil value (global 'isInRange')

fixed it by adding to global.lua:

function isInRange(pos, fromPos, toPos)
return pos.x >= fromPos.x and pos.y >= fromPos.y and pos.z >= fromPos.z and pos.x <= toPos.x and pos.y <= toPos.y and pos.z <= toPos.z
end

Before creating an issue, please ensure:

• This is a bug in the software that resides in this repository, and not a
  support matter (use https://github.com/EPuncker/orts2/issues/ for support)
• This issue is reproducible without changes to the C++ code in this repository

Steps to reproduce (include any configuration/script required to reproduce)

1. Write on item ex: book ID 1977
2. Use item once transformed/written ex: book ID 1962

Expected behaviour

text window oppening and showing written text

Actual behaviour

nothing happens

#41 caused/uncovered a ton of console issues here, is it only on my end? Most of them point to lib foder interactions, only 2 from outside files from what i remember. Sry for not being more specific, when i have some spare time i can post a detailed list of the console errors.

Hey guys! :) found some new stuff
-Dragon: While looking at a dragon corpse you get the wrong message, those that spwan dead and decayed on the map(yalahar elf), ingame id 4027, 18:51 You see a slain ghoul (Vol:24).

-Egg: not usable as food, ingame id 3606, "You cannot use this object."

-Very noble-looking watch: ingame id 6091, should show time and then decay after a while. "You cannot use this object."
"When you use it, you'll receive the following message informing the current time: The time is hh:mm.
After 24 hours, it will break and become a Broken Very Noble-Looking Watch."

-Thais hole: Item ID: 468 Position: 32359, 32282, 7. It opens with shovel but you can't go down. I'm not really sure about this one, I can't go on global to see if this one is like that and i don't really remember where it leads either, sry.

Plaguesmith dropping cornucopia id 3957 instead of war horn 2079
monsters/plaguesmith.xml edited line 79
<item id="2079" chance="100" /><!-- war horn -->

Before creating an issue, please ensure:

• This is a bug in the software that resides in this repository, and not a
  support matter (use https://github.com/EPuncker/orts2/issues/ for support)
• This issue is reproducible without changes to the C++ code in this repository

Steps to reproduce (include any configuration/script required to reproduce)

1. Clone & Compile TFS 1.4
2. Use this data pack with it
3. Run TFS

Expected behavior

No errors, action scripts should work and NPCs/quests as well

Actual behavior

Environment

This was tested using Ubuntu 20.04 and TFS 1.4 (branch on the official repo)

hey torresmon here. turns out the flag thing was still bugged, i found the commit that fixes it: otland/forgottenserver@f7c3c1f

obs: i think spells, luascript.cpp and luascript.h are updated already no need to change
sry for not resquest pulling it, i'm not confident using git still.

Explanation of what you want to do that is currently impossible

Desired functionality

stackable violet gem id:2153, yellow gem id:2154, green gem id:2155, red gem id:2156 and blue gem id:2158

Available workarounds

spending half an hour organizing backpacks :(

example:
https://github.com/otland/forgottenserver/blob/master/data/npc/scripts/runes.lua#L20-L51

Before creating an issue, please ensure:

• This is a bug in the software that resides in this repository, and not a
  support matter (use https://github.com/EPuncker/orts2/issues/ for support)
• This issue is reproducible without changes to the C++ code in this repository

Steps to reproduce (include any configuration/script required to reproduce)

1. Start latest TFS+ORTS2
2. Watch the startup logs

Expected behaviour

Log warnings about missing monsters should not be thrown.

Actual behaviour

Warnings are thrown stating that the game cannot spawn the following monsters:

server_1      | [Warning - Spawn::addMonster] Can not find Cult Believer
server_1      | [Warning - Spawn::addMonster] Can not find Cult Enforcer
server_1      | [Warning - Spawn::addMonster] Can not find Cult Scholar
server_1      | [Warning - Spawn::addMonster] Can not find Ghost Wolf
server_1      | [Warning - Spawn::addMonster] Can not find Gloom Wolf
server_1      | [Warning - Spawn::addMonster] Can not find Renegade Knight
server_1      | [Warning - Spawn::addMonster] Can not find Vicious Squire
server_1      | [Warning - Spawn::addMonster] Can not find Vile Grandmaster
server_1      | [Warning - Spawn::addMonster] Can not find Werebadger

These monsters are referred to in data/world/map-spawn.xml but no corresponding files exist in data/monster/monsters.

Environment

I don't think this issue is environment specific.

I've reproduced this with TFS v1.4 + ORTS2 2c00e4a and also TFS master + ORTS2 main.

The exact environment I'm running is version controlled here: https://github.com/silic0nalph4/nova-secura-10

Reproduction environment

I'd be very surprised if you couldn't reproduce this as it seems to just be a case of missing files, but will happily provide more details if it's more complicated than that.

Here's the full server startup log for additional details: 2021-09-30_tfs_orts2_startup.log

Lua Script Error: [Event Interface]
data/events/scripts/player.lua:Player@onLookInShop
data/events/scripts/player.lua:26: attempt to concatenate a nil value (global 'description')
stack traceback:
[C]: in metamethod 'concat'
data/events/scripts/player.lua:26: in function <data/events/scripts/player.lua:25>

not sure how to fix it

Missing locations:

• Heart of Despair/Dungeon of Despair (Tarbaz)
• Dungeon of Plague (Plagirath)
• Dungeon of Inferno (Mazoran)
• Dungeon of Damnation (Shulgrax)
• Dungeon of Destruction (Razzagorn)
• Dungeon of Deceit (Zamulosh)
• Dungeon of Decay (Ragiaz)
• Corym Black Market
• Water Elemental Dungeon
• Tainted Caves
• Kha'zeel Scarab Lair
• Mother of Scarabs Lair
• Forbidden Temple
• Nightmare Isles (Mini World Change)
• Hunter Camp/Dworc Camp (Mini World Change)
• Kha'zeel Dragon Lairs/Tiquanda

Others:

• Add guild hall depots to the ones that are missing
• Add free item crates (id 9661)
• Add entrance and exit to seacrest serpents (need to check youtube) Position(33545, 31859, 7)
• Add seacrest serpent to spawn (I don't know if they are regular spawn or triggered)
• Turn back the stair from Position(32888, 32081, 5) to ID 19510 and add a script to teleport to Position(32887, 32081, 4)
• Add message to all other stair 19510 on map to tell the player that he is not going to climb it (need to gather proper message)
• Add script for stony pound on Position(33264, 32015, 7) to teleport to dryads cave (and also a way out)
• Add PvP arenas/Monsters arenas and their entrances in the cities
• Add Grimvale NPCs
• Add vortices from: https://tibia.fandom.com/wiki/Updates/10.94#New_Features_and_Changes update

to "fix" mechanical fishing rod
added to data/actions/actions.xml on line 362
<action itemid="10223" script="tools/fishing.lua" allowfaruse="1" />

i have a separated script for it to be able to fish mechanical fish with nails too but it won't work as intended due to yalahar sewers having normal water tiles instead of the green ones. could edit it for swamp id tiles or something but idk it doesn't rlly matter

With the latest pull request map update (7cb099a) some non-existent monsters in the pack have been added, they are:

• Ogre Savage
• Clomp
• Ogre Shaman
• Ogre Brute
• Werebear
• Wereboar
• Glooth Brigand
• Glooth Bandit
• Glooth Bomb
• High Voltage Elemental
• Glooth Battery
• Control Tower
• Seacrest Serpent

Console Erros:

[Warning - Spawns::startup] Couldn't spawn monster "High Voltage Elemental" on position: ( 33535 / 32054 / 013 ).
[Warning - Spawns::startup] Couldn't spawn monster "Clomp" on position: ( 33646 / 31652 / 007 ).
[Warning - Spawns::startup] Couldn't spawn monster "Clomp" on position: ( 33511 / 31607 / 007 ).

Note 1: For the advancement of the project it is necessary to make some additions, such as the new monsters that were added to the game. The forgotten server was paralyzed for a long time in version 10.98 and got a sudden jump to version 12.87, with that many new monsters were added to Tibia, but they weren't added to TFS. This list brings some of the missing updates.

• 11.02 - otland/forgottenserver#4112
• 11.40 - otland/forgottenserver#4286
• 11.50 - otland/forgottenserver#4289
• 11.80 - otland/forgottenserver#4308
• 12.00
• 12.20 - otland/forgottenserver#4096
• 12.20.9066
• 12.30
• 12.40
• 12.60
• 12.70
• 12.85

This task list is linked to otland/forgottenserver#3871

The following repositories can be used for creating and modifying monsters:
https://github.com/soul4soul/ot-monster-converter
https://github.com/soul4soul/converted-tibiawiki-monster-data

Hi, sorry for asking here but this thread seems to bo closed. Can I run this datapack on TFS 1.4?

I've tried by simply replacing the data folder, but when I run tfs locally on Windows it just exits at "Loading map". No idea why, TFS didn't generate any logs.

plagirath, monster\monsters\plagirath.xml line 80 add:
<item id="25418" chance="500" /><!-- maimer -->

mazoran, mosnter\monsters\mazoran.xml lina 79 add:
<item id="18409" chance="500" /><!-- wand of everblazing -->

Migrate all quests to a single file (for each quest) in revscript

hi, good sunday! i've been testing poi, everything works well untill the 15 levers part then i got this console error when using the levers:

Lua Script Error: [Action Interface]
data/actions/scripts/quests/pits of inferno/levers.lua:onUse
data/actions/scripts/quests/pits of inferno/levers.lua:32: bad argument #2 to 'max' (number expected, got nil)
stack traceback:
[C]: at 0x7ff725936bf0
[C]: in function 'max'
data/actions/scripts/quests/pits of inferno/levers.lua:32: in function <data/actions/scripts/quests/pits of inferno/levers.lua:27>

• #64

• https://tibia.fandom.com/wiki/Updates/10.30

• https://tibia.fandom.com/wiki/Updates/10.50

• https://tibia.fandom.com/wiki/Updates/10.70

• https://tibia.fandom.com/wiki/Updates/10.80

• https://tibia.fandom.com/wiki/Updates/10.90

• https://tibia.fandom.com/wiki/Updates/11.02.4128

• https://tibia.fandom.com/wiki/Updates/11.40.5409

• https://tibia.fandom.com/wiki/Updates/11.50.6055

• https://tibia.fandom.com/wiki/Updates/11.80.7048

• https://tibia.fandom.com/wiki/Updates/12.00.7695

• https://tibia.fandom.com/wiki/Updates/12.20.8834

• https://tibia.fandom.com/wiki/Updates/12.30.9287

• https://tibia.fandom.com/wiki/Updates/12.40.9997

• https://tibia.fandom.com/wiki/Updates/12.60.10463

• https://tibia.fandom.com/wiki/Updates/12.70.10953

• https://tibia.fandom.com/wiki/Updates/12.80.11430

I'm getting an error when using Spellwand and Hive Insectoid Cell(gray island hive), from PlayerStorageKeys call. Found 6 files with this call. Tested 2 of them and got similar issues. It could be me being a noob or something else... help 😕

PlayerStorageKeys files:

• data\scripts\actions\others\spellwand.lua (console error)
• data\scripts\actions\others\insectoid_cell.lua (console error) (crash)
• data\scripts\actions\others\crate_usable.lua (not testesd yet)
• data\scripts\actions\tools\skinning.lua (not testesd yet)
• data\scripts\actions\others\nail_case.lua (not testesd yet)
• data\scripts\actions\others\usable_mount_items.lua (not testesd yet)
• data\scripts\actions\tools\skinning.lua (not testesd yet)

Environment

uniserverz myacc winx64

Console messages

• Spellwand

Lua Script Error: [Scripts Interface]
C:\Users\369\Documents\OTSERV\forgottenserver-master\data\scripts\actions\others\spellwand.lua:callback
...nserver-master\data\scripts\actions\others\spellwand.lua:17: attempt to index global 'PlayerStorageKeys' (a nil value)
stack traceback:
[C]: in function '__index'
...nserver-master\data\scripts\actions\others\spellwand.lua:17: in function <...nserver-master\data\scripts\actions\others\spellwand.lua:5>

• Hive Insectoid Cell (this one sometimes crashes the server)

Lua Script Error: [Scripts Interface]
C:\Users\369\Documents\OTSERV\forgottenserver-master\data\scripts\actions\others\insectoid_cell.lua:callback
...er-master\data\scripts\actions\others\insectoid_cell.lua:4: attempt to index global 'PlayerStorageKeys' (a nil value)
stack traceback:
[C]: in function '__index'
...er-master\data\scripts\actions\others\insectoid_cell.lua:4: in function <...er-master\data\scripts\actions\others\insectoid_cell.lua:3>

not sure if i'm missing a quest or something but i got this from Lorek in port hope when asking for passage to "mountain", "banuta" and "chor" ("west" and "center" are working without console errors):

Lua Script Error: [Npc interface]
data/npc/scripts/Lorek.lua:onCreatureSay
data/npc/scripts/Lorek.lua:12: attempt to index a nil value (local 'player')
stack traceback:
[C]: in metamethod 'index'
data/npc/scripts/Lorek.lua:12: in field 'condition'
data/npc/lib/npcsystem/keywordhandler.lua:61: in method 'checkMessage'
data/npc/lib/npcsystem/keywordhandler.lua:168: in method 'processNodeMessage'
data/npc/lib/npcsystem/keywordhandler.lua:147: in method 'processMessage'
data/npc/lib/npcsystem/npchandler.lua:427: in method 'onCreatureSay'
data/npc/scripts/Lorek.lua:7: in function <data/npc/scripts/Lorek.lua:7>

got this one while trying to use a pick on different tiles near venore

Lua Script Error: [Action Interface]
data/actions/scripts/tools/pick.lua:onUse
data/actions/lib/actions.lua:283: attempt to index a nil value (global 'tile')
stack traceback:
[C]: in metamethod 'index'
data/actions/lib/actions.lua:283: in function 'onUsePick'
(...tail calls...)

Gitter is a chat and network platform that helps manage repositories, works in a way like a discord, where you can exchange messages in real time with developers.
The orts itself used the service, as it is free I imagine it would be a good implementation in this repository.

Before creating an issue, please ensure:

• This is a bug in the software that resides in this repository, and not a
  support matter (use https://github.com/EPuncker/orts2/issues/ for support)
• This issue is reproducible without changes to the C++ code in this repository

Steps to reproduce (include any configuration/script required to reproduce)

1. Using doors
2. Doing outlaw camp quest

Expected behaviour

1. Some doors in outlaw camp had issues with the new door system because of their ids
2. Two doors wouldn't work with their keys: AIDs: 3301 and 3302
3. Some map parts just doesn't look right

Actual behaviour

1. Doors transforming into stairs, walls, etc.
2. Doors that should be locked by default are open and the key doesn't work
3. Map problems enabling shortcuts or other weird stuff

Environment

10.98 + TFS1.4 + win64 + main and 12.86 + LatestTFS + win64 + upstream

1. Doors transforming into stairs, walls, etc:

• 12692:
  

• 12695:
  

• 12703:
  

(those are the ones i managed to find, i'll keep looking for more)

2. Doors that should be locked by default are open and the key doesn't work:

• aid 3301 and 3302:
  

3. Map problems enabling shortcuts or other weird stuff:

• Pretty sure this should be closed kinda like on the right side, otherwise it becomes a shortcut:
  

• Pretty sure there should be a trapdoor like on the right side:
  

• This roof doesn't behave like it should i think:
  

[!] -> Invalid achievement "Waverider".

got this one on the way to jaul, i think it's related to the swimming tiles at the entrance. it didn't show where the print was generated from but i found those:

data\lib\miscellaneous\achievements_lib.lua (5 hits)
Line 435: if not achievement then return print("[!] -> Invalid achievement "" .. ach .. "".") and false end
Line 447: if not achievement then return print("[!] -> Invalid achievement "" .. ach .. "".") and false end
Line 469: if not achievement then return print("[!] -> Invalid achievement "" .. ach .. "".") and false end
Line 487: if not achievement then return print("[!] -> Invalid achievement "" .. ach .. "".") and false end
Line 548: print('[!] -> Invalid achievement "' .. ach .. '".')

Before creating an issue, please ensure:

• This is a bug in the software that resides in this repository, and not a
  support matter (use https://github.com/EPuncker/orts2/issues/ for support)
• This issue is reproducible without changes to the C++ code in this repository

Steps to reproduce (include any configuration/script required to reproduce)

1. Start latest TFS with ORTS2 data pack installed.
2. Notice Lua error in server startup log (see below).
3. Log into game, attempt to open or close a door or gate.

Expected behaviour

• Doors should be interactive - the player should be able to open them or close them.
• Lua errors should not be thrown during server startup.

Actual behaviour

• Doors are non-interactive.
• Lua errors are thrown during startup.

Environment

The bug isn't environment specific. For what it's worth, I'm running TFS+ORTS2 on an ARM64 Raspberry Pi under Docker Compose. My setup is version controlled and (partially!) documented here: https://github.com/silic0nalph4/nova-secura-10

Details

ca3faa0 renames a set of door variables in data/global.lua. These are referred to in data/scripts/actions/others/doors.lua.

When the server starts it throws the following error:

 Lua Script Error: [Scripts Interface]
server_1      | /srv/data/scripts/actions/others/doors.lua
server_1      | /srv/data/scripts/actions/others/doors.lua:123: bad argument #1 to 'ipairs' (table expected, got nil)
server_1      | stack traceback:
server_1      |         [C]: at 0xaaaae7bea468
server_1      |         [C]: in function 'ipairs'
server_1      |         /srv/data/scripts/actions/others/doors.lua:123: in main chunk
server_1      | > doors.lua [error]

As no doors are registered in the engine, they are rendered non-interactive in game.

I'll submit a PR in a few minutes.

Random server and client crashes when using 10.98 client

The way to merge all the commits of a pull request is to accept them with the squash option, I recommend disabling the other options in the project settings.

• Edron
  Position: 33247, 31935, 10 - shaburak missing roof

Position: 33322, 31579, 14 - demon helm missing roof

• Gray Island
  Position: 33480, 31328, 7 - black hole

Position: 33464, 31303, 6 - parcel ID: 9081(no volume), should be ID: 2595

Position: 33511, 31187, 11 - double stairs deeplings

Position: 33502, 31283, 10 - double stairs deeplings 2

• Carlin
  Position: 32397, 31811, 9 - the walls in this part of the cave are all over the place

i could pr the fixes...but i'm afraid to break something editing map stuff 😨

• Artificial Intelligence for Bosses
• World Board

New Locations

• The Spike
• Upper Spike
• Middle Spike
• Lower Spike
• Spirit Grounds
• Spirit Grounds/Easy
• Spirit Grounds/Intermediate
• Spirit Grounds/Hard

New Raids

• The Pale Count (Drefia - Vampire Crypts)

New Quests

• Cave Explorer Outfits Quest
• Spike Tasks Quest
• Spirit Grounds Mini World Change

New Achievements

• Cave Completionist

New Items

New NPCs
New Creatures
New Bosses

blood beast(oramond) turns into cyclops corpse on death. loot messages and items seems to be fine.(i mean it doesn't drop glooth stuff but idk if this map have glooth)

13:16 You see a blood beast.
13:16 Loot of a blood beast: a strong health potion, 26 gold coins
13:17 You see a dead cyclops (Vol:30).