currently, there's no test command.

It's time to add a test for zapp command

zapp --help shows each command.

zapp new downloads the initial file from Google Cloud Storage at this moment.

This initial folder is just 23KB.
I want to have it in the local machine when cargo install zapp.

General

seo-orm in general uses a migration based approach, which means that migrations provided by the developer are used to generate the entity code.

Since we are completely based on sea-orm we should follow this approach.

Proposed change

Introduce the following new gen commands:

1. gen migration: Use sea-orm-cli migrate generate my_new_table -u programmatically
2. gen model: Use sea-orm-cli migrate fresh programatically (we probably want a dedicated DB for generation and one DB for the user to tests its app)
3. gen graphql: Use templating of GraphQL, later switch to Seaography

Currently, running zapp docker psql throws an error. This is because the gcp config is parsed (and not present if you do not create it by hand). However, since this is creates a purely local container, forcing the devs to create such a config does not make sense.

Hi there,
thank you for creating this project, it looks super useful!

While going through the code generation done in g, I noticed that the Rust code generation is done through plain string formatting. I also worked on a small project where I needed to generate Rust code and I resorted to this approach at first as well. However, I quickly ran into problems like code generation being dependent on conditionals quickly resulting in annoying string concatenations.

I decided to use the popular quote library to template Rust code in a clean manner, making my life a lot easier and the code cleaner to read (I also used prettyplease to auto-format the generated code).

Maybe this is helpful, but feel free to close if this project goes with the format approach.

My project is here for reference: https://github.com/JonasCir/java2rs

Currently, the repository is not correctly formatted:

1. run cargo fmt
2. introduce github action to reject unformatted PRs

Currently, we abbreviate the generation command with g which is

1. not intuitive
2. the only command we abbreviate with one letter
3. reads strange

I think we should be consistent and rename the command the gen throughout the code base,

Graphql Playground is only for development.

So we need to add ZAPP_ENV and separate the environment.

development: show graphql playground
production: rm graphql playground

@JonasCir made a great refactoring🎉
Let's update all the generation methods.

Example:

Old

create_entity
https://github.com/EpicsDAO/zapp/blob/main/src/g/entity.rs#L13

Good
create_migration
https://github.com/EpicsDAO/zapp/blob/main/src/g/migration.rs#L16

I notice that we invoke binaries all over the place. Get rid of the invocation and use libraries instead.

While this is a general problem, let's focus on the generation submodule first.

There is an ongoing discussion in sea-orm how to use it functionally directly/programmatically.

SeaQL/sea-orm#1036
SeaQL/sea-orm#1047

Now zapp g model generates create_mutation and delete_mutation for mutation.

Let's add the update_mutation function!

https://github.com/EpicsDAO/zapp/blob/main/src/g/graphql/mutation.rs

Go through the command, clean it up, remove unnecessary functions, and use a suitable library to interact with docker (i.e., don't use Command).

Not certain how this is supposed to work: We always define the Help variant in commands in src/cli/mod.rs but do not match it in main.rs. I would assume that we can get rid of this variant and just let do clap its magic when an unknown command is encountered.

Probably something along these lines.

Edit: I just found #[clap(arg_required_else_help = true)].
Edit 2: we should bump clap to the most recent version

Currently, async/await is used all over the place, however, it does not provide any advantage b/c we do not submit any task to an executor or used any concurrency.

I argue that we should selectively re-introduce it properly in parts where it actually makes sense.

You can refer to this resource to learn more.