Dialog titles not displaying about pyface HOT 8 OPEN

Given the following code:

from pyface.api import AboutDialog
dl = AboutDialog(title='TITLEHERE')
import ipdb; ipdb.set_trace()
dl.open()

If i intercept the creation of the dialog, at https://github.com/enthought/pyface/blob/master/pyface/ui/qt4/about_dialog.py#L79
it looks like parent.parent() is resolving to None, resulting in the title attribute being reset.

Confirmed, if I skip this if/else clause, I get the desired behavior

from pyface.

Confirm problem, this is a high priority bug.

from pyface.

Looks like the whole section has some bogus code: eg. https://github.com/enthought/pyface/blob/master/pyface/ui/qt4/about_dialog.py#L85 looks dubious.

Fix looks straightforward (title should be being set when control is created, not when contents are created, which is handled by the base Dialog class already). Bonus points for adding a trait change handler to the title trait... so who wants to do it?

from pyface.

I think the code for setting the default title https://github.com/enthought/pyface/blob/master/pyface/ui/qt4/about_dialog.py#L85 should be fine if it is only executed when self.title is an empty string.

from pyface.

But even better would just be to have a default title trait for about dialogs to be "About" or "About Dialog" or something similar.

from pyface.

The ticket is not specific to AboutDialogs, we have this problem with error dialogs.

from pyface.

From the Qt documentation for QMessageBox.setWindowTitle:

Sets the title of the message box to title. On macOS, the window title is ignored (as required by the macOS Guidelines).

from pyface.

To add more information: the error dialogs that @pberkes was referring to use PyFace's MessageDialog, which under Qt uses QMessageBox. So the fact that we're not seeing the title on those under macOS is unrelated to this issue, and arguably isn't a bug.

The original issue with the "about" dialog still persists.

from pyface.