ensdomains / ui Goto Github PK

Added a couple new functions to get details via labelhash only. Need to add tests

When using a not supported network, I'm getting this error (Unsupported network ${networkId}).
However, it shouldn't be this way.
Instead, on an unsupported network it should just return the main network ENS.

When using a non supported network it should default to mainnet. Doesn't make sense to have a ENS service that only works on mainnet and in different chains have different IDs.
Different networks supports just make sense to testing (testnets).

In Registrar.js, method async makeCommitment(name, owner, secret = '') calls to get address for resolver.eth.

async getAddress(name) {
const provider = await getProvider()
const hash = namehash(name)
const resolverAddr = await this.ENS.resolver(hash)
const Resolver = getResolverContract({ address: resolverAddr, provider })
return Resolver'addr(bytes32)'
}

if we don't create resolver.eth domain, last line of getAddress throws error. So i set resolver.eth domain in my contract.

Now makeCommitment tries to call the method permanentRegistrarController.makeCommitmentWithConfig(
name,
owner,
secret,
resolverAddr,
account
)

Which doesn't exist in latest ETHRegistrarController. It's available in ENS deployment at https://goerli.etherscan.io/address/0x283Af0B28c62C092C9727F1Ee09c02CA627EB7F5#code but not in the code available on github. So makeCommitment method goes to meatmask and it returns error
fromPromise error: Error: missing revert data in call exception; Transaction reverted without a reason string [ See: https://links.ethers.org/v5-errors-CALL_EXCEPTION ] (error={"code":-32000,"message":"execution reverted"}, data="0x", code=CALL_EXCEPTION, version=providers/5.6.5)

Please fix this in UI.

Currently multicoin support is untested unless it's in the ens-app. Tests need to be written in this repo for multicoin support

When searching on app.ens.domains, if a user's search query string includes a "space" it will return an error Domain malformed. ____ is not a valid domain.

Instead, the search input should automatically strip all "space" characters from the query string.

For example: a query for mike demarais or mikedemarais should both return search results for mikedemarais

I created this issue in this repo because the parseSearchTerm function used in ens-app lives in this repo.

Currently only the registry, resolvers have unit tests. Need unit tests to run before publishing the package

Provider is supposed to be optional (according to the docs). However, when not supplying one, I get this error:
Provider required to setup web3

Checking the source I see this:

  customProvider,
  reloadOnAccountsChange = false,
  enforceReadOnly = false,
  enforceReload = false,
  ensAddress
}) {
  if (!customProvider) {
    throw new Error('Provider required to setup web3')
  }

So, it doesn't seem to be optional.

Furthermore, when passing a wagmi or Ethers.js provider, I get "unsupported provider".
For instance, using the default provider from ethers:
const provider = ethers.getDefaultProvider();

Raises this error:
Error: unsupported provider (argument="provider", .... code=INVALID_ARGUMENT, version=providers/5.7.1)

Currently getting errors for non-eth names or subdomains. Make sure this call is skipped instead of logging the error

Unable to install! Not sure what is causing this. Anyone have an idea?

Currently we return the ethers transaction object, we should document this ourselves in case Ethers changes their implementation

setSubnodeOwner can't be called by the controller of the name, only by the controller of the parent name. Also, the function arguments and the documentation don't match.

Change it so it takes the name only and not the label and the node

Can you clarify if it's the provider argument you won't need, or the call to setupENS itself?

You should also specify what it uses as a provider if none is supplied.

Vite/Webpack5 doesn't/won't polyfill node builtins for the browser but can be polyfilled with aliasses. you can use the package the ssr mode on the server

you are getting the warning because the library you are using haven't exported a browser friendly version.
libraries should preferably not be using node builtins.
if a library exports esm format it works best if all its dependencies also have esm export

vitejs/vite#6085

So that we can find out whether all tests are passing.

Currently ENS infura id is hard coded.

This causes ENS app to raise error when someone tries to deploy ENS manager to non whitelisted URL

Error: Returned error: rejected due to project ID settings
    at Object.ErrorResponse (errors.js:29)
    at index.js:125

When invoking setupENS() I'd like to pass an ethers provider. At AirSwap we've completely migrated away from Web3 and our apps are built exclusively on Ethers now. However, it looks like the customProvider in the optional config only works with a Web3 provider.

Attempting to pass an Ethers provider will fail like in the error below:

I notice that you also use Ethers in your package.json. Would you consider adding support for this? Or do you think your repo is too committed to Web3 at this point?

I'm debating whether I should try to make this work myself or just completely stop using this library and try rolling my own ENS integration instead. Appreciate any input you have. Thanks!

For getAddress you should specify what happens if the resolver isn't set.

For getContent you should clarify which this is (I assume it's the content hash support).

Page is blank when there is a non-english utf8 chinese character present in the subdomain page .
Example URL : https://manager.ens.domains/name/example.eth/subdomains

However, I can still successfully set resolver in URL like https://manager.ens.domains/name/中文.example.eth .. So it's only a UI problem..

Hi, thanks for writing this great lib.

Web3.js is extending its ENS wrapper to support contentHash (for Web3 3392) and would like to copy/adapt the encoding logic in src/utils/contents for that purpose.

Was hoping to paste relevant license and authorship info but can't find the licensing here...

Could you provide any guidance about this?

Perhaps getDomainDetails() should return the expiration date?

Hash of the rest of the name (minus the library)

Probably should be 'label'

Sometimes, get this error while executing "Request to register", and then the progress stopped.

I check the code, it seems not to handle the error. It's better show error or request again. Let users know what happening.